update testng to 7.3.0 #21992
Merged
update testng to 7.3.0 #21992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinlian12
requested review from
aayush3011,
alzimmermsft,
backwind1233,
chenrujun,
danieljurek,
FabianMeiswinkel,
g2vinay,
JimSuplizio,
kirankumarkolli,
kushagraThapar,
mbhaskar,
milismsft,
mitchdenny,
moderakh,
samvaity,
saragluna,
simplynaveen20,
stliu and
yiliuTo
as code owners
ghost
added
the
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
moderakh
reviewed
Jun 2, 2021
| @@ -128,7 +128,7 @@ Licensed under the MIT License. | |||
| <dependency> | |||
| <groupId>org.testng</groupId> | |||
| <artifactId>testng</artifactId> | |||
| <version>6.14.3</version> <!-- {x-version-update;org.testng:testng;external_dependency} --> | |||
| <version>7.4.0</version> <!-- {x-version-update;org.testng:testng;external_dependency} --> | |||
There was a problem hiding this comment.
this is a major version upgrade on testng.
testng is deeply used for running all integration tests. If we are upgrading testng version we should run the full test CI and make sure we have a clean Ci result. before merging.
|
|
||
| @Retention(java.lang.annotation.RetentionPolicy.RUNTIME) | ||
| @Target({METHOD}) | ||
| @interface Tag { |
There was a problem hiding this comment.
in the changeFeedTest.java
There was a problem hiding this comment.
@Test(groups = { "emulator" }, enabled = false, timeOut = TIMEOUT)
@Tag(name = "EnableFullFidelity")
public void changeFeed_fullFidelity_fromNow() throws Exception {
changeFeed_withUpdatesAndDelete(true);
}
|
/azp run java - cosmos - tests |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/check-enforcer override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue: #21777
The JCommander:1.72 is a dependency for org.testng:testing:6.14.3: https://mvnrepository.com/artifact/org.testng/testng/6.14.3
Testing 7.3 and Testing 7.4 both have dependency on JCommander 1.78. But can not upgrade to 7.4 for now, because of bug in testing 7.4:
https://github.com/cbeust/testng/blob/master/CHANGES.txt
Fixed: GITHUB-2493: Avoid NPE from TextReporter execution when a dataprovider method provides null
Also need to update to use https to load testing did due to:testng-team/testng#2023
Note: After upgrading to 7.3, you might experience the following exception when running tests with Intellij: "TestNG by default disables loading DTD from unsecure Urls".
Two ways to solve this issue: