Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RequestContent #21320

Merged
merged 35 commits into from
Jun 28, 2021
Merged

Add RequestContent #21320

merged 35 commits into from
Jun 28, 2021

Conversation

alzimmermsft
Copy link
Member

@alzimmermsft alzimmermsft commented May 11, 2021 •
edited
Loading

Fixes #21896

This PR adds a new type RequestContent. The purpose of RequestContent is to act as a generic wrapper around any underlying data source that will be used as the body of a request.

@alzimmermsft alzimmermsft added Do Not Merge Client This issue points to a problem in the data-plane of the library. Azure.Core azure-core labels May 11, 2021
@alzimmermsft alzimmermsft self-assigned this May 11, 2021
@alzimmermsft alzimmermsft changed the base branch from master to feature/alzimmer/RequestContent June 10, 2021 19:55
@alzimmermsft alzimmermsft changed the base branch from feature/alzimmer/RequestContent to master June 16, 2021 18:07
@alzimmermsft
Copy link
Member Author

/azp run java - storage - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@alzimmermsft alzimmermsft changed the title Prototype for RequestContent Add RequestContent Jun 22, 2021
@alzimmermsft alzimmermsft marked this pull request as ready for review June 22, 2021 20:07
srnagar
srnagar reviewed Jun 25, 2021
View reviewed changes
sdk/core/azure-core/src/main/java/com/azure/core/implementation/util/FileContent.java Outdated Show resolved Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/implementation/util/FileContent.java Show resolved Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/util/RequestContent.java Outdated Show resolved Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/implementation/util/SerializableContent.java Outdated Show resolved Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/util/RequestContent.java Show resolved Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/util/BufferedFluxByteBuffer.java Outdated Show resolved Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/util/RequestContent.java Show resolved Hide resolved
@alzimmermsft alzimmermsft merged commit edbf95c into Azure:main Jun 28, 2021
@alzimmermsft alzimmermsft deleted the AzCore_RequestContent branch June 28, 2021 16:28
@alzimmermsft alzimmermsft mentioned this pull request Jul 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srnagar srnagar srnagar approved these changes

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles JonathanGiles is a code owner

@anuchandy anuchandy Awaiting requested review from anuchandy anuchandy is a code owner

@hemanttanwar hemanttanwar Awaiting requested review from hemanttanwar

@jianghaolu jianghaolu Awaiting requested review from jianghaolu

@lmolkova lmolkova Awaiting requested review from lmolkova lmolkova is a code owner

@mssfang mssfang Awaiting requested review from mssfang mssfang is a code owner

Assignees

@alzimmermsft alzimmermsft

Labels
Azure.Core azure-core Client This issue points to a problem in the data-plane of the library. Do Not Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add RequestContent to azure-core
3 participants
@alzimmermsft @JonathanGiles @srnagar