Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Log Analytics data plane #2113

Merged
merged 6 commits into from
Aug 9, 2018
Merged

Adding Log Analytics data plane #2113

merged 6 commits into from
Aug 9, 2018

Conversation

alexeldeib
Copy link
Contributor

Hi! This is a PR to include functionality for Log Analytics (aka microsoft.operationalinsights RP) data plane access. I came across a few things that I wanted to ask about while I was tweaking the generation:

  • I noticed some large changes recently -- looks like there is no longer a rollup package for data plane services? Any guidance here is appreciated 😄
  • I modeled my pom file off of eventgrid, which was the most similar data plane service I could find. Let me know if this looks okay or if there are any glaring issues.
  • Is there anything particular about the testing setup? The wiki describes live tests, but for the other SDKs I've recorded the sessions for playback. How are these otherwise integrated e.g. into CI?

I've also updated the readme in the main spec repo: Azure/azure-rest-api-specs#3269

Looking forward to your thoughts 😊

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@jianghaolu
Copy link
Contributor

Hi @alexeldeib Yes! There are ongoing efforts trying to make the Java repo similar to azure-rest-api-specs in the structure so that whoever familiar with that repo should find it easy to get hands on the Java repo.

In this process one goal is to individualize each service so that on-demand release job can be possible (otherwise we have to release everything every time). The hope is in the near future there will be a button to release one service at any time you'd like :)

Your changes look good overall - I'll take another close look. To record and playback your tests, add this dependency to your jar: https://github.com/Azure/azure-sdk-for-java/blob/master/storage/resource-manager/v2018_02_01/pom.xml#L69. You will have access to class TestBase.java and environment variable AZURE_TEST_MODE (Playback/Record).

@alexeldeib
Copy link
Contributor Author

@jianghaolu Sorry for the slow follow up -- I see that authentication via the java runtime defaults to using ARM for the AAD token audience. We have a custom endpoint and use a different token audience for authentication. Would it be appropriate to do something in the runtime similar to KeyVault/Graph/Data Lake and add our endpoint to the AzureEnvironment file? We did something similar already for PowerShell (we only support commerical and USGov clouds currently).

Or, sidestepping that entirely, is there a way I can authenticate using a custom token audience using adal4j or another existing feature? I mentioned we worked around this for PowerShell; for C# SDK we didn't need to because the runtime implementation of ApplicationTokenProvider has a static method that fit our needs.

@alexeldeib
Copy link
Contributor Author

@jianghaolu bump?

@alexeldeib
Copy link
Contributor Author

@milismsft @anuchandy could one of you comment on the above about authentication with custom AAD resource in java sdk?

@jianghaolu
Copy link
Contributor

@alexeldeib Sorry for the late response from my side :( Yes we can totally add your endpoint to it. Please file an issue here: https://github.com/azure/autorest-clientruntime-for-java/ with your endpoint and token audience info and we can prioritize it. You are welcome to send a pull request yourself if you need it within a week.

@jianghaolu jianghaolu merged commit 323ff6c into Azure:master Aug 9, 2018
AutorestCI added a commit that referenced this pull request Aug 13, 2018
* Add implementation for Cognitive Services Bing Auto Suggest (#2264)

* Add implementation for Cognitive Services Bing Auto Suggest
* Update pom.xml files to reflect the new directory structure in github and bump version to 1.0.2
* Update LUIS Runtime auto-gen'ed SDK files using latest specs.
* Update ComputerVision auto-gen'ed SDK files using latest specs.
* Generate SDKs for CustomVision Prediction and Training.

* Update LUIS Authoring auto-gen'ed SDK files using latest specs. (#2276)

Update manager classes for CustomVision Prediction and Training.

* Regenerate network with 2018-06-01 added (#2288)

* Generated from 1dda4e455040e612e0553c6d9503d29509cde751 (#2247) (#2256)

Add iotcentral version 2018-09-01

* Generate notification hubs and hdinsight (#2307)

* Generate notification hubs

* Generate hdinsight

* Manually fix notification hubs

* Adding Log Analytics data plane (#2113)

* adding log analytics data plane

* update pom.xml

* update row type, version correctly, rebase off master, update tests

* Remove exposed credentials; delete associated app

* update tests

* add test recording

* Generated from cde7e7b7e45936737e64c5ad9ad43fdb5a36ab2e

Add PublicIpPrefix Subresource to VirtualMachineScaleSetPublicIPAddressConfigurationProperties
AutorestCI added a commit that referenced this pull request Dec 5, 2018
…o be more consistent (#2746)

* Initial commit

* Initial commit

* Initial commit

* Key Vault generated code and POM files

* Updated the Key Vault client generated code

* Updated Key Vault SDK based on none fluent AutoRest and costumized code for method calls with long list of optional properties

* Removing lambda expression and listing by nextLink. The nextLink listing operation is handled implicitly by Azure core

* Working core, cryptography and extensions using a FutureAdapter.

* Updating the API version, documentation, remove policy as mandatory parameter, fix AdminDetails tag

* Update POM packages for core, cryptography, extensions

* Dropping implementation namespace, fix test bug and adding comments

* changing x5t to x509Thumbprint, adding key ID to secret and updating documentations for the WebKey types to reflect the accepted types

* Use Guava Futures

* Using ListenableFuture as async return type for Key Vault

* Adding the MIT License Header

* Remove various Future subclasses and use futures.immediateFuture instead.

* Fixing projects name and dependency

* Updating documentations

* Fixing the javadoc error and formatting errors for key vault

* Java Cryptography Test Case update

* Fixed to the key vault certificate feature and tests.
1) getObjests is changed to listObjects
2) Removed getObjectsNext as this is controlled by the library
3) Changes the request parameters for some update* operations to reflect mandatory and optional parameters.
4) Added tests for Async and some additional tests

* RS256 Signature support.

* Adding managed field for certifciates and use base class of attributes in request classes.

* Crypto test cases for excess key material support to match .NET

* Refactoring JSON web key to KV webkey project

* License, documentation and byte array handling update.

* Fix RSA256 signature

* Generated code returns observables

* Keyvault refactoring

* Fix checkstyle errors

* Revert keyvault changes

* Minor signature code cleanup

* Adapting the observer model for Key Vault wrapped client, fixed build becaue incompatibility with runtime and instead of using constant string for JWK algorithms use static class representations

* fix styling errors and addressed feedback.

* Remove .getBody for ListanableFuture to accomodate the recent breaking change

* key vault cryptography refactoring. Removing additional methods from ByteExtension and using Arrays extension methods where applicable.
Changed static final names to all caps.

* Removing the ServiceResponse<> off return type and remove with*() for readonly objects.

* Adding more functionalities to JsonWebKey: AES key conversions, verify, equals, clear memory and tests.

* Update AesCbcHmac test vectors and add more tests from RFC7518

* Update additional pom.xml for annotation build break

* Additional pom.xml updates for build break fix.

* Removed annotation dependency from keyvault libs

Removed annotation dependency from keyvault libs

* Change IssuerReference to IssuerParameters and adding CertificateType.

* [release] Prepare for next development iteration (1.0.0-beta4-SNAPSHOT)

* Remove runtimes from SDK

* [release] Bump up version to 1.0.0-beta3

* Cryptography package updates

* Updating the api-version and adding innererror

* Keyvault cryptography beta3.1 release

* Prepare for next iteration of development

* [release] Prepare for beta5 development iteration

* [release] Prepare for beta4.1 release

* [release] Change versions back to development iteration

* Updating Key Vault Java SDK to use the latest Runtime Client.

* [release] Prepare for beta6 development iteration

* [#1322] Upgrade guava to 20.0

* Rename ServiceCall to ServiceFuture

* Add pom files

* Add simple travis config

* Remove azure-client-authentication as dependency

* Fix scm connection in pom.xml

* [maven-release-plugin] prepare release v1.0.0

* [maven-release-plugin] prepare for next development iteration

* Update pom.xml

* Update pom.xml

* Refactored KeyVaultClient to accomodate autogenerated KeyVaultClientBase interface and KeyVaultClientBaseImpl implementation as well as pre-existing custom code

* reshuffled class inheritance to have models inherit from custom classes

* Updating .travis to accomodate CI

* Updating keyvault-extensions to work with travis CI

* updated .gitignore

* Changes to fix PR

* removed unecessary gitignores

* Added script to preserve custom code upon regenerating models from autorest

* Updated with autorest code sans Storage and Sas models

* Added a 4096 constant

* Updated tests to incorporate new features and soft-delete

* Added check to not have thread sleep during playback

* Fix all JavaDoc reported issues.

* Updated pom to ignore session-records on clean

* Updated versioning for poms

* Updated versioning qualifiers to match convention

* Updated readme

* updated following review

* Updated to add building/testing details.

* Updated with preview swnagger and re-recorded tests

* Fix mvn clean package

* Update ADAL version

* Add PS* JsonWebKeySignatureAlg constants

* updated and rerecorded tests for azure-keyvault-extensions

* Update README.md

* Updated versioning for pom

* Update readme with unlimited crypto install

* Minor updates to RsaKey to make it more similar to EC Key changes

* Updated versioning for parent and azure-keyvault

* Updates to JsonWebKey to accomodate EC keys

* Added ECKeys implementation

* Updated with 3-21 keyvault previe-swagger

* Got ride of azure-keyvault JsonWebKeyCurveName dependency

* Removed bouncycastle dependency from jwk

* Updates to ECKey following changes for JWKCurveName and JWK bouncycastle dependency

* changed to SunEC default provider

* Disallowing null kid for EcKey

* Added kid check back in

* fixing versioning

* Fixed javadoc errors

* modifications to exception throwing

* script to automatically make necessary changes to generated code; regen sdk using script to include cert flag fix

* update regen script

* remove old post processing script

* update readme to reference newest version

* update other package versions

* add docs for regeneration script

* Implement message security

* Add missing dependency

* Update expected signature in crypto tests + fix tabs

* Add EKV unit tests

* Use local version of cryptography jar

* Fix jar name

* Fix jar path

* Fix review comments

* Update test with encrypted key

* Update comments & modifiers

* Remove unnecessary tests

* Update todo comment

* Fix test to rest KVClient before each test

* Fix tests

* Update records

* Update records

* Ensure message protection works for keys create\delete

* Updated EC key algos to take in hashed digests (secp256k1 not working, testing still)

* Neglected to add ecdsa256

* Updated exception for test

* got rid of print statements

* Updated error message

* Fixing JavaDoc issues

* Added msak tests

* Updated pom.xml

added azure-mgmt-keyvault's versioning

* Updating dependency versioning

updated msak recordings

* Updated to 7.0

* Updated Es256K name

* Updated P256k

* Updated formatting, etc., to comply with mvn:checkstyle

* Created history.md

Release history

* Updated Readme

* Moved scopes for some dependencies to test only

* Updated pom to point to remote dependencies

* Generated from 1dda4e455040e612e0553c6d9503d29509cde751 (#2247) (#2256)

Add iotcentral version 2018-09-01

* Generate notification hubs and hdinsight (#2307)

* Generate notification hubs

* Generate hdinsight

* Manually fix notification hubs

* Added section for links to previous versions

* Added a sample repo section

Added a table showing the various categories of features shown by the samples.

* Added build badge

* Added more visible documentation link

* Added alpha and beta releases to previous versions

* Fixed typo in markdown link code

* Adding Log Analytics data plane (#2113)

* adding log analytics data plane

* update pom.xml

* update row type, version correctly, rebase off master, update tests

* Remove exposed credentials; delete associated app

* update tests

* add test recording

* Samples link directly to GitHub repos

* Undid minor irrelevant linebreak.

* Removed extranious change (due to whitespace)

* Fixed minor dependency issue and resolved broken test

* Update LUIS Authoring auto-gen'ed SDK files using latest specs. (#2327)

* Update LUIS Authoring auto-gen'ed SDK files using latest specs.

* Update runtime and fluent sdk version (#2334)

* Update runtime and fluent sdk version

* Update references to parent

* Fixed a bug that prevented tests from passing when using azure-keyvault-webkey 1.1

* version updates

* More versioning changes

* Fixed parent version in extensions

* Add App Insights data plane query SDK (#2314)

* Add App Insights SDK

* remove events odata metadata (XML)

* remove test record for XML

* Pom changes (#53)

* Added a new POM file that encapsulates dependencies on all five modules

* Made com.microsoft.azure:azure-client-authentication scope to test

* Added some dependency management features

* Modified dependencyManagement

* Cleaned up webkey

* Cleaned up cryptography

* Cleaned up core

* Added in used but undeclared dependencies

* Removed dependency on commons-io, which appears unneeded

* Cleaned up unused dependencies in extensions and fixed minor typographical problems

* Added undeclared, but used, dependencies to extensions

* Added some more  package versions to the POMP

* Extracted shared versions to parent pom

* Added explicit dependencies to extensions and fixed some minor errors

* Fixed some indentation differences

* Fixed IT bug:

* Updated all versions to 1.1.1

* fixed dependency version error

* Updated integration-test path

* Allow authentication for ApplicationTokenCredentials for profiles (#2386)

* Commit for 1.1.1

* EventGrid DataPlane SDK: Regenerate the SDK based on latest Swagger to include new event types. (#2341)

* Regenerated EventGrid dataplane SDK for Java to account for new/updated event types.

* Updated version in pom.xml.

* Add Log Analytics readme + example (#2363)

* Add Log Analytics readme + example

* Add App Insights readme, minor fixes

* working on tests

* update test location + readme

* fix link spacing

* prefer relative links, because github breaks absolute links all the time.

* remove AI due to addlProps not working

* Add SDK functionality to make it easier to deserialize/consume EventGrid events (#2426)

* Adding support for deserialize/conusme (custom) eventgrid events

* Tests for deserialize/conusme (custom) eventgrid events utility (EventGridSubscriber)

* Adding beta annotation for EventGridSubscriber and associated types, rename mappingExists -> containsMappingFor

* Simplifying code using canonicalizeEventType(String), improved custom mapping lookup methods, adding method to return all custom mapping and adding new IoT & resource events

* Adding tests for new IoT [Connected|Disconnected] & resource [Action*] events

* Rename getAllCustomEventMapping() -> getAllCustomEventMappings(), adding tests for custom mapping operations

* [AutoPR] storage/resource-manager (#2134)

* Generated from 0c9b4e4b408e4017fca14b4141d0169916d4f703 (#2133)

[Storage] Support hdfs feature.

* [AutoPR storage/resource-manager] [Storage] Set the SignedResource as optional in ListServiceSAS (#2246)

* Generated from 7882bc39a752f3adf4c47186c926094ab65cedc9

[Storage] Set the SignedResource as optional in ListServiceSAS

* Generated from b36d0991a7cc9a7185fc6b7d7ef6919f63435234

[Storage] Fix a format issue.

* Generated from ccc587e3e35b74ffb3b1470c515f988f55ffa134 (#2433)

Add Java support for storage 2018-07-01

* Generated from 61e0377e22894d6330b24ea9cd37c34a0549329b (#2434)

Add storage package-2018-07 to Go SDK

* Fix storage parent version

* Use preview autorest.java

* Update appinsights & loganalytics runtime version (#2440)

* Update appinsights & loganalytics runtime version

* Move sample to correct location

* App Insights readme and sample (#2442)

* add App insights java info back

* Migrate example and remove JDK 8 features.

* fix bugs and pom

* change package, add disclaimer.

* [AutoPR] containerregistry/resource-manager (#2176)

* Generated from 16f9e23c3d97f360447f72c29d68cb71885197bb (#2143)

minor

* Generated from de6b3a1607eaca8bef4a23e3323ad6352d4a9a5f (#2150)

Fix list builds odata query

* Generated from 86b5463c9e7a593a222031b8c652836efb5f159f (#2316)

add option to import images from public registries

Allows users to import images from public registries instead of only Azure Container Registries.  Only one registry source can be specified.

* [AutoPR containerregistry/resource-manager] Azure container registry build feature GA API specification and examples. (#2312)

* Generated from 9287b2d8d81830b265620ee97d5ca5ddda400d26

Azure container registry build GA API specification and examples.

* Generated from a3b1cb94eef44835709c9dd5944e76537585831e

Removed Alias and secrets  property from task.

* Generated from 40798dd592ce0d63c1fc0086f983241f7471269b

Update readme.md to include tags for all languages

* Generated from fd9d36edfbdcdd3f434fd8fcac2868cd8c3007d6

Updated the operation ID as per the feedback

* Generated from 8211af77ca617639df4c4668ca621b6f65c05918 (#2349)

Renamed BuildTask to FileTask and RunTask to EncodedTask

* Generated from 13f78c9f9be8ff71afffbe76b21c7b0687b70ea8 (#2436)

Add ContextPath and source location URL for encode task and run type, add support for pull request based trigger.

* Update poms for container registry

* Generated from dee4fc5bf36e06fd0cd1606d0a5b9be728a06c73 (#2459)

Move ACR C# specific config to C#

* Update poms for container registry

* Removed duplicate dependency (#2461)

* Added mediaservices sdk (#2475)

* added mediaservices sdk 2018-07-01

* updated poms for mediaservices 2018-07-01 and removed erroneous file

* Add data lake analytics and store (#2477)

* Add data lake analytics and store

* Update poms for data lake libraries

* testing for datalakestore & datalakeanalytics (#2511)

* testing for datalakestore & datalakeanalytics

* change directory to package

* [AutoPR] iotcentral/resource-manager (#2413)

* Generated from 1dda4e455040e612e0553c6d9503d29509cde751 (#2247)

Add iotcentral version 2018-09-01

* [AutoPR iotcentral/resource-manager] IoTCentral - Add ARM endpoint, update model responses/inputs to align with expected values (#2431)

* Generated from ddbb8ffb2dd676863a74cd5d44748fbd93a93025

Update models to align with expected responses

* Generated from 09b4a4594660bc1c21dc7122a3784f64867a041e

Fix build errors

* Generated from 1c89739e3a40c9bf7a6f40e86367d50e6b88f776

Add required field to definitions

* Generated from 2a67d7be3a9b0c1f55324bd0059ff0dc1077a4ff

Remove typo

* Generated from f0df5982f4b75520b1b163b84ea33c9a81d6e79b

add x-ms-client-flatten to errorSchema

* Merging Dev to Master (#69)

* Do not cache unversionned keys

* Brihicks/fix gauva26.0 problems (#63)

* Fixed issues resulting from incompatibilities with Guava 26.0
* Updated versioning

* Update pom.xml (#66)

* Versioning fix

* Update pom.xml

* Updated versions of all files 1.1.2

* Merge for 1.1.2 (#73)

* Do not cache unversionned keys

* Brihicks/fix gauva26.0 problems (#63)

* Fixed issues resulting from incompatibilities with Guava 26.0
* Updated versioning

* Update pom.xml (#66)

* Versioning fix

* Update pom.xml

* Updated versions of all files 1.1.2

* Fixed test error (#72)

* Merging Dev to Master (#69)

* Do not cache unversionned keys

* Brihicks/fix gauva26.0 problems (#63)

* Fixed issues resulting from incompatibilities with Guava 26.0
* Updated versioning

* Update pom.xml (#66)

* Versioning fix

* Update pom.xml

* Updated versions of all files 1.1.2

* Fixed test error

* Update README.md (#74)

* Latest authorization (#2361)

* [AutoPR] datamigration/resource-manager (#2570)

* Generated from a4cf10ec40bbbcfe492dd714c71c8e9f5758e79e (#2569)

Add azure-sdk-for-java entry

* Fix build

* latest network (#2135)

* [AutoPR] containerinstance/resource-manager (#2292)

* Generated from 130558caf04982e77015ceb76133473847b3f061 (#2291)

Fix errors in container group update example

* Generated from 9a5541421e8815773449ba570834099b97025183 (#2452)

Moving MSI Identity object to correct properties

* Generated from b28170d473471c298dc43f09299dd655d8e03982 (#2555)

Update swagger with DNSConfig and GPU

* Update poms

* Fix compile error

* Update status badge to correct repo (#2582)

* [fixes #2564] Support subscriptions and authorization (#2588)

* Add template for client package (#2587)

* Add status badge for client libraries (#2605)

* Adding keyvault sdk to CI pipeline (#2619)

* adding keyvault sdk to CI pipeline

* adding keyvault sdk to CI pipeline

* adding keyvault sdk to CI pipeline

* checkstyle

* adding keyvault sdk to CI pipeline

* Replacing Thread.sleep() with SdkContext.sleep() to run tests faster in playback mode

* Renaming environment variables for CI as '.' does not work on linux

* Renaming environment variables for CI

* changing order for CI pipeline jobs

* changing order for CI pipeline jobs

* moving 'checkstyle' task to the 'Publish' job

* removing unused files

* Adding sources packaging to CI pipeline (#2662)

* Update client.yml file to build java repo (#2668)

* Update client.yml file to build java repo
* Set logging options to reduce noise in output.
* Only disable the downloading messages but keep the other messages

* Generated from 10e5ed698dece8c082c064680537ebae7f3a14b7

updating file due to not desired automatic formatting

* Generated from 2f6ff2874bd5221e4a893896305133da6e76fd5f

updating to Microsoft.GraphRbac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants