Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed Beta tag from handle, and readMany APIs #20092

Merged
merged 2 commits into from
Mar 24, 2021
Merged

Removed Beta tag from handle, and readMany APIs #20092

merged 2 commits into from
Mar 24, 2021

Conversation

kushagraThapar
Copy link
Member

@kushagraThapar kushagraThapar commented Mar 24, 2021 •
edited
Loading

  • Removed Beta tag from handle, and readMany APIs

@ghost ghost added the Cosmos label Mar 24, 2021
moderakh
moderakh reviewed Mar 24, 2021
View reviewed changes
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosDiagnostics.java Outdated
@@ -79,7 +79,6 @@ public Duration getDuration() {
* Regions contacted for this request
* @return set of regions contacted for this request
*/
@Beta(value = Beta.SinceVersion.V4_9_0, warningText = Beta.PREVIEW_SUBJECT_TO_CHANGE_WARNING)
public Set<URI> getRegionsContacted() {
Copy link
Contributor

@moderakh moderakh Mar 24, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we postpone GAing the getRegionsContacted() API for now.
I suspect we may need to return a different type. perhaps a Set<URL> or Set<String>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the feedResponseDiagnostics doesnt return all the values for this and currently just null. So its worth waiting to fix that part too for GA

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moderakh - makes sense, reverted this API back to Beta.

moderakh
moderakh approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@moderakh moderakh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am signing off pending one comment on the getRegionsContacted().

"can we postpone GAing the getRegionsContacted() API for now.
I suspect we may need to return a different type. perhaps a Set<URL> or Set<String>"

@kushagraThapar kushagraThapar changed the title Removed Beta tag from handle, getRegionsContacted, and readMany APIs Removed Beta tag from handle, and readMany APIs Mar 24, 2021
@kushagraThapar kushagraThapar merged commit 4802792 into Azure:master Mar 24, 2021
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Aug 5, 2022
CodeGen from PR 20092 in Azure/azure-rest-api-specs
2fa52a3 
migrate to .net track 2 batch 2 (Azure#20092)
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Aug 5, 2022
CodeGen from PR 20092 in Azure/azure-rest-api-specs
367351d 
migrate to .net track 2 batch 2 (Azure#20092)
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Aug 5, 2022
CodeGen from PR 20092 in Azure/azure-rest-api-specs
1ea267a 
migrate to .net track 2 batch 2 (Azure#20092)
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Aug 5, 2022
CodeGen from PR 20092 in Azure/azure-rest-api-specs
1c1b591 
migrate to .net track 2 batch 2 (Azure#20092)
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Aug 5, 2022
CodeGen from PR 20092 in Azure/azure-rest-api-specs
7323afd 
migrate to .net track 2 batch 2 (Azure#20092)
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Aug 5, 2022
CodeGen from PR 20092 in Azure/azure-rest-api-specs
8222843 
migrate to .net track 2 batch 2 (Azure#20092)
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Aug 5, 2022
CodeGen from PR 20092 in Azure/azure-rest-api-specs
77beb59 
migrate to .net track 2 batch 2 (Azure#20092)
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Aug 5, 2022
CodeGen from PR 20092 in Azure/azure-rest-api-specs
b84ebae 
migrate to .net track 2 batch 2 (Azure#20092)
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Aug 5, 2022
CodeGen from PR 20092 in Azure/azure-rest-api-specs
ee783ab 
migrate to .net track 2 batch 2 (Azure#20092)
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Aug 5, 2022
CodeGen from PR 20092 in Azure/azure-rest-api-specs
4f25e5a 
migrate to .net track 2 batch 2 (Azure#20092)
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Aug 5, 2022
CodeGen from PR 20092 in Azure/azure-rest-api-specs
27c4fc1 
migrate to .net track 2 batch 2 (Azure#20092)
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Aug 5, 2022
CodeGen from PR 20092 in Azure/azure-rest-api-specs
75a20e8 
migrate to .net track 2 batch 2 (Azure#20092)
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Aug 5, 2022
CodeGen from PR 20092 in Azure/azure-rest-api-specs
f43acc4 
migrate to .net track 2 batch 2 (Azure#20092)
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Aug 5, 2022
CodeGen from PR 20092 in Azure/azure-rest-api-specs
b2c5d55 
migrate to .net track 2 batch 2 (Azure#20092)
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Aug 5, 2022
CodeGen from PR 20092 in Azure/azure-rest-api-specs
0bc2db3 
migrate to .net track 2 batch 2 (Azure#20092)
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Aug 5, 2022
CodeGen from PR 20092 in Azure/azure-rest-api-specs
8810d61 
migrate to .net track 2 batch 2 (Azure#20092)
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Aug 5, 2022
CodeGen from PR 20092 in Azure/azure-rest-api-specs
b759622 
migrate to .net track 2 batch 2 (Azure#20092)
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Aug 5, 2022
CodeGen from PR 20092 in Azure/azure-rest-api-specs
3eb3383 
migrate to .net track 2 batch 2 (Azure#20092)
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Aug 5, 2022
CodeGen from PR 20092 in Azure/azure-rest-api-specs
6ec3720 
migrate to .net track 2 batch 2 (Azure#20092)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moderakh moderakh moderakh approved these changes

@FabianMeiswinkel FabianMeiswinkel Awaiting requested review from FabianMeiswinkel

@kirankumarkolli kirankumarkolli Awaiting requested review from kirankumarkolli

@mbhaskar mbhaskar Awaiting requested review from mbhaskar

@milismsft milismsft Awaiting requested review from milismsft

@simplynaveen20 simplynaveen20 Awaiting requested review from simplynaveen20

@xinlian12 xinlian12 Awaiting requested review from xinlian12

Assignees
No one assigned
Labels
Cosmos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kushagraThapar @mbhaskar @moderakh