Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add step annotate and improve AADHandleConditionalAccessFilter for Conditional Access. #19681

Merged
merged 4 commits into from
Mar 8, 2021
Merged

Add step annotate and improve AADHandleConditionalAccessFilter for Conditional Access. #19681

merged 4 commits into from
Mar 8, 2021

Conversation

han-gao
Copy link
Contributor

@han-gao han-gao commented Mar 7, 2021 •
edited
Loading

  1. Add conditional access annotate steps.
  2. Change the conditional access code and use OAuth2AuthorizationRequestRedirectFilter to handle exceptions.
  3. Add handling of unauthorized access.
  4. Remove useless imports.

@ghost ghost added the azure-spring All azure-spring related issues label Mar 7, 2021
@chenrujun chenrujun self-assigned this Mar 8, 2021
@chenrujun
Copy link

Hi, @han-gao .
It's better to add description when you create a PR.

chenrujun
chenrujun approved these changes Mar 8, 2021
View reviewed changes
Copy link

@chenrujun chenrujun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chenrujun chenrujun enabled auto-merge (squash) March 8, 2021 06:50
@chenrujun chenrujun merged commit ce0f46a into Azure:master Mar 8, 2021
@han-gao han-gao deleted the improve_conditional_access branch March 8, 2021 09:04
@saragluna saragluna added the azure-spring-aad Spring active directory related issues. label Mar 9, 2021
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Jul 19, 2022
CodeGen from PR 19681 in Azure/azure-rest-api-specs
c7396a4 
Mobile Network API version 2022-04-01-preview (Azure#19681)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrujun chenrujun chenrujun approved these changes

@backwind1233 backwind1233 Awaiting requested review from backwind1233

@jialindai jialindai Awaiting requested review from jialindai

@saragluna saragluna Awaiting requested review from saragluna

@stliu stliu Awaiting requested review from stliu

@yiliuTo yiliuTo Awaiting requested review from yiliuTo

Assignees

@chenrujun chenrujun

Labels
azure-spring All azure-spring related issues azure-spring-aad Spring active directory related issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@han-gao @chenrujun @saragluna