Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving feedrange from query api parameter to CosmosQueryRequestOptions #19608

Merged
merged 5 commits into from
Mar 5, 2021

Conversation

mbhaskar
Copy link
Member

@mbhaskar mbhaskar commented Mar 4, 2021

  • Moving feedrange from query api parameter to CosmosQueryRequestOptions
  • Adding tests for feedrange based queries

Copy link
Contributor

@moderakh moderakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @mbhaskar

we should decide what to do if both PartitionKey and FeedRange are set. (can be done later outside of the scope of this PR)

@mbhaskar
Copy link
Member Author

mbhaskar commented Mar 4, 2021

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mbhaskar
Copy link
Member Author

mbhaskar commented Mar 4, 2021

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mbhaskar
Copy link
Member Author

mbhaskar commented Mar 5, 2021

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mbhaskar mbhaskar enabled auto-merge (squash) March 5, 2021 22:59
@mbhaskar mbhaskar merged commit 59319d2 into Azure:master Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants