update readme for aad starter #18826

zhichengliu12581 · 2021-01-27T02:37:17Z

Move code and configuration files from example to key concepts

sdk/spring/azure-spring-boot-starter-active-directory/README.md

chenrujun · 2021-01-28T00:48:59Z

My suggestions:

Move Include the package to related usage scenarios like Web application and Resource Server.
Move Configurable properties after Use Azure China instead of Azure Global.

sdk/spring/azure-spring-boot-starter-active-directory/README.md

check-enforcer · 2021-01-28T02:20:30Z

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

…97-abel/azure-sdk-for-java into update-readme-for-starter

sdk/spring/azure-spring-boot-starter-active-directory/README.md

chenrujun · 2021-01-28T08:13:54Z

sdk/spring/azure-spring-boot-starter-active-directory/README.md

+Based on Azure AD as a Resource Server, it uses `BearerTokenAuthenticationFilter` authorize request. The current resource server also can access other resources, there's a similar method to the web application usage to obtain access to the client access token, the difference is the access token obtained based on the `MSAL On-Behalf-Of` process.
+
+#### System diagram
+Only as a Resource Server, no further access to other resources protected by Azure AD.


To keep same style, no text between #### System diagram and the image. Move to ### Resource Server.

...ctive-directory/resource/source-file/add-based-resource-server-access-other-resources.drawio

chenrujun

LGTM.

[Compute] Disk 2022-03-02 (Azure#19116) * new version folder * new version folder * sync with diskRP 2021-12-01 changes * Update creationData description (Azure#18050) * Update diskRPCommon.json * Update diskRPCommon.json * adding SecurityProfile in DiskRestorePointProperties (Azure#18826) * add cross-tenant feature (Azure#18718) * add cross-tenant feature * fix filename typo * prettier * Swagger changes for PremiumV2 in DiskRP (Azure#18786) * Swagger changes for PremiumV2 in DiskRP * Added new property copyCompletionError * Updated description for new property copyCompletionError * Added the type as object for CopyCompletionError * Addressed comment to update the description for CopySourceNotFound Co-authored-by: akashpargat <akashpargat@microsoft.com> * Add new Azure Compute Gallery image ids to ImageDiskReference for PutDisk Support in 2022-03-02 Api Version (Azure#18868) * new sig ids for put disk 2022-03-02 * fix errors and add example path * extra space * remove required id * prettify common Co-authored-by: Jerry Chan <jerch@microsoft.com> * Feature/cplat 2022 03 02 (Azure#18945) * add cross-tenant feature * fix filename typo * prettier * add federatedClientId to diskEncryptionSetUpdateProperties * New ApI Version * Readme changes * adding SecurityProfile in DiskRestorePointProperties (Azure#18826) * add cross-tenant feature (Azure#18718) * add cross-tenant feature * fix filename typo * prettier * Swagger changes for PremiumV2 in DiskRP (Azure#18786) * Swagger changes for PremiumV2 in DiskRP * Added new property copyCompletionError * Updated description for new property copyCompletionError * Added the type as object for CopyCompletionError * Addressed comment to update the description for CopySourceNotFound Co-authored-by: akashpargat <akashpargat@microsoft.com> * Add new Azure Compute Gallery image ids to ImageDiskReference for PutDisk Support in 2022-03-02 Api Version (Azure#18868) * new sig ids for put disk 2022-03-02 * fix errors and add example path * extra space * remove required id * prettify common Co-authored-by: Jerry Chan <jerch@microsoft.com> * Feature/cplat 2022 03 02 (Azure#18945) * add cross-tenant feature * fix filename typo * prettier * add federatedClientId to diskEncryptionSetUpdateProperties * GET snapshot-Changed CopyCompletionError enum name (Azure#19160) Co-authored-by: Karan Manish Thakkar <kathakkar@microsoft.com> * move UserAssignedIdentities to common.json to fix duplicate definition * update readme with gallery 2022-01-03 * sync with past updates * update with description for object * fix readme * GET snapshot-Changed CopyCompletionError enum name (Azure#19227) Co-authored-by: Karan Manish Thakkar <kathakkar@microsoft.com> * fixing readme.md * fix vmss userAssignedIdentities duplicate definition Co-authored-by: Theodore Chang <thchan@microsoft.com> Co-authored-by: anshulsolanki21 <73930854+anshulsolanki21@users.noreply.github.com> Co-authored-by: parkhyukjun89 <hyupar@microsoft.com> Co-authored-by: Akash Pargat <akashpargat@yahoo.com> Co-authored-by: akashpargat <akashpargat@microsoft.com> Co-authored-by: jerryc3 <48365571+jerryc3@users.noreply.github.com> Co-authored-by: Jerry Chan <jerch@microsoft.com> Co-authored-by: Karan Manish Thakkar <kkaran.thakkar@gmail.com> Co-authored-by: Karan Manish Thakkar <kathakkar@microsoft.com> Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com>

Move code and configuration files from example to key concepts

51cf628

zhichengliu12581 requested review from backwind1233, chenrujun, jialindai, saragluna and yiliuTo as code owners January 27, 2021 02:37

ghost added the azure-spring All azure-spring related issues label Jan 27, 2021

zhichengliu12581 added 2 commits January 27, 2021 11:36

Replace the webapi code in the sample code with the webapp code

d98a007

add Next steps for pipeline

7fd22d6

chenrujun suggested changes Jan 27, 2021

View reviewed changes

sdk/spring/azure-spring-boot-starter-active-directory/README.md Outdated Show resolved Hide resolved

sdk/spring/azure-spring-boot-starter-active-directory/README.md Outdated Show resolved Hide resolved

chenrujun reviewed Jan 27, 2021

View reviewed changes

sdk/spring/azure-spring-boot-starter-active-directory/README.md Outdated Show resolved Hide resolved

Modify the content display order

221a977

chenrujun suggested changes Jan 28, 2021

View reviewed changes

sdk/spring/azure-spring-boot-starter-active-directory/README.md Outdated Show resolved Hide resolved

sdk/spring/azure-spring-boot-starter-active-directory/README.md Outdated Show resolved Hide resolved

Modify the structure of the readme file

83b6cf1

zhichengliu12581 added 2 commits January 28, 2021 10:33

Merge branch 'update-readme-for-starter' of https://github.com/lzc-19…

65f7003

…97-abel/azure-sdk-for-java into update-readme-for-starter

merge master

119e25d

chenrujun suggested changes Jan 28, 2021

View reviewed changes

chenrujun reviewed Jan 28, 2021

View reviewed changes

sdk/spring/azure-spring-boot-starter-active-directory/README.md Outdated Show resolved Hide resolved

chenrujun reviewed Jan 28, 2021

View reviewed changes

sdk/spring/azure-spring-boot-starter-active-directory/README.md Outdated Show resolved Hide resolved

zhichengliu12581 added 2 commits January 28, 2021 15:53

modify pictures and optimization doc

f53e4af

nothing changed, just modify case

11dd0ae

chenrujun suggested changes Jan 28, 2021

View reviewed changes

zhichengliu12581 and others added 2 commits January 28, 2021 16:45

rename files and format readme

b0f22b7

Merge branch 'master' into update-readme-for-starter

ef037b1

chenrujun enabled auto-merge (squash) January 29, 2021 00:17

chenrujun approved these changes Jan 29, 2021

View reviewed changes

chenrujun merged commit 957bfc5 into Azure:master Jan 29, 2021

saragluna added the azure-spring-aad Spring active directory related issues. label Feb 1, 2021

zhichengliu12581 deleted the update-readme-for-starter branch August 24, 2021 08:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update readme for aad starter #18826

update readme for aad starter #18826

zhichengliu12581 commented Jan 27, 2021

chenrujun commented Jan 28, 2021

check-enforcer bot commented Jan 28, 2021

chenrujun Jan 28, 2021

chenrujun left a comment

update readme for aad starter #18826

update readme for aad starter #18826

Conversation

zhichengliu12581 commented Jan 27, 2021

chenrujun commented Jan 28, 2021

check-enforcer bot commented Jan 28, 2021

What is Check Enforcer?

Why am I getting this message?

What should I do now?

What if I am onboarding a new service?

chenrujun Jan 28, 2021

Choose a reason for hiding this comment

chenrujun left a comment

Choose a reason for hiding this comment