Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runs cosmos spark unit tests in CI #17703

Merged
merged 9 commits into from
Dec 2, 2020
Merged

runs cosmos spark unit tests in CI #17703

merged 9 commits into from
Dec 2, 2020

Conversation

moderakh
Copy link
Contributor

@moderakh moderakh commented Nov 20, 2020 •
edited
Loading

  • Ensures cosmos spark unit tests are running in the CI.
  • This only wires up unit tests for now not integration tests.
  • If a spark unit test fails CIs running unit tests will fail.

TODO:

  • we need to wire up integration tests for spark to run tests against either emulator or prod endpoint.
  • suppress jacoco complain in analyzing java byte code generated from scala

sample report for successful spark scala tests running by the CI (current PR):
Screen Shot 2020-12-01 at 6 14 08 PM

@ghost ghost added the Cosmos label Nov 20, 2020
@moderakh moderakh changed the title ensures cosmos spark tests are running in the CI (Don't Review yet, has some issues) ensures cosmos spark tests are running in the CI Nov 20, 2020
@moderakh moderakh changed the title (Don't Review yet, has some issues) ensures cosmos spark tests are running in the CI (Don't Review yet, has some issues) runs cosmos spark unit tests in CI Nov 20, 2020
@moderakh moderakh changed the title (Don't Review yet, has some issues) runs cosmos spark unit tests in CI runs cosmos spark unit tests in CI Dec 1, 2020
FabianMeiswinkel
FabianMeiswinkel approved these changes Dec 2, 2020
View reviewed changes
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks Mo!

@moderakh moderakh merged commit 234cb19 into Azure:feature/cosmos/spark30 Dec 2, 2020
@moderakh moderakh deleted the users/moderakh/cosmos-spark3-run-tests-in-ci branch December 2, 2020 07:47
@moderakh moderakh added the cosmos:spark3 Cosmos DB Spark3 OLTP Connector label Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabianMeiswinkel FabianMeiswinkel FabianMeiswinkel approved these changes

@kirankumarkolli kirankumarkolli Awaiting requested review from kirankumarkolli

@kushagraThapar kushagraThapar Awaiting requested review from kushagraThapar

@mbhaskar mbhaskar Awaiting requested review from mbhaskar

@milismsft milismsft Awaiting requested review from milismsft

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

@simplynaveen20 simplynaveen20 Awaiting requested review from simplynaveen20

@xinlian12 xinlian12 Awaiting requested review from xinlian12

@alzimmermsft alzimmermsft Awaiting requested review from alzimmermsft

@danieljurek danieljurek Awaiting requested review from danieljurek

@JimSuplizio JimSuplizio Awaiting requested review from JimSuplizio

@samvaity samvaity Awaiting requested review from samvaity

Assignees
No one assigned
Labels
cosmos:spark3 Cosmos DB Spark3 OLTP Connector Cosmos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moderakh @FabianMeiswinkel