Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor util and helper classes to their own packages #14919

Merged
merged 3 commits into from
Sep 8, 2020

Conversation

abhipsaMisra
Copy link
Member

@abhipsaMisra abhipsaMisra commented Sep 8, 2020

  • Remove the generic AsyncSample and SyncSample.
  • Move the request options classes to /util package -> right now we have classes being used as input/output response types inside /models or /implementation. All other helper classes are under util. Let me know if this folder structure should be modified.
  • Move the helper classes to their respective packages for samples.
  • Add some comments around usage of CountdownLatch and Semaphore in the digital twin lifecycle async sample.

@ghost ghost added the DigitalTwins label Sep 8, 2020
@abhipsaMisra abhipsaMisra merged commit de09084 into Azure:master Sep 8, 2020
@abhipsaMisra abhipsaMisra deleted the refactorPackages branch September 8, 2020 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants