Fix HttpRequest Body Being Consumed and Sending an Empty Request Body #14915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alzimmermsft
added
Client
ghost
added
App Configuration
|
/azp run java - appconfiguration - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…ix version checks
|
/azp run java - appconfiguration - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - formrecognizer - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - textanalytics - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
alzimmermsft
changed the title
alzimmermsft
requested review from
anuchandy,
danieljurek,
g2vinay,
hemanttanwar,
jianghaolu,
JimSuplizio,
mitchdenny,
mssfang,
samvaity,
schaabs and
srnagar
as code owners
samvaity
approved these changes
Sep 8, 2020
|
/check-enforcer override |
|
Overriding check-enforcer as Azure Pipelines cancelled a couple pipelines which caused it to never report passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves a bug where pipeline operations, such as authorization handling, would consume the
HttpRequestByteBufferbody leading to an empty request body being sent. To resolve the issue theByteBuffercreation is deferred and made replayable so that any side-affect operation won't leave the body empty when the request is finally sent.#14917 acts as a follow-up to validate locations where
HttpRequestbodies are consumed to ensure this issue doesn't happen again.#14918 acts as another follow-up to add a
From Sourcetest run to the daily live tests.