Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(digital-twins): Add query API implementation #14910

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

vinagesh
Copy link
Member

@vinagesh vinagesh commented Sep 8, 2020

Added implementation for Query APIs.
Will be adding samples in the next PR.

@vinagesh vinagesh force-pushed the feature/adt/vinagesh/queryimpl branch 4 times, most recently from 06b7a60 to 9102fc0 Compare September 8, 2020 18:39
Copy link
Member

@abhipsaMisra abhipsaMisra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment about the overload used in the sync client, looks good otherwise!

@vinagesh vinagesh force-pushed the feature/adt/vinagesh/queryimpl branch from 9102fc0 to 0d0ac9c Compare September 8, 2020 18:51
@vinagesh
Copy link
Member Author

vinagesh commented Sep 8, 2020

One comment about the overload used in the sync client, looks good otherwise!

Made the suggested changes. Thanks for the quick review.

@vinagesh vinagesh merged commit 4edb33a into master Sep 8, 2020
@vinagesh vinagesh deleted the feature/adt/vinagesh/queryimpl branch September 8, 2020 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants