-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(digital-twins): Add query API implementation #14910
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinagesh
requested review from
abhipsaMisra,
azabbasi,
barustum,
bikamani,
drwill-ms and
timtay-microsoft
as code owners
September 8, 2020 18:05
ghost
added
the
DigitalTwins
label
Sep 8, 2020
abhipsaMisra
reviewed
Sep 8, 2020
...ure-digitaltwins-core/src/main/java/com/azure/digitaltwins/core/DigitalTwinsAsyncClient.java
Outdated
Show resolved
Hide resolved
abhipsaMisra
reviewed
Sep 8, 2020
...ure-digitaltwins-core/src/main/java/com/azure/digitaltwins/core/DigitalTwinsAsyncClient.java
Outdated
Show resolved
Hide resolved
abhipsaMisra
reviewed
Sep 8, 2020
...ure-digitaltwins-core/src/main/java/com/azure/digitaltwins/core/DigitalTwinsAsyncClient.java
Outdated
Show resolved
Hide resolved
abhipsaMisra
reviewed
Sep 8, 2020
...ns/azure-digitaltwins-core/src/main/java/com/azure/digitaltwins/core/DigitalTwinsClient.java
Outdated
Show resolved
Hide resolved
abhipsaMisra
reviewed
Sep 8, 2020
...ns/azure-digitaltwins-core/src/main/java/com/azure/digitaltwins/core/DigitalTwinsClient.java
Outdated
Show resolved
Hide resolved
abhipsaMisra
reviewed
Sep 8, 2020
...ure-digitaltwins-core/src/main/java/com/azure/digitaltwins/core/DigitalTwinsAsyncClient.java
Show resolved
Hide resolved
abhipsaMisra
reviewed
Sep 8, 2020
...ure-digitaltwins-core/src/main/java/com/azure/digitaltwins/core/DigitalTwinsAsyncClient.java
Outdated
Show resolved
Hide resolved
vinagesh
force-pushed
the
feature/adt/vinagesh/queryimpl
branch
4 times, most recently
from
September 8, 2020 18:39
06b7a60
to
9102fc0
Compare
abhipsaMisra
reviewed
Sep 8, 2020
...ns/azure-digitaltwins-core/src/main/java/com/azure/digitaltwins/core/DigitalTwinsClient.java
Outdated
Show resolved
Hide resolved
abhipsaMisra
reviewed
Sep 8, 2020
...ns/azure-digitaltwins-core/src/main/java/com/azure/digitaltwins/core/DigitalTwinsClient.java
Outdated
Show resolved
Hide resolved
abhipsaMisra
approved these changes
Sep 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment about the overload used in the sync client, looks good otherwise!
vinagesh
force-pushed
the
feature/adt/vinagesh/queryimpl
branch
from
September 8, 2020 18:51
9102fc0
to
0d0ac9c
Compare
timtay-microsoft
approved these changes
Sep 8, 2020
Made the suggested changes. Thanks for the quick review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added implementation for Query APIs.
Will be adding samples in the next PR.