Enhance Playback Record Naming #14801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alzimmermsft
added
Client
alzimmermsft
requested review from
anuchandy,
hemanttanwar,
jianghaolu and
srnagar
as code owners
srnagar
approved these changes
Sep 4, 2020
sdk/core/azure-core-test/src/main/java/com/azure/core/test/InterceptorManager.java
Outdated
Show resolved
Hide resolved
conniey
reviewed
Sep 4, 2020
sdk/core/azure-core-test/src/main/java/com/azure/core/test/InterceptorManager.java
Outdated
Show resolved
Hide resolved
sdk/core/azure-core-test/src/main/java/com/azure/core/test/InterceptorManager.java
Outdated
Show resolved
Hide resolved
sdk/core/azure-core-test/src/main/java/com/azure/core/test/InterceptorManager.java
Outdated
Show resolved
Hide resolved
sdk/core/azure-core-test/src/main/java/com/azure/core/test/TestContextManager.java
Outdated
Show resolved
Hide resolved
This was referenced Sep 9, 2020
…it as part of its unique ID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14789
This PR enhances playback record naming to include the test's class name and its permutation (if applicable). The new test recording name is now
className.testName[permutation]. When loading for test playback both the new and old format, just test name, will be checked before throwing an exception. Recordings are now saved using the new naming convention. This change will reduce the likelihood of test recording name collisions.