Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TA] test live tests in private endpoint #14800

Merged
merged 5 commits into from
Sep 4, 2020

Conversation

mssfang
Copy link
Member

@mssfang mssfang commented Sep 3, 2020

Modified current existing testResources.json and tests.yml files to enable the live test in private endpoint.

@mssfang mssfang added Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics labels Sep 3, 2020
@mssfang mssfang added this to the [2020] September milestone Sep 3, 2020
@mssfang mssfang self-assigned this Sep 3, 2020
@mssfang
Copy link
Member Author

mssfang commented Sep 3, 2020

/azp run java - textanalytics - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@@ -1,5 +1,12 @@
trigger: none

resources:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should not added. I was looking at the .NET's older commint (through the Blame https://github.com/Azure/azure-sdk-for-net/blame/3c6a978b247cce2f071dfa57db2288fb0882e8ca/sdk/textanalytics/tests.yml),

Copy link
Member

@samvaity samvaity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as we roll this back when service endpoint is public, lgtm

@mssfang
Copy link
Member Author

mssfang commented Sep 4, 2020

/azp run java - textanalytics - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@danieljurek danieljurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than edit the test-resources.json which might require reverting later, set DisableAzureResourceCreation: true in the template parameters. That will disable resource deployment for the job, save agent time, and save deploying an unused resource.

When the service GA's appropriately you can revert the changes to tests.yml and you'll have the old way of doing things back.

trigger: none

jobs:
  - template: ../../eng/pipelines/templates/jobs/archetype-sdk-tests.yml
    parameters:
      ServiceDirectory: textanalytics
      Artifacts:
        - name: azure-ai-textanalytics
          groupId: com.azure
          safeName: azureaitextanalytics

      # Add the below line and some note describing why resource creation is disabled
      DisableAzureResourceCreation: true
      EnvVars:
          AZURE_TEXT_ANALYTICS_API_KEY: $(java-textanalytics-test-api-key)
          AZURE_TEXT_ANALYTICS_ENDPOINT: $(java-textanalytics-test-ppe-endpoint-string)

@mssfang
Copy link
Member Author

mssfang commented Sep 4, 2020

/azp run java - textanalytics - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssfang mssfang merged commit 3b8c182 into Azure:master Sep 4, 2020
@mssfang mssfang deleted the TA-LiveTest-PrivateEndpoint branch September 4, 2020 05:06
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-java that referenced this pull request Aug 26, 2021
Mitryakh/network march (Azure#15709)

* Adds base for updating Microsoft.Network from version stable/2021-02-01 to version 2021-03-01

* Updates readme

* Updates API version in new specs and examples

* Add new parameter to enable/disable BGP route translation for NAT VirtualWan VpnGateway (Azure#14462)

* Adding Bastion Host Configuration Features (Azure#14442)

Co-authored-by: Abhishek Shah <shabhis@microsoft.com>

* Add PL ASG (Azure#14620)

* Add PL ASG

* Prettier

* [Private Link] Private Endpoint Ipconfigurations swagger for 2021-03-01 (Azure#14662)

* Ipconfigurations swagger

* Ran prettier check

* fixing conflicting files

* fixing lint

* Fixing linter diff

* Lint diff

* resolving comments

* fixing conflict

* Fioxing

* running prettier

* Fixing linter comment

Co-authored-by: Shane Baden <shbaden@microsoft.com>

* Add missing properties of ServiceEndpointPolicy (Azure#14948)

* Add missing 'type' and 'serviceAlias' for ServiceEndpointPolicy related API response

* Add missing 'contextualServiceEndpointPolicies'

* fix bug

* fix type

* Add missing properties to ServiceEndpointPolicy

* Revert "fix type"

This reverts commit 3a49beb66d9bbb288fa0d3baaeaf5aaf2bbc6ee9.

* Revert "fix bug"

This reverts commit a4fff4ae925b01ed0cfb07b1594fb95e2c6649c7.

* Revert "Add missing 'contextualServiceEndpointPolicies'"

This reverts commit ccf19167abc61b90bce6b5204dc3b2a64fdf4ca4.

* Revert "Add missing 'type' and 'serviceAlias' for ServiceEndpointPolicy related API response"

This reverts commit e532cc1118241a74902e4362c32c25c11a764933.

Co-authored-by: Xu Wang <wax@microsoft.com>

* add new service tag details api (Azure#14958)

* add new service tag details api

* prettier check fixes

* fixing lint issue, additional properties issue

* Add Load distribution policy and global configuration to AppGW (Azure#14790)

* add Load distribution policy and global configuration to Application Gateway resource

* prettify

* remove provisioning state

* add public ssh key to network virtual appliance (Azure#14988)

* Changes needed for BgpEndpoint (Azure#14800)

* changes needed for BgpEndpoint

* prettier check

* model validation fix

* fix description

* update again

* Multi QoS support for DSCP configuration (Azure#15120)

* Updating the DSCP jsons to reflect the  multi-qos support

* Adding support to multi-qos

* adding the type object to NrpQos

* fixing the prettier
removing my update to the settings

* fixing the missing type object error. seeing if this also fixes the additional attributes exception

* fixing the prettier exception

* almost forgot this, it was refactor from NrpQos to QosDefinition. NRPQos is already being used in Networking repo

* copying what I did with my other objects

* names didn't match with what I have in NRP's src

* forgot to update the examples with the updates in the specification. updating it

* fixing the merge exceptions

* Add SQL Setting to Firewall Policy (Azure#15110)

* Add SQL Setting to Firewall Policy

* fix lint check except for object type

* resolve linter error

* network: fix newly added targets field to an array and missing sub-resource properties in applicationGateways.json (Azure#15318)

* fix: change target to an array and add subresource properties

* fix target examples

* Support to update tags for BastionHost resource (Azure#15446)

* Initial commit

* Validation fixes

* Update bastionHost.json

Co-authored-by: Abhishek Shah <shabhis@microsoft.com>

* Azure FW - Explicit Proxy feature swagger change (Azure#15017)

* explicit proxy swagger change

* prettier check fix

* lint check

* prettier fix

* revert unnecessary file change

* Add kind to virtual hub (Azure#15562)

* Adding customnetworkinterfacename attribute to Private Endpoint (Azure#15574)

Co-authored-by: Shane Baden <shbaden@microsoft.com>

* Added 3 new properties to InboundNatRule resource (Azure#15611)

* Added the missins properties to fix the change breaking update (Azure#15732)

Co-authored-by: Nilambari <nilamd@microsoft.com>
Co-authored-by: Abhishek Shah <shah.abhi7860@gmail.com>
Co-authored-by: Abhishek Shah <shabhis@microsoft.com>
Co-authored-by: Yang Shi <yangshi93@gmail.com>
Co-authored-by: Shane Baden <naruto.shane@gmail.com>
Co-authored-by: Shane Baden <shbaden@microsoft.com>
Co-authored-by: Xu Wang <wangxu724@gmail.com>
Co-authored-by: Xu Wang <wax@microsoft.com>
Co-authored-by: guptas14 <71726901+guptas14@users.noreply.github.com>
Co-authored-by: Akshay Gupta <aksgupta@microsoft.com>
Co-authored-by: litchiyangMSFT <64560090+litchiyangMSFT@users.noreply.github.com>
Co-authored-by: Ritvika Reddy Nagula <rinagula@microsoft.com>
Co-authored-by: David Velasco <davelasc@microsoft.com>
Co-authored-by: Jiejiong Wu <b564518128@users.noreply.github.com>
Co-authored-by: tinawu6 <78238424+tinawu6@users.noreply.github.com>
Co-authored-by: irrogozh <irrogozh@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants