Add live tests to EventGrid SDK #14799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix custom event test slightly to be formatted correctly
Soreloser2
requested review from
anuchandy,
conniey,
danieljurek,
hemanttanwar,
jianghaolu,
JonathanGiles,
joshfree and
srnagar
as code owners
Soreloser2
removed request for
joshfree,
JonathanGiles,
anuchandy,
danieljurek,
jianghaolu,
hemanttanwar,
conniey and
srnagar
bsiegel
reviewed
Sep 3, 2020
sdk/eventgrid/test-resources.json
Outdated
| "type": "string", | ||
| "value": "[reference(variables('eventGridTopicName')).endpoint]" | ||
| }, | ||
| "AZURE_EVENTGRID_EVENTGRID_Key": { |
sdk/eventgrid/test-resources.json
Outdated
| } | ||
| }, | ||
| "variables": { | ||
| "apiVersion": "2020-04-01-preview", |
There was a problem hiding this comment.
I'm guessing we shouldn't use a preview API version here? Can probably use the most recently released one which seems to be 2020-06-01.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add live test configuration files, and edit a couple test instances so that custom events are formatted slightly differently.