Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed query live tests in Java 11 #14749

Merged
merged 3 commits into from
Sep 3, 2020
Merged

Fixed query live tests in Java 11 #14749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59e778b
Added reads to blob
gapra-msft Sep 2, 2020
585b69a
removed playback tag
gapra-msft Sep 2, 2020
e6ba0a0
Added reads to datalake
gapra-msft Sep 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdk/storage/azure-storage-blob/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,7 @@
--add-reads com.azure.core.test=ALL-UNNAMED
--add-reads com.azure.core.amqp=ALL-UNNAMED
--add-reads com.azure.storage.common=ALL-UNNAMED
--add-reads com.azure.storage.internal.avro=ALL-UNNAMED
</argLine>
</configuration>
</plugin>
Expand Down
14 changes: 0 additions & 14 deletions ...zure-storage-blob/src/test/java/com/azure/storage/blob/specialized/BlobBaseAPITest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ class BlobBaseAPITest extends APISpec {
}

@Unroll
@Requires({ playbackMode() }) // TODO (rickle-msft): Remove annotation
def "Query min"() {
setup:
BlobQueryDelimitedSerialization ser = new BlobQueryDelimitedSerialization()
Expand Down Expand Up @@ -133,7 +132,6 @@ class BlobBaseAPITest extends APISpec {
}

@Unroll
@Requires({ playbackMode() }) // TODO (rickle-msft): Remove annotation
def "Query csv serialization separator"() {
setup:
BlobQueryDelimitedSerialization ser = new BlobQueryDelimitedSerialization()
Expand Down Expand Up @@ -209,7 +207,6 @@ class BlobBaseAPITest extends APISpec {
}

@Unroll
@Requires({ playbackMode() }) // TODO (rickle-msft): Remove annotation
def "Query csv serialization escape and field quote"() {
setup:
BlobQueryDelimitedSerialization ser = new BlobQueryDelimitedSerialization()
Expand Down Expand Up @@ -250,7 +247,6 @@ class BlobBaseAPITest extends APISpec {

/* Note: Input delimited tested everywhere */
@Unroll
@Requires({ playbackMode() }) // TODO (rickle-msft): Remove annotation
def "Query Input json"() {
setup:
BlobQueryJsonSerialization ser = new BlobQueryJsonSerialization()
Expand Down Expand Up @@ -292,7 +288,6 @@ class BlobBaseAPITest extends APISpec {
1000 || _
}

@Requires({ playbackMode() }) // TODO (rickle-msft): Remove annotation
def "Query Input csv Output json"() {
setup:
BlobQueryDelimitedSerialization inSer = new BlobQueryDelimitedSerialization()
Expand Down Expand Up @@ -332,7 +327,6 @@ class BlobBaseAPITest extends APISpec {
}
}

@Requires({ playbackMode() }) // TODO (rickle-msft): Remove annotation
def "Query Input json Output csv"() {
setup:
BlobQueryJsonSerialization inSer = new BlobQueryJsonSerialization()
Expand Down Expand Up @@ -372,7 +366,6 @@ class BlobBaseAPITest extends APISpec {
}
}

@Requires({ playbackMode() }) // TODO (rickle-msft): Remove annotation
def "Query non fatal error"() {
setup:
BlobQueryDelimitedSerialization base = new BlobQueryDelimitedSerialization()
Expand Down Expand Up @@ -411,7 +404,6 @@ class BlobBaseAPITest extends APISpec {
receiver.numErrors > 0
}

@Requires({ playbackMode() }) // TODO (rickle-msft): Remove annotation
def "Query fatal error"() {
setup:
BlobQueryDelimitedSerialization base = new BlobQueryDelimitedSerialization()
Expand Down Expand Up @@ -440,7 +432,6 @@ class BlobBaseAPITest extends APISpec {
thrown(Exceptions.ReactiveException)
}

@Requires({ playbackMode() }) // TODO (rickle-msft): Remove annotation
def "Query progress receiver"() {
setup:
BlobQueryDelimitedSerialization base = new BlobQueryDelimitedSerialization()
Expand Down Expand Up @@ -484,7 +475,6 @@ class BlobBaseAPITest extends APISpec {
}

@Requires( { liveMode() } ) // Large amount of data.
@Ignore("Query tests hang in Java 11") // TODO (rickle-msft): Remove annotation
def "Query multiple records with progress receiver"() {
setup:
BlobQueryDelimitedSerialization ser = new BlobQueryDelimitedSerialization()
Expand Down Expand Up @@ -535,7 +525,6 @@ class BlobBaseAPITest extends APISpec {
}
}

@Requires({ playbackMode() }) // TODO (rickle-msft): Remove annotation
def "Query snapshot"() {
setup:
BlobQueryDelimitedSerialization ser = new BlobQueryDelimitedSerialization()
Expand Down Expand Up @@ -576,7 +565,6 @@ class BlobBaseAPITest extends APISpec {
}

@Unroll
@Requires({ playbackMode() }) // TODO (rickle-msft): Remove annotation
def "Query input output IA"() {
setup:
/* Mock random impl of QQ Serialization*/
Expand Down Expand Up @@ -607,7 +595,6 @@ class BlobBaseAPITest extends APISpec {
}

@Unroll
@Requires({ playbackMode() }) // TODO (rickle-msft): Remove annotation
def "Query AC"() {
setup:
def t = new HashMap<String, String>()
Expand Down Expand Up @@ -654,7 +641,6 @@ class BlobBaseAPITest extends APISpec {
}

@Unroll
@Requires({ playbackMode() }) // TODO (rickle-msft): Remove annotation
def "Query AC fail"() {
setup:
setupBlobLeaseCondition(bc, leaseID)
Expand Down
1 change: 1 addition & 0 deletions sdk/storage/azure-storage-file-datalake/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,7 @@
--add-reads com.azure.core.amqp=ALL-UNNAMED
--add-reads com.azure.storage.common=ALL-UNNAMED
--add-reads com.azure.storage.blob=ALL-UNNAMED
--add-reads com.azure.storage.internal.avro=ALL-UNNAMED
</argLine>
</configuration>
</plugin>
Expand Down
13 changes: 0 additions & 13 deletions ...re-storage-file-datalake/src/test/java/com/azure/storage/file/datalake/FileAPITest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2815,7 +2815,6 @@ class FileAPITest extends APISpec {
}

@Unroll
@Requires({ playbackMode() }) // TODO (rickle-msft): Remove annotation
def "Query min"() {
setup:
FileQueryDelimitedSerialization ser = new FileQueryDelimitedSerialization()
Expand Down Expand Up @@ -2861,7 +2860,6 @@ class FileAPITest extends APISpec {
}

@Unroll
@Requires({ playbackMode() }) // TODO (rickle-msft): Remove annotation
def "Query csv serialization separator"() {
setup:
FileQueryDelimitedSerialization ser = new FileQueryDelimitedSerialization()
Expand Down Expand Up @@ -2937,7 +2935,6 @@ class FileAPITest extends APISpec {
}

@Unroll
@Requires({ playbackMode() }) // TODO (rickle-msft): Remove annotation
def "Query csv serialization escape and field quote"() {
setup:
FileQueryDelimitedSerialization ser = new FileQueryDelimitedSerialization()
Expand Down Expand Up @@ -2978,7 +2975,6 @@ class FileAPITest extends APISpec {

/* Note: Input delimited tested everywhere else. */
@Unroll
@Requires({ playbackMode() }) // TODO (rickle-msft): Remove annotation
def "Query Input json"() {
setup:
FileQueryJsonSerialization ser = new FileQueryJsonSerialization()
Expand Down Expand Up @@ -3020,7 +3016,6 @@ class FileAPITest extends APISpec {
1000 | '\n' || _
}

@Requires({ playbackMode() }) // TODO (rickle-msft): Remove annotation
def "Query Input csv Output json"() {
setup:
FileQueryDelimitedSerialization inSer = new FileQueryDelimitedSerialization()
Expand Down Expand Up @@ -3061,7 +3056,6 @@ class FileAPITest extends APISpec {
}
}

@Requires({ playbackMode() }) // TODO (rickle-msft): Remove annotation
def "Query Input json Output csv"() {
setup:
FileQueryJsonSerialization inSer = new FileQueryJsonSerialization()
Expand Down Expand Up @@ -3102,7 +3096,6 @@ class FileAPITest extends APISpec {
}
}

@Requires({ playbackMode() }) // TODO (rickle-msft): Remove annotation
def "Query non fatal error"() {
setup:
FileQueryDelimitedSerialization base = new FileQueryDelimitedSerialization()
Expand Down Expand Up @@ -3141,7 +3134,6 @@ class FileAPITest extends APISpec {
receiver.numErrors > 0
}

@Requires({ playbackMode() }) // TODO (rickle-msft): Remove annotation
def "Query fatal error"() {
setup:
FileQueryDelimitedSerialization base = new FileQueryDelimitedSerialization()
Expand Down Expand Up @@ -3172,7 +3164,6 @@ class FileAPITest extends APISpec {
thrown(Exceptions.ReactiveException)
}

@Requires({ playbackMode() }) // TODO (rickle-msft): Remove annotation
def "Query progress receiver"() {
setup:
FileQueryDelimitedSerialization base = new FileQueryDelimitedSerialization()
Expand Down Expand Up @@ -3216,7 +3207,6 @@ class FileAPITest extends APISpec {
}

@Requires( { liveMode() } ) // Large amount of data.
@Ignore // TODO (rickle-msft): Remove annotation
def "Query multiple records with progress receiver"() {
setup:
FileQueryDelimitedSerialization ser = new FileQueryDelimitedSerialization()
Expand Down Expand Up @@ -3268,7 +3258,6 @@ class FileAPITest extends APISpec {
}

@Unroll
@Requires({ playbackMode() }) // TODO (rickle-msft): Remove annotation
def "Query input output IA"() {
setup:
/* Mock random impl of QQ Serialization*/
Expand Down Expand Up @@ -3303,7 +3292,6 @@ class FileAPITest extends APISpec {
}

@Unroll
@Requires({ playbackMode() }) // TODO (rickle-msft): Remove annotation
def "Query AC"() {
setup:
match = setupPathMatchCondition(fc, match)
Expand Down Expand Up @@ -3345,7 +3333,6 @@ class FileAPITest extends APISpec {
}

@Unroll
@Requires({ playbackMode() }) // TODO (rickle-msft): Remove annotation
def "Query AC fail"() {
setup:
setupPathLeaseCondition(fc, leaseID)
Expand Down