Convert ModelData.model to String #14702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azabbasi
requested review from
abhipsaMisra,
barustum,
bikamani,
drwill-ms,
timtay-microsoft and
vinagesh
as code owners
azabbasi
commented
Sep 1, 2020
...digitaltwins-core/src/main/java/com/azure/digitaltwins/core/models/DigitalTwinModelData.java
Outdated
Show resolved
Hide resolved
abhipsaMisra
reviewed
Sep 1, 2020
...digitaltwins-core/src/main/java/com/azure/digitaltwins/core/models/DigitalTwinModelData.java
Outdated
Show resolved
Hide resolved
abhipsaMisra
reviewed
Sep 1, 2020
...digitaltwins-core/src/main/java/com/azure/digitaltwins/core/models/DigitalTwinModelData.java
Outdated
Show resolved
Hide resolved
Just to understand, why are we making this change? |
ModelData.model is of type Object in the generated code. We want to make it a String. This is the recommended approach from the SDK team. |
timtay-microsoft
approved these changes
Sep 2, 2020
bikamani
reviewed
Sep 2, 2020
...azure-digitaltwins-core/src/main/java/com/azure/digitaltwins/core/util/ListModelOptions.java
Outdated
Show resolved
Hide resolved
abhipsaMisra
reviewed
Sep 2, 2020
...ure-digitaltwins-core/src/main/java/com/azure/digitaltwins/core/DigitalTwinsAsyncClient.java
Outdated
Show resolved
Hide resolved
abhipsaMisra
reviewed
Sep 2, 2020
...azure-digitaltwins-core/src/main/java/com/azure/digitaltwins/core/models/ModelConverter.java
Outdated
Show resolved
Hide resolved
abhipsaMisra
reviewed
Sep 2, 2020
...azure-digitaltwins-core/src/main/java/com/azure/digitaltwins/core/models/ModelConverter.java
Outdated
Show resolved
Hide resolved
abhipsaMisra
reviewed
Sep 2, 2020
...ure-digitaltwins-core/src/main/java/com/azure/digitaltwins/core/DigitalTwinsAsyncClient.java
Outdated
Show resolved
Hide resolved
abhipsaMisra
reviewed
Sep 2, 2020
...ure-digitaltwins-core/src/main/java/com/azure/digitaltwins/core/DigitalTwinsAsyncClient.java
Outdated
Show resolved
Hide resolved
abhipsaMisra
reviewed
Sep 2, 2020
...ure-digitaltwins-core/src/main/java/com/azure/digitaltwins/core/DigitalTwinsAsyncClient.java
Outdated
Show resolved
Hide resolved
abhipsaMisra
reviewed
Sep 2, 2020
...wins/azure-digitaltwins-core/src/main/java/com/azure/digitaltwins/core/models/ModelData.java
Outdated
Show resolved
Hide resolved
abhipsaMisra
approved these changes
Sep 2, 2020
|
/azp run java - digitaltwins - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I have duplicated the ModelData file and named it DigitalTwinModelData and changed the model type from Object to String along with a constructor that takes in the ModelData.
changed all API surfaces that exposed the ModelData type to now use DigitalTwinModelData.