SB track2: Remove locktoken with ServiceBusReceivedMessage in settlement API. #14696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hemanttanwar
requested review from
conniey,
YijunXieMS and
yvgopal
as code owners
ghost
added
the
conniey
reviewed
Sep 2, 2020
...g-servicebus/src/main/java/com/azure/messaging/servicebus/ServiceBusReceiverAsyncClient.java
Outdated
Show resolved
Hide resolved
...g-servicebus/src/main/java/com/azure/messaging/servicebus/ServiceBusReceiverAsyncClient.java
Outdated
Show resolved
Hide resolved
...g-servicebus/src/main/java/com/azure/messaging/servicebus/ServiceBusReceiverAsyncClient.java
Outdated
Show resolved
Hide resolved
...g-servicebus/src/main/java/com/azure/messaging/servicebus/ServiceBusReceiverAsyncClient.java
Outdated
Show resolved
Hide resolved
...ebus/src/samples/java/com/azure/messaging/servicebus/ReceiveMessageAndSettleAsyncSample.java
Outdated
Show resolved
Hide resolved
conniey
approved these changes
Sep 2, 2020
...saging-servicebus/src/main/java/com/azure/messaging/servicebus/ServiceBusReceiverClient.java
Outdated
Show resolved
Hide resolved
...saging-servicebus/src/main/java/com/azure/messaging/servicebus/ServiceBusReceiverClient.java
Outdated
Show resolved
Hide resolved
...ng-servicebus/src/test/java/com/azure/messaging/servicebus/ServiceBusReceiverClientTest.java
Outdated
Show resolved
Hide resolved
...ng-servicebus/src/test/java/com/azure/messaging/servicebus/ServiceBusReceiverClientTest.java
Outdated
Show resolved
Hide resolved
...rvicebus/src/test/java/com/azure/messaging/servicebus/ServiceBusReceiverAsyncClientTest.java
Outdated
Show resolved
Hide resolved
| @@ -279,16 +279,16 @@ void settleWithNullTransaction(DispositionStatus dispositionStatus) { | |||
| final Mono<Void> operation; | |||
There was a problem hiding this comment.
Doesn't look like there exists a test where we settle with a sessionId.
hemanttanwar
deleted the
sb-track2-remove-lock-token-message-settlement-14664
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove locktoken with ServiceBusReceivedMessage in settlement API.
fixes #14664