Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgmt traffic manager #14676

Merged

Conversation

weidongxu-microsoft
Copy link
Member

No major update. All is porting.

I will update the version_client.txt in a later PR.

Copy link
Contributor

@ChenTanyi ChenTanyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0b09a4b#diff-b42dd9e9120b8f7508b824b5a1ed4dd1
0b09a4b#diff-99e4d6bc7f30c13c8368869911b31287
I think these two record json could be removed due to they don't playback

@weidongxu-microsoft
Copy link
Member Author

@ChenTanyi
I would still put it in.

  1. Playback fails due to certificate files. If we can somehow circumvent it (though not very likely) we can directly use that json for playback.
  2. Even it does not playback, it might still provide information on server response that might help when later we try to find server behavior changed or not.

@weidongxu-microsoft weidongxu-microsoft merged commit 0d591ec into Azure:master Sep 1, 2020
@weidongxu-microsoft weidongxu-microsoft deleted the mgmt_traffic-manager branch September 1, 2020 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants