-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup Surefire Configuration in Parent POM #14663
Cleanup Surefire Configuration in Parent POM #14663
Conversation
…rent POM into specified module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things LGTM on the Key Vault side of things.
@mssfang @conniey @srnagar @kushagraThapar @samvaity, could you verify your areas. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @alzimmermsft
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thank you Alan for taking care of this 👍 |
This PR moves module specific Surefire exports, opens, and reads configurations from
azure-client-sdk-parent
into the module that requires the configuration. Currently, modules inheriting fromazure-client-sdk-parent
that don't configure Java 9+ exports, opens, or reads will inherit configuration for other modules. This results in a benign but red flag warnings during build, as shown in the image below.In addition to remove the red herring warning messages this will also move the repository towards better configuration management by having configuration scoped to what requires it.