Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Surefire Configuration in Parent POM #14663

Conversation

alzimmermsft
Copy link
Member

This PR moves module specific Surefire exports, opens, and reads configurations from azure-client-sdk-parent into the module that requires the configuration. Currently, modules inheriting from azure-client-sdk-parent that don't configure Java 9+ exports, opens, or reads will inherit configuration for other modules. This results in a benign but red flag warnings during build, as shown in the image below.

image

In addition to remove the red herring warning messages this will also move the repository towards better configuration management by having configuration scoped to what requires it.

Copy link
Member

@vcolin7 vcolin7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things LGTM on the Key Vault side of things.

@alzimmermsft
Copy link
Member Author

@mssfang @conniey @srnagar @kushagraThapar @samvaity, could you verify your areas.

Copy link
Member

@kushagraThapar kushagraThapar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @alzimmermsft

Copy link
Member

@conniey conniey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alzimmermsft alzimmermsft merged commit bf7b33c into Azure:master Sep 1, 2020
@alzimmermsft alzimmermsft deleted the AzParent_RemoveModuleSpecificConfiguration branch September 1, 2020 20:58
@azabbasi
Copy link
Contributor

azabbasi commented Sep 1, 2020

Thank you Alan for taking care of this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants