Add createTableIfNotExists methods to clients #14536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsiegel
requested review from
anuchandy,
conniey,
hemanttanwar,
jianghaolu,
JonathanGiles,
joshfree and
srnagar
as code owners
bsiegel
removed request for
joshfree,
JonathanGiles,
anuchandy,
jianghaolu,
hemanttanwar and
srnagar
bsiegel
force-pushed
the
tables-create-if-not-exists
branch
2 times, most recently
from
f1fc692
to
2a6b56d
Compare
conniey
approved these changes
Aug 31, 2020
| Class.forName(TableItem.class.getName(), true, TableItem.class.getClassLoader()); | ||
| } catch (ClassNotFoundException e) { | ||
| AssertionError err = new AssertionError("Failed to initialize TablesModelHelper dependency classes.", e); | ||
| new ClientLogger(TablesModelHelper.class).logThrowableAsError(err); |
There was a problem hiding this comment.
I believe the throw should be here
There was a problem hiding this comment.
That's how it was before but it causes a SpotBugs error. Apparently, a throw block inside a static initializer must throw an AssertionError. However the return type of logThrowableAsError is Throwable. So it complains about an unchecked cast. Since logThrowableAsError just takes a throwable, logs it, and returns the same throwable, I felt this was a better way rather than suppressing the unchecked cast warning.
bsiegel
force-pushed
the
tables-create-if-not-exists
branch
from
2a6b56d
to
72caebc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Match .NET by adding createTableIfNotExists* methods to the clients.
Fixes: #13683