Cosmos Encryption removed block() in implementation #14529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
moderakh
commented
Aug 27, 2020
•
moderakh
commented
- This PR has 0 change in azure-cosmos
- This PR scope is to remove block() calls in cosmos-encryption lib implementation.
moderakh
requested review from
David-Noble-at-work,
kirankumarkolli,
kushagraThapar,
mbhaskar,
milismsft,
simplynaveen20 and
xinlian12
as code owners
ghost
added
the
moderakh
added
the
Client
...osmos-encryption/src/main/java/com/azure/cosmos/encryption/AzureKeyVaultKeyWrapProvider.java
Outdated
Show resolved
Hide resolved
...encryption/src/main/java/com/azure/cosmos/implementation/encryption/CachedDekProperties.java
Outdated
Show resolved
Hide resolved
|
|
||
| CosmosItemRequestOptions effectiveRequestOptions = requestOptions != null ? requestOptions : new CosmosItemRequestOptions(); | ||
|
|
||
| effectiveRequestOptions.setIfMatchETag(dekProperties.eTag); |
There was a problem hiding this comment.
You are modifying the passed in request options here. Wouldn't it be better to create a deep copy instead?
There was a problem hiding this comment.
addressed. good point. thank you.
FabianMeiswinkel
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.