Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new version schema for cosmosdb starter #14465

Merged
merged 24 commits into from
Aug 31, 2020
Merged

Implement new version schema for cosmosdb starter #14465

merged 24 commits into from
Aug 31, 2020

Conversation

moarychan
Copy link
Member

@chenrujun
Copy link

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

chenrujun
chenrujun reviewed Aug 26, 2020
View reviewed changes
sdk/spring/scripts/replace_artifact.py Outdated Show resolved Hide resolved
sdk/spring/scripts/replace_artifact.py Outdated Show resolved Hide resolved
sdk/spring/scripts/replace_artifact.py Outdated Show resolved Hide resolved
sdk/spring/scripts/replace_artifact.py Outdated Show resolved Hide resolved
sdk/spring/scripts/replace_artifact.py Outdated Show resolved Hide resolved
saragluna
saragluna requested changes Aug 26, 2020
View reviewed changes
eng/versioning/external_dependencies.txt Outdated Show resolved Hide resolved
sdk/spring/README.md Outdated Show resolved Hide resolved
sdk/spring/azure-spring-boot-2-2-starter-cosmosdb/CHANGELOG.md Outdated Show resolved Hide resolved
sdk/spring/azure-spring-boot-2-2-starter-cosmosdb/README.md Outdated Show resolved Hide resolved
sdk/spring/azure-spring-boot-2-2-starter-cosmosdb/README.md Outdated Show resolved Hide resolved
sdk/spring/azure-spring-boot-samples/azure-cloud-foundry-service-sample/pom.xml Show resolved Hide resolved
sdk/spring/azure-spring-boot-samples/azure-spring-boot-sample-cosmosdb/pom.xml Show resolved Hide resolved
...e-spring-boot-samples/azure-spring-cloud-appconfiguration-conversion-sample-complete/pom.xml Show resolved Hide resolved
...re-spring-boot-samples/azure-spring-cloud-appconfiguration-conversion-sample-initial/pom.xml Show resolved Hide resolved
sdk/spring/azure-spring-boot-starter/README.md Show resolved Hide resolved
@moarychan
Copy link
Member Author

hi @chenrujun @saragluna please help review again.

@chenrujun
Copy link

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chenrujun
Copy link

/azp run java - core - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chenrujun
Copy link

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

saragluna
saragluna requested changes Aug 28, 2020
View reviewed changes
Copy link
Member

@saragluna saragluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's replace all the relative links to absolute links in our readme files. And we could refactor the links to make it cleaner and easier to edit.

sdk/spring/azure-spring-boot-2-2-starter-cosmosdb/README.md Outdated Show resolved Hide resolved
sdk/spring/azure-spring-boot-2-2-starter-cosmosdb/README.md Outdated Show resolved Hide resolved
sdk/spring/azure-spring-boot-2-2-starter-cosmosdb/README.md Outdated Show resolved Hide resolved
sdk/spring/azure-spring-boot-2-2-starter-cosmosdb/README.md Outdated Show resolved Hide resolved
sdk/spring/azure-spring-boot-2-2-starter-cosmosdb/README.md Outdated Show resolved Hide resolved
sdk/spring/azure-spring-boot-2-2-starter-cosmosdb/README.md Show resolved Hide resolved
@saragluna
Copy link
Member

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@saragluna
Copy link
Member

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@saragluna
Copy link
Member

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chenrujun
Copy link

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

saragluna
saragluna approved these changes Aug 31, 2020
View reviewed changes
Copy link
Member

@saragluna saragluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

chenrujun
chenrujun approved these changes Aug 31, 2020
View reviewed changes
Copy link

@chenrujun chenrujun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM about the python script part.

@chenrujun chenrujun merged commit a5acccf into Azure:master Aug 31, 2020
@moarychan moarychan deleted the feature/spring-multi-verson branch September 3, 2020 03:41
saragluna added a commit that referenced this pull request Sep 3, 2020
@saragluna
Revert "Implement new version schema for cosmosdb starter (#14465)"
9ce3385 
This reverts commit a5acccf.
@moarychan moarychan restored the feature/spring-multi-verson branch September 3, 2020 08:52
zhoufenqin added a commit that referenced this pull request Sep 7, 2020
@zhoufenqin
Revert "Implement new version schema for cosmosdb starter (#14465)"
b387c56 
This reverts commit a5acccf.
@zhoufenqin zhoufenqin mentioned this pull request Sep 7, 2020
Merged
zhoufenqin added a commit that referenced this pull request Sep 7, 2020
@zhoufenqin
Revert "Implement new version schema for cosmosdb starter (#14465)" (#…
7c24435 
…14867)

This reverts commit a5acccf.
@moarychan moarychan deleted the feature/spring-multi-verson branch September 16, 2020 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saragluna saragluna saragluna approved these changes

@chenrujun chenrujun chenrujun approved these changes

@alzimmermsft alzimmermsft Awaiting requested review from alzimmermsft

@danieljurek danieljurek Awaiting requested review from danieljurek

@jialindai jialindai Awaiting requested review from jialindai

@JimSuplizio JimSuplizio Awaiting requested review from JimSuplizio

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

@samvaity samvaity Awaiting requested review from samvaity

@srnagar srnagar Awaiting requested review from srnagar

@weshaggard weshaggard Awaiting requested review from weshaggard

@yiliuTo yiliuTo Awaiting requested review from yiliuTo

@zhoufenqin zhoufenqin Awaiting requested review from zhoufenqin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moarychan @chenrujun @saragluna