Identity adfs support aug 2020 #14444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 25, 2020 00:54
ghost
added
the
g2vinay
requested review from
alzimmermsft,
chenrujun,
conniey,
danieljurek,
jialindai,
JimSuplizio,
mitchdenny,
mssfang,
samvaity,
saragluna,
srnagar,
weshaggard,
YijunXieMS,
yiliuTo and
zhoufenqin
as code owners
added 2 commits
August 28, 2020 14:55
jianghaolu
approved these changes
Aug 28, 2020
srnagar
approved these changes
Aug 28, 2020
sdk/identity/azure-identity/src/main/java/com/azure/identity/implementation/IdentityClient.java
Outdated
Show resolved
Hide resolved
| .scopes(new HashSet<>(request.getScopes())) | ||
| .build(); | ||
| Mono<IAuthenticationResult> acquireToken = publicClientApplicationAccessor.getValue() | ||
| .flatMap(pc -> Mono.fromFuture(() -> pc.acquireToken(parameters))); |
There was a problem hiding this comment.
Do you need to use fromFuture? Can it just be:
.flatMap(pc -> pc.acquireToken(parameters));There was a problem hiding this comment.
its needed, because we get back a CompletableFuture.
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-java
that referenced
this pull request
Jun 8, 2021
Fix temporaryDist default value issue (Azure#14444)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14183 #14188 #14653 , #13460
This PR adds ADFS Authorities support to Identity SDK.
Also upgrades the MSAL version in the repo to 1.6.2 everywhere.