Added code for smb multi channel #14180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gapra-msft
requested review from
alzimmermsft,
amishra-dev,
jaschrep-msft,
kasobol-msft,
rickle-msft and
sima-zhu
as code owners
ghost
added
the
gapra-msft
commented
Aug 17, 2020
| @@ -1653,7 +1653,7 @@ private void channelCleanUp(AsynchronousFileChannel channel) { | |||
| String rangeString = finalOptions.getRange() == null ? null : finalOptions.getRange().toString(); | |||
| Function<String, Mono<PagedResponse<ShareFileRange>>> retriever = | |||
| marker -> StorageImplUtils.applyOptionalTimeout(this.azureFileStorageClient.files() | |||
| .getRangeListWithRestResponseAsync(shareName, filePath, snapshot, finalOptions.getPreviousSnapshot(), | |||
| .getRangeListWithRestResponseAsync(shareName, filePath, snapshot, | |||
There was a problem hiding this comment.
need to regenerate once swagger is merged
rickle-msft
reviewed
Aug 17, 2020
| @@ -15,7 +15,7 @@ autorest --use=@microsoft.azure/autorest.java@3.0.4 --use=jianghaolu/autorest.mo | |||
|
|
|||
| ### Code generation settings | |||
| ``` yaml | |||
| input-file: https://raw.githubusercontent.com/Azure/azure-rest-api-specs/storage-dataplane-preview/specification/storage/data-plane/Microsoft.FileStorage/preview/2020-02-10/file.json | |||
| input-file: https://raw.githubusercontent.com/Azure/azure-rest-api-specs/467d3ca51bb715fea928251f1003515aee67919a/specification/storage/data-plane/Microsoft.FileStorage/preview/2019-12-12/file.json | |||
There was a problem hiding this comment.
Do we want to actually merge this?
There was a problem hiding this comment.
No, Sean needs to first merge the swagger PR and then I can update it and regenerate before I merge this
rickle-msft
approved these changes
Aug 17, 2020
seanmcc-msft
approved these changes
Aug 18, 2020
gapra-msft
added a commit
that referenced
this pull request
Oct 1, 2020
* Updated all service versions to STG74 (#14079) * Added code for get file range diff (#14140) * Added code for smb multi channel (#14180) * Added code to allow scheduling file expiry (#14319) * Added support for arrow output serialization (#14431) * Added support to read last access time (#14342) * Added support to lease shares (#14287) * Updated file ranges to getFileRangesDiff (#14839) * Added support for directory and delegation SAS (#14531) * Recursive acl (#14669) * Added missing error code (#14986) * Added tests to ensure support for 4TB file (#15179) Co-authored-by: Gauri Prasad <gapra@microsoft.com> * Storage/file share error code (#15007) * Fixed simple renames and doc issues from 74 (#15297) Co-authored-by: Gauri Prasad <gapra@microsoft.com> * Added back support for container undelete. (#15344) * Regenerated code to address APIView comments (#15341) * Minor changelog formatting issues * Formatting - new lines and unused imports * Fixed public API for file get range diff (#15562) * Modified recursive acl tests to be able to play in live mode (#15815) * Added support for live tests in the STG 74 branch (#15724) * Added code to return batch failures in results for recursive ACL (#15842) * Wrapped continuation token with Exception when recursive acl call is … (#15839) Co-authored-by: Gauri Prasad <gapra@microsoft.com> Co-authored-by: Rick Ley <frley@microsoft.com>
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-java
that referenced
this pull request
Jun 3, 2021
Update available SKUs for CognitiveServices->Text Analytics Azure#14180 (Azure#14561) * Update CheckSkuAvailability.json * Update GetSkus.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.