Tables SDK Adding Odata Typing #13605
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eboyd23
requested review from
anuchandy,
hemanttanwar,
JonathanGiles,
joshfree and
srnagar
as code owners
conniey
reviewed
Jul 30, 2020
sdk/tables/azure-data-tables/src/main/java/com/azure/data/tables/EdmType.java
Outdated
Show resolved
Hide resolved
sdk/tables/azure-data-tables/src/main/java/com/azure/data/tables/EdmType.java
Outdated
Show resolved
Hide resolved
sdk/tables/azure-data-tables/src/main/java/com/azure/data/tables/EdmType.java
Outdated
Show resolved
Hide resolved
sdk/tables/azure-data-tables/src/main/java/com/azure/data/tables/EdmType.java
Outdated
Show resolved
Hide resolved
conniey
reviewed
Jul 30, 2020
sdk/tables/azure-data-tables/src/main/java/com/azure/data/tables/ODataConstants.java
Outdated
Show resolved
Hide resolved
conniey
reviewed
Jul 30, 2020
sdk/tables/azure-data-tables/src/main/java/com/azure/data/tables/ODataConstants.java
Outdated
Show resolved
Hide resolved
conniey
reviewed
Jul 30, 2020
sdk/tables/azure-data-tables/src/main/java/com/azure/data/tables/TableAsyncClient.java
Outdated
Show resolved
Hide resolved
conniey
reviewed
Jul 30, 2020
sdk/tables/azure-data-tables/src/main/java/com/azure/data/tables/TableClient.java
Show resolved
Hide resolved
conniey
reviewed
Jul 31, 2020
| * @return A <code>String</code> containing the name of the EDM data type. | ||
| */ | ||
| @Override | ||
| public String toString() { |
There was a problem hiding this comment.
Usually we don't override toString and use the ability to pass in a value in the ctor. An example. This would have a getValue() method that would return the string constant.
conniey
reviewed
Jul 31, 2020
| @@ -76,7 +76,7 @@ public TableAsyncClient getTableAsyncClient(String tableName) { | |||
| * @param name the name of the table | |||
| * @return associated azure table object | |||
| */ | |||
| public Table getTable(String name) { | |||
| public AzureTable getTable(String name) { | |||
| return null; //TODO: idk how to do this one | |||
conniey
reviewed
Jul 31, 2020
|
|
||
| return new PagedFlux<>( | ||
| () -> listTablesFirstPage(context, queryParams), | ||
| token -> listTablesNextPage(token, context, queryParams)); | ||
| } //802 | ||
|
|
||
| private Mono<PagedResponse<Table>> listTablesFirstPage(Context context, QueryParams queryParams) { | ||
| private Mono<PagedResponse<AzureTable>> listTablesFirstPage(Context context, TableQueryParams queryParams) { | ||
| try { | ||
| return listTables(null, context, queryParams); | ||
| } catch (RuntimeException e) { | ||
| return monoError(logger, e); | ||
| } | ||
| } //1459 |
There was a problem hiding this comment.
What are these numbers for? //1459 Can we clean these up?
|
Closing in favor of #14597 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds to types to the objects in the property map of an entity to allow for serialization and deserialization by the SDK.