Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the configuration of storage account and key in unit test #35

Closed
gcheng opened this issue Apr 4, 2012 · 3 comments
Closed

Enable the configuration of storage account and key in unit test #35

gcheng opened this issue Apr 4, 2012 · 3 comments

Comments

@gcheng
Copy link

gcheng commented Apr 4, 2012

Currently no, to run the tests for table you need to change the account string in TableTestBase.java. If you guys would like to provide more information on how ongoing testing is going to be accomplished ( i.e. config, reporting etc) then we can modify our tests to fit that. For this release however we will continue to test as is so please let us know when a build is available,

thx

joe

From: Jason Cooke
Sent: Wednesday, February 22, 2012 10:12 PM
To: Joe Giardino; Jeff Irwin; Deepak Verma; Joost de Nijs; Jai Haridas; Metodi Mladenov; Jeff Wilcox
Cc: Mohit Srivastava; Louis DeJardin
Subject: RE: Shipping Java Tables

Can the unit tests be run without changing the test strings in the unit tests?

For our unit tests, they look at the env variables to modify the default strings. That makes it easy to run the unit tests on our CI server (an on testers’ machines).

Thanks,
Jason

@joostdenijs
Copy link
Contributor

Jason - can you look into this an propose a solution (like our environment variables) that the storage team could then use to fix this issue.

@ghost ghost assigned jcookems Apr 5, 2012
@jcookems
Copy link
Contributor

One approach would be to alter the setup method in microsoft-azure-api/src/test/java/com/microsoft/windowsazure/services/table/client/TableTestBase.java to replace

        httpAcc = CloudStorageAccount.parse(CLOUD_ACCOUNT_HTTP);

with

        String tmp = CLOUD_ACCOUNT_HTTP;
        String accountName = System.getenv("table.accountName");
        if (accountName != null) {
            tmp = tmp.replace("[ACCOUNT NAME]", accountName);
        }
        String accountKey = System.getenv("table.accountKey");
        if (accountKey != null) {
            tmp = tmp.replace("[ACCOUNT KEY]", accountKey);
        }

        httpAcc = CloudStorageAccount.parse(tmp);

Then, if the environment variables are not set, it is a no-op.Those environment variables would make it consistant with what the Table service layer uses.

@ghost ghost assigned jeffreyjirwin Jul 16, 2012
joostdenijs pushed a commit to joostdenijs/azure-sdk-for-java that referenced this issue Jan 18, 2013
…-541

Removing setExpirationTime from locator update
@jcookems
Copy link
Contributor

This is fixed.

gcheng pushed a commit that referenced this issue Apr 24, 2013
fix the getBytes for StatusLine class.
jianghaolu pushed a commit to jianghaolu/azure-sdk-for-java that referenced this issue Apr 5, 2017
…-541

Removing setExpirationTime from locator update
lenala pushed a commit to lenala/azure-sdk-for-java that referenced this issue Nov 16, 2018
…_fix

Add python script to automatically make all necessary changes to generated code, regen code from latest swagger
g2vinay pushed a commit to g2vinay/azure-sdk-for-java that referenced this issue Mar 4, 2019
g2vinay pushed a commit to g2vinay/azure-sdk-for-java that referenced this issue May 30, 2019
Update Document Resource getTimestamp for last modified date/time
openapi-sdkautomation bot pushed a commit that referenced this issue Dec 5, 2019
Merge pull request #35 from leonardbf/ANF-440-2019-10-01

ANF-440 correct 2019-10-01 API
openapi-sdkautomation bot pushed a commit that referenced this issue Dec 5, 2019
Merge pull request #35 from leonardbf/ANF-440-2019-10-01

ANF-440 correct 2019-10-01 API
openapi-sdkautomation bot pushed a commit that referenced this issue Dec 5, 2019
Merge pull request #35 from leonardbf/ANF-440-2019-10-01

ANF-440 correct 2019-10-01 API
openapi-sdkautomation bot pushed a commit that referenced this issue Dec 5, 2019
Merge pull request #35 from leonardbf/ANF-440-2019-10-01

ANF-440 correct 2019-10-01 API
openapi-sdkautomation bot pushed a commit that referenced this issue Dec 5, 2019
Merge pull request #35 from leonardbf/ANF-440-2019-10-01

ANF-440 correct 2019-10-01 API
openapi-sdkautomation bot pushed a commit that referenced this issue Dec 5, 2019
Merge pull request #35 from leonardbf/ANF-440-2019-10-01

ANF-440 correct 2019-10-01 API
samvaity added a commit to samvaity/azure-sdk-for-java that referenced this issue Dec 19, 2019
navalev pushed a commit to navalev/azure-sdk-for-java that referenced this issue Dec 24, 2019
Adding search filter tests
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants