Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javadocs incorrect for Table string values #185

Closed
jcookems opened this issue Nov 8, 2012 · 1 comment
Closed

Javadocs incorrect for Table string values #185

jcookems opened this issue Nov 8, 2012 · 1 comment
Milestone

Comments

@jcookems
Copy link
Contributor

jcookems commented Nov 8, 2012

The javadocs in

  • .../services/table/models/EdmType.java:64 KB in size.
  • .../services/table/models/Entity.java
  • .../services/table/models/Property.java

all have the following text, referring to string values:

A UTF-16-encoded value. String values may be up to 64 KB in size.

It should say:

A Unicode string value. String values may be up to 64 KB in size.

At best, the original message is misleading, at worst just wrong. The doc at http://msdn.microsoft.com/en-us/library/windowsazure/dd179338.aspx says the same thing, and it is likely because strings are stored on the server as UFT-16 (because it is .NET). But one shouldn't try to force UTF-16; the encoding on the wire should match the headers in the HTTP/XML packet. For example, here is part of a response, showing that in this case the server elected to use the UTF-8 encoding for Unicode code points:

Content-Type: application/atom+xml;charset=utf-8
<?xml version="1.0" encoding="utf-8" standalone="yes"?>

The intent of the comment is that Table storage accepts Unicode strings. The mechanics of what encoding is used for the bits that get sent across the wire (UTF-16, UTF-8, GB18030, etc.) should be handled by handshakes between the SDK and the Azure server; the user does not need to worry about encoding in Java (which treats strings as Unicode).

@gcheng
Copy link

gcheng commented Jun 24, 2014

no longer in scope

@gcheng gcheng closed this as completed Jun 24, 2014
g2vinay pushed a commit to g2vinay/azure-sdk-for-java that referenced this issue Mar 4, 2019
Add error receiving response event
g2vinay pushed a commit to g2vinay/azure-sdk-for-java that referenced this issue Jul 9, 2019
* changes to ConsistencyLevel

* removed changes to DocumentCrudTests
edited manner in which ConsistencyLevel.toString is implemented

* Refactored Direct TCP into v3 namespace, Updated CosmosClientException and TransportException which are now stackless (for performance), and fixed a dependency issue (see pom.xml changes).

* Revised a long-standing TODO which ensures that the DirectHttpsClientUnderTest is created with Protocol.HTTPS. Added names to all Cosmos Client tests that derive from TestSuiteBase and--in the case of the examples--NamedCosmosClientTest. Test names include the class name, method name, connection mode, and consistency level. Also: Optimized imports.

* Added two base test classes from which each variant of TestSuiteBase inherits: CosmosClientTest and DocumentClientTest
openapi-bot-test bot referenced this issue in AzureSDKAutomation/azure-sdk-for-java Jul 17, 2019
* Porting V3 OM changes from VSTS to Github (#98)

* inital commit for V3 port from vsts to github

* Hash v2 for SDK v3

bumped version to 3.0.0-beta-3 for release

* Modified Pom file to copy jar files to required location

* updated sdk-version property

* removed additions to pom

* Removing unused code
Changing version to 3.0.0-SNAPSHOT

* Add christopheranderson and kushagraThapar to CODEOWNERS (v3) (#101)

* Add christopheranderson to CODEOWNERS (v3)

Bus factor 0 is bad mmkay

* Add Kushagra as well

* fixed syntax

* Add regenerate-manager and fluent to swagger_to_sdk_config.json autorest options

* bumped timeouts

* bumped timeouts

* bumped timeout

* bump timeout

* added read my write test

* added support for time bound testing

* updated timeouts

* cleanup

* remove system.exit to avoid killing jvm on test

* minor update

* fixed test

* fixed test

* added retry

* increased retry

* disabled retry throttle test

* retry added

* added support for reading test config from env

* fixed sync

* test fix

* udate test

* cleanup

* improve test timeout

* V3 cosmositem refactoring (#120)

* Cosmos Item refactoring #106

fixes #106

* retry analyzer name typo fixed

* code review

* use OffsetDateTime - fixes #154 (#170)

* use OffsetDateTime - fixes #154

* Date should not have ms in it for comparison

* Refactoring cosmos client, options  and adding user (#139)

- closes #151 

* Refactoring CosmosClient adding a Builder
Removed cosmos configuration
Adding getters for scripts
Adding CosmosUser
Changing Options to composition

* Minor refactoring
Adding listUsers and queryUsers

* Implementing PR comments

* Fixing javadoc warnings

* Fixing typo in doc

* Merging V3

* Fixing doc issues

* Implementation for Change Feed Processor (#128)

* Add CFP v3 user facing interfaces and classes.

* Refactoring for package and method names.

* Refactoring.

* Add implementation for change feed processor interfaces.
Add simple sample for change feed processor.

* Removes interface API's which might go away after fully merging to V3.

* Update change feed processor sample to be more "async" than "sync".

* Resolve merge conflicts and remove support for non-partitioned lease collections.

* Address some of the PR feedback for the Change Feed Sample and the user exposed interfaces.

Left to address are some of the feedback comments regarding blocking calls in the implementation.

* Sample cleanup based on the PR feedback.

* Throw rather then return null if we cannot create an instance of the observer which will process the feeds.

* fixes from OM changes

* Added support for accessing non partitioned collections using V3 SDK (#107)

* NP->P changes

* Adding permissions and throughput (#177)

* artifact renaming, versioning update, and jar collection command (#174)

* 3.0.0-a1

* Add .vscode to .gitignore

* SNAPSHOT & jar collection command

* JsonSerializable changes (#172)

* Remove HashMap from public methods - fixes #155

* ObjectMapper methods to package private - fixes #153

* Remove CosmosItemSettings constructor with ObjectMapper

* Refactoring & package renaming (#178)

* Refactoring POCOs based on rules

* package rename

* Package visibility issues

* fix example pom

* fix enum value handling

* Multiple fixes for making v3 branch healthy (#185)

* changes to ConsistencyLevel

* removed changes to DocumentCrudTests
edited manner in which ConsistencyLevel.toString is implemented

* Refactored Direct TCP into v3 namespace, Updated CosmosClientException and TransportException which are now stackless (for performance), and fixed a dependency issue (see pom.xml changes).

* Revised a long-standing TODO which ensures that the DirectHttpsClientUnderTest is created with Protocol.HTTPS. Added names to all Cosmos Client tests that derive from TestSuiteBase and--in the case of the examples--NamedCosmosClientTest. Test names include the class name, method name, connection mode, and consistency level. Also: Optimized imports.

* Added two base test classes from which each variant of TestSuiteBase inherits: CosmosClientTest and DocumentClientTest

* Fixing parse protocols and desired consistency to work for new upper case enum types. Optimized imports

* Removed unncessary lines

* Made the consistency upper case change to other test suite base

* Upper casing desired consistency in Read my writes test

* Fixed Consistency and protocol parsing bugs related to test configurations

* Added few more test cases for Parsing env variables

* Mbhaskar/conflict api (#186)

* Conflict API

* Changing test to reflect new changes in testsuitebase

* V3 store consistency layer (#194)

* inital commit for V3 port from vsts to github

* Hash v2 for SDK v3

bumped version to 3.0.0-beta-3 for release

* Modified Pom file to copy jar files to required location

* updated sdk-version property

* removed additions to pom

* Removing unused code
Changing version to 3.0.0-SNAPSHOT

* Initial check in with reactor netty library

* Initial commit for Non partitioned collection support for V3 async Java
SDK

* updated git ignore

* updated git ignore

* removed conflict markers in comments

* removed unnecessary files

* Removed public constructor that took PartitionKeyInternal

* fixed javadoc errors

* Work In Progress

* Work in progress

* Work In Progress, Added Reactor Netty Client and other interfaces for Reactor HTTP Client

* Reverted test configuration:

* Fixed Gateway Store Model Test

* Removed unused classes, added headers to new classes. Added configuration to Reactor Netty Http Client

* Implemented Reactor HTTP Client for HttpTransportClient

* Fixed HttpTransportClient store response subscribe

* Removed unused code, removed some rxnetty usages

* Fixed Proxy Tests with correct log level for reactor netty client

* Fixed Gateaway Address Cache Tests

* Fixed test cases, optimized imports, and other refactoring changes

* Removed propogating error, instead just throw the error

* Storing Connection provider to close resources later

* Fixed empty body issue with Flux not allowing null values

* Disposing just connection provider on http client shutdown

* increased used memory limit for document leak resource test. Fix it later

* Incorporated port in Http Request

* Replacing read and write time out handlers with idle state handlers

* Removing experimental feature of pooled connection timeout

* initial commit for fixing tetss (will break)

* Removed timeout feature

* Calling http client shutdown in HttpTransportClient

* Fixed Document resource leak test by closing the channel when done

* Experimenting changes

* Commenting out old ssl provider

* Setting ssl timeout explicitly

* Trying out default ssl

* Trying out default ssl

* Trying out ssl config

* Trying out default ssl

* Using vanila ssl

* fixed testsuitebase

* Improving the configuration for http client

* Merging v3_reactor_netty_client_experiment changes

* Reverting Test Configurations change

* Implemented code review suggestions as well as some optimizations and refactoring

* Handling delete operation

* Fixing Delete operation

* Refactoring CosmosClient adding a Builder
Removed cosmos configuration
Adding getters for scripts
Adding CosmosUser
Changing Options to composition

* WIP: Work in progress

* - Added CosmosUser, get APIs for scripts
- Removed CosmosConfiguration and moved builder to CosmosClient

* Added retry utility for Backoff retry utility

* - Ported Cosmos item changes

* fixed more tests

* Minor refactoring
Adding listUsers and queryUsers

* Compilation work. Work in progress

* Refactoring in Reactor Netty Client:

* fixed database tests

* Fixed RxGatewayStoreModelTests

* Fixed Store reader, consistency reader, writer, address selector test cases

* fixed more tests

* Replaced Func1 with java Function

* - Fixed more tests
- rx.internal tests run using asyncDocumentClient

* Updated store and consistency reader writers, Collection caches, partition caches, helpers, address resolvers, global endpoint managers, retry policies with reactor-core changes

* Updated query contexts, document service requests, cosmos client changes

* Fixed bechmarks, and some tests in commons

* fixed more tests

* fixed more tests. commented out some tests for compilation

* Implementing PR comments

* Fixed Direct Implementation test cases

* Refactoring internal tests to Reactor

* Work in progress, fixing location cache test

* Fixing Async benchmark after Mo's changes

* Fixed Examples source code and test cases

* Fixing javadoc warnings

* Refactoring internal query tests to Reactor

* Refactoring gateway tests to Reactor

* Removed unused code, refactored to use internal test suite base

* Fixed concurrency issue with internal test suite base, imported internal test suite base in rx.internal tests

* Minor changes, removed invalid usage of TransportClient

* Fixed gateway tests, removed verbose test subscriber, using basic test subscriber for now

* Handling IO Exception for create  attachment and media. Fixing Consistency and Retry Create Document tests

* Fixing typo in doc

* Work in progress

* reverted changes to examples utils

* Added paginator prototype code

* Merging V3

* Code-complete draft port to reactor. The Direct TCP-related code compiles and is not yet testable because other significant portions of the code do not currently compile.

* Code-complete draft port to reactor. The Direct TCP-related code compiles and is not yet testable because other significant portions of the code do not currently compile.

* Renamed Reactor Transport Client to Transport Client, removed rx.Observable and rx.Single usages completely

* fixed more tests
made shared resources private

* Addressed some error handling ommissions in RntbdRequestManager and verified locally on the V2 branch that the long test suite passes.

* Fixed more tests to use getSharedDatabase and similar methods

* Addressed some error handling ommissions in RntbdRequestManager and verified locally on the V2 branch that the long test suite passes.

* Fixed buffer size issue

* Added Cosmos Request options

* Renamed COSMOS.PROTOCOL as cosmos.directModeProtocol and move ConfigsTests to the package that Configs is defined

* Fixing tests and refactored the way to get values

* Icreased Ssl handshake timeout for reactor netty client

* Ensured that our dependency on org.hamcreate:hamcrest-all:1.3 is respected by mockito which brings in hacrest-all:1.1. Also: sorted dependency version properties and dependency lists.

* Addressed RntbdTransportClient test faiures

* Minor test fixes

* We no longer skip the DocumentClientResourceLeakTest when Direct TCP is in use

* We no longer permit VeryLargeDocumentQueryTest to fail when Direct TCP is in use. Also improved logger.info messages in DocumentClientResourceLeakTest

* We no longer permit DCDocumentCrudTest.crossPartitionQuery to fail when Direct TCP is in use.

* We no longer permit BackPressureCrossPartition.query to fail when Direct TCP is in use.

* skipped tcp tests

* removed unused imports

* Resolves a long-standing TODO: Ensure that the Configs instance created by DirectHttpsClientUnderTest specifies Protocol.Https (now that Direct TCP is the default connection mode)

* changes to ConsistencyLevel

* TestSuiteBase.beforeMethod correctly logs the connection mode: Direct Tcp, Direct Https, or Gateway Https

* Merged enable TCP default protocol changes

* Fixed Address Resolver Tests

* Disabling connection pool exhausted tests

* Fixing Config Tests

* removed changes to DocumentCrudTests
edited manner in which ConsistencyLevel.toString is implemented

* removed unused import

* reverted changes to documentcrud tests

* fixed failing test

* made more ConsistencyLevel.name -> toString changes

* changed line endings

* Removed rx Composite Exception and used reactor Exceptions utility class to handle multiple exceptions

* Made more changes to enums
removed cosmos tests

* more enum fixes

* more enum changes

* Test tweaks

* Made more enum changes

* fixed line endings in includepathtest

* Fixed pagination and order by utils bugs

* Swapped rx Http Client with Reactor Http Client in Cosmos Partition Key Tests

* Removed rx java dependency

* Fixing tests

* Removed throws Exception and unused imports

* Optimized imports in Microsoft style

* Added parallel run code for bulk insert blocking method in Test Suite Base

* Minor test fixes

* Trying default Http Client

* re-using https client

* Disabling document resource leak test

* Fixing up schedulers

* fixed CosmosPartitionKeyTests and ConsistencyTests null pointer issues

* Added logging to netty client and fixed logger category

* Fixing spy wire test

* fixed failing tests

* Removing unused imports

* Minor test changes

* Removed usages of bodyAsString method from http response as its not working correctly, implemented toString to convert byteBuf flux to Mono string

* Increased timeout

* Replaced flux with mono across consistency layer to avoid confusion

* Reverting test configurations changes

* Fixed Parallel Document Query Context

* Fixed Protocol tests

* Replaced exceptions by Mono / Flux Error

* Incresaed wait to capture requests

* Added block instead of subscribe to capture response

* Fixed ReadMyWrites test with emitting just one value

* Modified the order of client builders and reverted flux / mono change for consistency stack

* Fixed Read my writes workflow

* Removed unnecessary stack trace

* Fixed Benchmarks to use BaseSubscriber

* Adding conflict api (#192)

Fixing Permission tests
Making id method of Resource package private and adding id on
individual resource classes to enable fluent composition

* Removed unused ConfigsTests.java class

* Fixed Read latency and write latency benchmarks

* Fixed metrics version in parent pom.xml

* Revised DocumentCrudTest and TestSuiteBase to address test breaks

* Using Step Verifier, removed RetryAnalyzer

* POM + test tweaks.

* Eliminating some tests to test fast integration tests

* Reverting the experiment

* Fixed test break (see changes to CosmosPartitionKeyTests), tidied some test code (see changes to StoredProcedureCrudTest) and deleted two extraneous files

* Removed unnecessary call

* Code review comments

* Hiding Json Serializable set and remove methods and object mapper and object node return types (#204)

* Refactor Change Feed surface area (#199)

* Add test case for change feed processor. The test creates a bunch of documents and compare them with what change feed processor receives.
Fix couple bugs in the implementation of change feed processor including an issue related to continuation tokens which were previously not correctly retrieved.

* Cleanup public interfaces (remove "with") and other tweaks.

* Move ChangeFeedProcessor implementation inside "internal".
Only two public interfaces/classes are exposed to the users, ChangeFeedProcessor and ChangeFeedProcessorOptions.

* Update CFP Builder interface to accept a Consumer for handling the feed changes.

* Remove CheckpointFrequency setting from the user facing public APIs.

* Remove blocking calls from ChangeFeedProcessorBuilderImpl implementation

* Fix documentation capture.

* Cleanup/fixes for Mono.error() calls.
Renamings/refactoring.

* Test cleanup; add extra coverage for ChangeFeedProcessorOptions argument.

* Test fix

* Change feed test refactoring.
Disable resourceLeak() test that it causes runs to timeout

* increase the "AfterMethod" timeout.

* Refactor test assets.
Add test case for ChangeFeedProcessorOptions "startTime" option.

* Increase timeouts; move map initialization inside the test.

* Rename syncHandleChanges to handleChanges.
Return an actual instance of the ChangeFeedProcessor rather than a Reactor Mono. Some initialization code will need to be moved to from builder to start of the processing in a later check-in.

* cleanup

* Updates

* Fix for release of a lease.

* switch to publishing on a different scheduler to avoid blocking on netty threads.

* Users/kuthapar/v3 settings properties (#207)

* Hiding Json Serializable set and remove methods and object mapper and object node return types

* Renamed Settings suffixes to Properties suffixes

* Refactored settings method to properties

* Removed sdk - CosmosUserSettings, renamed commons - CosmosUserSettings to CosmosUserProperties

* Cosmos Resource refactoring (#205)

* Remove CosmosResource

* Naming and JavaDocs updates

* Move Scripts to CosmosScripts object

* Add header

* Fix JavaDoc build error

* Fix up CosmosScripts + tests

* Moved old types to internal package and other changes (#209)

* Collection to list changes, moved old types to internal, pom file change to exclude BridgeInternal and CosmosBridgeInternal

* Fix build issues with scripts

* fix partition key bug

* JsonSerializable handle private constructors

* Add test coverage IndexingPolicy deserialization

* Remove Collection in favor of List

* Code Review changes, excluded  all BridgeInternal from API docs

* Fixed constructor scope

* Feed Options refactor (#213)

* FeedOptions refactoring

* Remove FeedOptionsBase

* Fix issue with the restarting of the processor; the executor cannot be shutdown since this will stop any future execution using it. (#212)

* Exceptions changes (#211)

* Moved exceptions to commons module, made most of the constructors package private

* Moved PartitionKey back to public scope

* Merge packages into SDK (#214)

* merge modules

* fix tests

* move direct mode internal

* Optimized imports, fixed dependencies for benchmarks and sdk

* Refactoring and removing "partition" settings from the CFP options. (#215)

* Wrapped Client Side Request Statistics (#216)

* Wrapped Client Side Request Statistics in Cosmos Response Diagnostic Statistics. Exposed only toString and request latency

* Code review comments for Cosmos Response Diagnostics

* Wrapped Query Metrics Map in Feed Response Diagnostics. Exposed toString through Feed response diagnostics

* Reducing scope of setter to package private

* Final cleanup for V3 (#217)

* Hide AsyncDocumentClient

* Remove Attachment

* Cleanup ChangeFeedOptions

* Hide Conflict

* Cleanup ConsistencyPolicy

* Cleanup CosmosClient

* Cleanup CosmosClientBuilder

* Cleanup CosmosConflict

* Cleanup CosmosConflictProperties

* CosmosConflictResponse cleanup

* Cleanup CosmosContainer

* Cleanup CosmosContainerRequestOptions

* Cleanup CosmosContainerResponse

* Cleanup CosmosContainerProperties

* Cleanup CosmosDatabase

* Cleanup CosmosDatabaseRequestOptions

* Remove CosmosFeedResponse

* Cleanup CosmosItemRequestOptions

* Cleanup CosmosPermissionsRequestOptions

* Remove CosmosRequestOptions

* Cleanup CosmosStoredProcedure

* Cleanup CosmosStoredProcedureRequestOptions

* Cleanup CosmosTrigger

* Cleanup CosmosUser

* Cleanup CosmosUDF

* Cleanup CosmosUDFResposne

* Clean up CosmosUserResponse

* Cleanup CosmosUserProperties

* Hide old v2 types

* Hide Json constructors

* Remove MediaReadMode

* Hide Undefined

* list to readAll

* Fix json serialization

* 3.0.0 (#218)

* Add samples link (#4206)

add sample link to README

* Move KeyVault track 1 libraries to SDK. (#4094)

* Move the track 1 keyvault libraries into the SDK folder. Still work that needs to be done to make sure that Track 2 can coexist when it moves in.

* Update preview version (#4209)

* Update preview version for core and bump parent version

* Update parent pom version

* Update parent version for sdk template

* Use plugin to update version

* Add version to azure-core

* If body is empty then return publisher emitting response instead of propagating empty publisher (#4208)

* Move tracing to sdk/tracing (#4147)

* Base move.

* Fixed up POM references.

* docs.yml that outputs ref docs for java github.io (#4190)

* doc yaml for generating all the api reference docs for each pomfile
* index template for the repo github.io landing page

* updated azure-arm-client-runtime test jar dependency (#4218)

* updated azure-arm-client-runtime test jar dependency (#4219)

* Generate v2017_11_03_preview for hanaonazure (#4235)

* Resources: generated v2019_05_01 (#4223)

* generated v2019_05_01 of resources

* updated maven versioning

* generated v2019_06_01_preview of containerregistry (#4224)

* update azure-arm-client-runtime test jar dependency (#4233)

* update azure-arm-client-runtime test jar dependency (#4231)

* SQL VirtualMachine: generated v2017_03_01_preview. (#4245)

* Update version of appconfig to 1.0.0-preview.1 (#4237)

* Update version of appconfig to 1.0.0-preview.1

* Update report versions for app configuration.

* Add CHANGELOG known issues and features. (#4244)

* Add changelog known issues and features.

* Adding changed section.

* Update changed/added section.

* Update EventHub core dependency version to preview 2 (#4221)

* Policy: updated azure-arm-client-runtime test jar dependency, pom structure (#4230)

* updated azure-arm-client-runtime test jar dependency, pom structure

* Update pom.xml

* Recoveryservices (#4129)

* generated v2016_08_10 of recoveryservicesbackup

* generated v2018_01_10 of recoveryservices.siterecovery

* update azure-arm-client-runtime test jar dependency

* update azure-arm-client-runtime test jar dependency

* update azure=arm-client-runtime test jar dependency (#4232)

* update azure-arm-client-runtime test jar dependency (#4252)

* Authorization: update azure-arm-client-runtime test jar dependency (#4259)

* update azure-arm-client-runtime test jar dependency

* Update pom.xml

* Resource Health: update azure-arm-client-runtime test jar dependency (#4253)

* update azure-arm-client-runtime test jar dependency

* update azure-arm-client-runtime test jar dependency

* update azure-arm-client-runtime test jar dependency (#4255)

* Service Bus: update azure-arm-client-runtime test jar dependency (#4257)

* update azure-arm-client-runtime test jar dependency

* update azure-arm-client-runtime test jar dependency

* update azure-arm-client-runtime test jar dependency (#4258)

* update azure-arm-client-runtime test jar dependency (#4261)

* update azure-arm-client-runtime test jar dependency (#4264)

* Apply tag to scheduled builds (#4238)

* Setup basic elements for identity ci. (#4267)

* update azure-arm-client-runtime test jar dependency (#4256)

* Update checkstyle suppressions (#4268)

* Add null check for crv.

* Update checkstyle suppressions to use correct paths.

* Update root readme (#4247)

Updating readme.md to follow consistent template specified for all languages

* Fix sample spotbugs (#4275)

* Fix illegalargument when sending with boolean

* Fix spotbugs issue where \n is used rather than %n.

* Setup CI files for loganalytics. (#4278)

* Move identity to sdk/identity (#4271)

* Base move.
* Updated POMs.
* Fixed pom.client.xml
* Fixed up POM reference.

* Update README.md (#4282)

Updating links and text to replace 'common' with 'core', and update version number in maven dependency text.

* samples update (#4285)

* Add Identity to list of preview libraries (#4288)

* Update README.md (#4287)

* First pass at improved readme.md files for /core and /core/azure-core (#4283)

* First pass at improved readme.md files for /core and /core/azure-core

* Add CI config for mediaservices. (#4292)

* Add template CI configuration. (#4294)

* Fix module ref. (#4295)

* Setup CosmosDB CI. (#4296)

* Update App Configuration README with correct links. (#4298)

* Update README with correct links.

* Remove broken JDK link

* Reorganize links.

* Replace Application Configuration with product name. (#4299)

* Update to use aka.ms/java-docs (#4297)

* Prepare for merging preview2 to master

* Move msi-auth-token-provider-jar to sdk/identity (#4269)

Moving the msi-auth-token-provider into authorization.

* Setups up appconfiguration CI. (#4306)

* Enabling more fail on error scenarios (#4286)

Turning on a number of compiler linting errors so we can be more stringent. Suppressing a small number of the failures, and fixing the rest.

* Issue #4194: Make ClientLogger thread-safe (#4248)

* Update ClientLogger to make it thread-safe

* Fix javadoc

* code snippets and log method names refactor

* Update core version to snapshot

* Revert to preview version

* Change core to snapshot version to fix tracing build

* Revert to preview version

* Log using new method

* remove tracing from parent pom

* remove tracing dependency from jacoco

* undo checkstyle and spotbugs changes

* Address CR feedback

* Move mediaservices data-plane to sdk/mediaservices (#4293)

* storage-proto-2 branch to master (#4310)

* Generate blob client

* Address Rick's feedback

* Address checkstyle and p2 spot bugs

* Add Context parameter

* Generate queue and file

* Use block comment on private fields

* Readme for storage queue (#3848)

* Readme for storage queue

* Fix the exposed secret. (#3887)

* no secret on readme

* Client placeholder (#3891)

Boilerplate code for Azure Storage Files clients.

* Empty model classes so the project compiles (#3895)

Adds empty model classes so the project compiles

* Azure Storage Common Credentials and Policies (#3909)

Adds common credentials and policies to Azure Storage client and changes AutoREST Impl files with handwritten overrides until AutoREST codegen is updated.

* Merge back Storage UX study changes (#3973)

* Refactored for Track 2 according to design

* Conversion of client classes to conform to new architecture

* Addressed Compile Errors

Converted most classes to use com.azure.core as well as Reactor.
Excluded classes include
 * All "Clients" (handled elsewhere)
 * RequestRetryFactory (scheduled work)
 * Logging Factory (nontrivial and not necessary for upcoming milestone)

* Refactored ServiceClient to BlobServiceClient

* Convert methods in async raw to return Mono

* Initial builder work

* Blob Client x4 Restructured

Client design pattern for upcoming tests applied to BlobClient.
 * ___Client wraps ___AsyncClient
 * ___AsyncClient wraps ___AsyncRawClient
 * ___RawClient wraps AsyncRawClient
Raw blob clients are package-protected. Non-Raw blob clients are public.
All blob client constructors are package-protected, awaiting a builder.
Work for the other 5 client types is upcoming.

* Add builders for generated clients

* Add builders

* Add builders for clients

* NOT COMPLETE - Added correct types to method signatures in 4 sub types of client classes

* Completed correct method return types for all 4 sub types of clients

* Finished builder pattern implementation.

* Fixed page blob client builders

* Compiles!

* Halfway commit

Addressed some issues where sync clients used async method parameters.

* BlobClient javadocs

* Append, block, page blob javadocs

* Container client javadocs

* BlobServiceClientBuilder and related javadocs

* Add blob api test

* Cleaned up a few things

* Support creating child clients

* Add block blob api test

* Add Alan's SharedKeyCredential

* Fixed most upload/download logic.

* more block blob API test

* Minor fix to async block blob upload

* Set several classes to package-private

Postponing judgement of several classes carried over from v11 library.

* Temporarlily included a test sample file.

Includes REST operations
 * create container
 * list blobs
 * put blob (block blob)
 * get blob

* Add more docs for builders

* Temporarlily included a test sample file.

Includes REST operations
 * create container
 * list blobs
 * put blob (block blob)
 * get blob

* Minor fix

* Blob unit tests compile

* Minor fix

* Fix some compile issues in block blob tests

* Fixed signatures for listing containers.

Updated temporary sample file to show usage.

* Removed key

* Block blob tests pass

* Convert champion and hi pri tests.

* Most tests passing, commented out tests that cannot pass

* Added naive approaches to upload/download from file methods

* Fix connection string

* clean up imports

* Delete duplicate shared key credential

* More clean up

* Return types never return protocol-layer classes

They may return auto-gen models, but won't return ___Response or
___Headers.

* Add line breaks to class level docs

* Missing import

* Make builder constructor public

* Regenerate blob with fixed AutoRest

* Rename blob service client builder method

* Add more javadocs on builder

* Add more javadocs

* Add more info for list

* Minor changes

* Make BlobRange immutable and getContainerClient

* Clean up storage client docs

* More docs and changes from UX studies

* Fix typo

* Fix build break after merge

* Add toUrl() and get{Parent}Client()

* Return Response<T>

* Add Append/Block/Page blob items

* Add .exists() on container and blob client

* Support parallel download and upload

* Support listBlobsHierarchy()

* Upload is stable

* Clean up

* javadoc fixes for listBlobsHierarchy

* Supports AAD through azure-identity credentials

* Cleaned up BlobAPITests

* Cleaned up BlockBlobAPITests

* Download is also stable

* Cleaned up ContainerAPITests

* Fixing up APISpec

* Remove comments

* Fixes SharedKeyCredential

* Add .containerName() and .blobName() on builders

* Update more dependencies (#4020)

Updated bouncy castle and jackson dependencies in a couple more projects

* Kv secrets samples and readme (#3892)

KV Secrets Samples + Readme

* Keys Samples (#4022)

KV Keys Samples + Readme

*  removing spotbug issues (#4033)

* Batch REST API Update - June 2019 (#3861)

* Update Batch Java SDK

* Update  readmes

* Rebase into sdk folder

* Move recordings

* fix bad test

* Azure core fix for storage playback tests. (#4035)

* Make changes to not override the header content length

* Track 2: Event Hubs Client Library (#3655)

* Adding azure-messaging-eventhubs and azure-core-amqp pom.xml.

* Adding EventHubClient, EventHubClientBuilder, EventHubConsumer, EventHubConsumerOptions, EventHubProducer, 
and EventHubProducerOptions.

* Adding configuration options for EventHubClientBuilder.

* Adding azure-core-amqp with common classes to AMQP for Exceptions, Sessions, Links, Connections, TransportTypes, etc.

* Adding authorization with CBS node and getting Event Hub metadata.

* Adding functionality for EventHubConsumer and EventHubProducer.

* Adding support for Azure Identity and TokenCredential.

* Adding a bare set of tests for Azure Event Hubs client library.

* Helper constructor for storage conversion. (#4049)

* Fixing some unit tests

* Reverted change

* Builder fixes

* Add SAS Token Creds to Blobs

* Fix some tests

* Initial BlobInputStream & BlobOutputStream support

* Added snapshot to clients, added createContainer to StorageClient, credentials -> credential

* Address Jonathan's feedback

* Addresses Rick and Alan's comments

* Fix compilations

* Renaming fluent methods and removed context from public API

* Cleaning up changes

* Clean up blob input output stream

* Add entry points to input/output streams

* Moved model classes into model package

* Removed unused classes and classes that replicate core functionality

* Migrated and clean append and page blob unit tests

* Fix block with timeout

* Fix APISpec client credential

* Use async for blob output stream

* Cleaning up more unit tests

* Add retry policy and stablize input/output stream

* More testing

* Merge credentials on builders

* Change inputstream to use bytebuffer

* Cleaning up tests and trying to resolve page upload issues

* Fixed upload tests

* Pass snapshot param to generated methods

* Return url with snapshot on getBlobUrl()

* Return void on stageBlock and stageBlockFromUrl

* Address James's code review feedback

* Fix blob inputstream buffer leak

* Address Rick's code review feedback

* Add retry options on client builders

* Added unit test for snapshot download, fixed missing snapshot passing, eagerly set non-null path pieces

* Reverted pom file changes and commented out test

* Turning on another test

* resolve conflicts

* Fix OffsetDateTime parsing in IdentityClient (#4031)

* Event Hubs: Build break fix, multiple connection and CBS nodes, hanging sends fix (#4052)

* Reduce verbosity of LinkHandler logging.

* Put unconfirmedSends into map before dispatcher.invoke()

* Caching CBSChannelMono so that it is not received multiple times.

* Only sending work when the SenderLink has successfully opened.

* Closing ReactorReceiver message sink upon completion.

* Remove usage of AtomicReferenceFieldUpdator in ReactorConnection.

* Documentation changes in EventHubProducer.

* Fixing issue where EventHubConsumer is not properly subscribing for
events. Adding timeout.

* Rewrapping text and adding logging.

* Adding try/catch when unable to reschedule scheduler task.

* Do not reschedule authorization task if cancelled.

* Increasing wait time between retry.

* Event Hubs Samples (#4053)

* Add hello world sample.

* Adding ReceiveEvent sample.

* Adding samples to the correct aggregate report.

* Adding sample for getting Event Hub metadata

* Fixing bug where the lastRefreshInterval was not properly set. (#4069)

* Fixing bug where the lastRefreshInterval was not properly set.

* generated v2018_03_01 of redis (#4073)

* Cost Management: generated v2018_05_31 (#4076)

* generated v2018_05_31 of costmanagement

* Update parent version in pom

* Identity Library Updates (#4061)

Identity Library updates

* generated v2018_06_30 of automation (#3888)

* Add ci.yml for eventgrid. (#4085)

No need to wait for PR validation for this one.

* MySql: generated v2017_12_01_preview (#4082)

* generated v2017_12_01_preview of mysql

* updated azure-arm-parent version

* PostgreSql: generated v2017_12_01_preview (#4084)

* generated v2017_12_01_preview of postgresql

* updated azure-arm-parent version to 1.1.0

* Fix javadoc description and package groups (#4074)

* Fix javadoc description and package groups

* Include unit test coverage for identity

* re-order javadoc package groups

* generated v2018_04_01 and v2012_12_01_preview of IoTHub (#4088)

* Prep for move of keyvault track 1 libs. (#4093)

* Adding Event Hubs integration and Unit Tests (#4089)

* Adding integration tests for EventHubClient, Producer, Consumer, EventPosition, EventDataBatch, etc.

* Fixing bugs for ConnectionStringProperties and ReactorExecutor

* Adding other status (#4091)

Adding option to provide custom status  Issue #3930

* Publish code coverage results for track 2 build pipelines only (#4096)

* Eventhubs: generated v2017_04_01, v2015_08_01, and v2018_01_01_preview (#4090)

* generated v2017_04_01 of eventhubs

* generated v2018_01_01_preview of eventhubs

* generated v2015_08_01 of eventhubs

* Update client runtime v1 version to 1.6.10 (#4072)

* generated v2018_07_01_preview policyinsights (#3374)

* generated v2016_11_01 of storageimportexport (#4092)

* generated v2016_06_01 of recoveryservices, fixed build error (#3315)

* generated v2019_05_01 of machinelearningservices (#4101)

* Netapp 2019-05-01 and 2017-08-15 (#3508)

* generated netapp v2019-05-01

* adding v2017_08_15 version of netapp as not in sdk but published on maven

* Adds appinsights ci setup in advance of refactoring. (#3925)

* Setup cognitive services CI. (#4106)

* updated azure-arm-parent versioning

* generated v2018_07_01_preview of logic (#4112)

* Adding CONTRIBUTING.md and update version number (#4113)

* Adding CONTRIBUTING.md

* Updating version number to: 5.0.0-preview.1

* Adding more contents to contributing.

* Add link to log levels

* generated v2018_08_01 of network (#4120)

* updated pom versioning (#4121)

* generated v2015_03_20 of loganalytics (#4122)

* generated v2015_11_01_preview of operationsmanagement (#4123)

* updated azure-arm-parent versioning (#4124)

* Add Javadocs and code snippets (#4119)

* Adding Javadocs for EventData

* Adding javadocs for EventHubClientBuilder

* Adding more documentation for EventhubClient and EventHubConsumer

* Adding more documentation and snippets.

* EventHubConsumer: Adding documentation and snippets.

* Remove side-effect of setting proxy-configuration.

* Rename build -> buildAsyncClient

* Keyvault Updates (#4062)

Keyvault Config + Logging + Iterable + Tests Updates + Samples updates + README Updates

* Resourcehealth (#4142)

* added resourcehealth reference to api-specs

* generated v2015_01_01 of resourcehealth

* generated v2017_07_01 of resourcehealth

* Javadoc updates (#4143)

* Update documentation for SendOptions

* Update docs in EventPosition and PartitionProperties.

* Add @see to documentation.

* Added CI configuration files. (#4150)

This should have impact so bypassing checks.

* Cleanup Azure Core Fluent Method Names (#4149)

* Removing with from fluent method nanes

* Cleaning up the unit tests

* Clean up references in SDKs

* More tests and limiting the delivery credits from 8000 to 100. (#4135)

* Fixing minimum/maximum request sizes.

* Adding TestUtils class to unify a lot of duplicated logic when creating/comparing events.

* Adding EventHubConsumerTest.

* [maven-release-plugin] prepare release v1.0.0-preview.1

* [maven-release-plugin] prepare for next development iteration

* Add more SCM info

* README and samples (#4114)

* Add README
* Update Key concepts, Troubleshooting, Next steps
* Add samples

* Revert merge credentials

* Add snapshot on append blobs

* Fix build breaks after merge

* Overlooked merge conflict in spotbugs

* Turned on ServiceAPITests, migrated full ContainerAPITests, changed response type on container getPolicies

* Finished last migration of container client tests, removed 304 as a valid response

* Working on tests

* Removing context tests, added more comments to commented out tests

* Uncommenting tests

* Turning off linting for another pom to has PR validation pass

* Turn off linting to pass PR validation

* TODOs for commented out tests

* yml config

* pom update

* Fixed tests with wrong endpoint (#4222)

* Cherry picking commits from release-preview-2 branch and updating parent ref in storage pom (#4260)

* Update preview version (#4209)

* Update preview version for core and bump parent version

* Update parent pom version

* Update parent version for sdk template

* Use plugin to update version

* Add version to azure-core

* If body is empty then return publisher emitting response instead of propagating empty publisher (#4208)

* Update version of appconfig to 1.0.0-preview.1 (#4237)

* Update version of appconfig to 1.0.0-preview.1

* Update report versions for app configuration.

* Update EventHub core dependency version to preview 2 (#4221)

* Updating storage parent pom to use azure-client-sdk-parent 1.1.0

* The orginal storage-proto (source of storage-proto-2) had a bad merge with upstream master, fixing it (#4251)

* Adding test for BlobInputStream & BloboutputStream and simple blob listing (#4207)

* Adding test for BlobInputStream & BloboutputStream and simple blob listing

* Addressing review comment: use maxResult to test auto-pagination

* disabling failing tests due to not encoding blob-name

* Copying storage team's (James) fix to green more test, commenting out check for etag quote removal

* Fixing eTag quote escaping bug in storage

* Adding CustomHierarchicalListingDeserializer needed for deserialize blob hierarchy listing result

* Adding a test for explicit root container in endpoint

* Restructuring storage module (#4272)

* Restructring storage module to multiple modules

* including blobDownload fix from @sima-zhu

* Using sdk parent as the parent for storage blob

* Removed KeyVault POM file changes

* Removed unused package-info file

* Storage blob samples. (#4210)

* Kv changelog update (#4305)

Keyvault Changelog + README update

* Spotbugs test failures (#4331)

Upgrade to latest spotbugs version (to try to avoid a spotbugs...bug), and then suppress some spotbugs reported issues when that didn't work.

* Storage blob readme (#4330)

* Identity README (#4302)

Azure Identity README

* Added changelog and put Queue readme under queue. (#4333)

* Fix .build method in README. (#4334)

* Simplified for appconfig lib- draft (#4220)

* Simplified for appconfig lib- draft

* keyvault  builder simplification

* removed builder method and updated java doc

*  Documentation change

* Update based on review comments

* Incorporating review comments

* Incorporating review comments

*  fixing java formatting issue

*  Fix checkstyle issue

* Identity Changelog (#4303)

Identity Changelog

* Fix pom.data.xml variables to reference correct variable names (#4336)

* Move appconfiguration (#4307)

* Moved appconfiguration to the sdk folder.
* Adjusted aggregator POM to reference core to solve dependency issue.

* Draft logAndthrow API (#4191)

API that throws an exception through the service logger API . Resolving issue #3924

* folder restructure

* Storage blob sample for Azure Identity (#4343)

* Added Azure Identity for storage sample and readme

* Update azure-core-* packages to 1.0.0-preview.3 (#4344)

* Update azure-core-* packages to 1.0.0-preview.3

* AppConfiguration: Add dependency on azure-core 1.0.0-preview.3

* KeyVault: Add dependency on azure-core 1.0.0-preview.3

* Update EventHubs dependency.

* Move loganalytics to SDK (#4280)

* Move keyvault (#4340)

* Moved keyvault track 2 libraries to sdk/keyvault.
* Added direct module references in pom.client.xml to core and identity to make things build.

* Remove Event Hubs parent pom.xml (#4347)

* Add information from parent pom.xml into azure-eventhubs' pom.xml

* Delete Event Hubs parent pom.xml

* Update reference in pom.client.xml to azure-messaging-eventhubs package

* Update eng/ reports to use preview version of event hubs.

* Using azure-core-* 1.0.0-preview.3

* Update version to 5.0.0-preview.2

* Remove storage parent pom (#4345)

* Fix versions in jacoco and spotbugs reports (#4349)

* Use properties to identify versions of packages.

* Update versions in spotbugs-aggregate-report.

* Cloning Options and so they don't get modified when a new instance is created. (#4309)

* Retry implements Cloneable and Exponential retry implements this.

* Adding tests for ExponentialRetry,  MessageConstant, TransportType, AmqpShutdownSignal, AmqpException, SendOptions.

* SendOptions implements Cloneable.

* Fix spelling mistake in MessageConstants.ABSOLUTE_EXPIRY_TIME

* Adding tests for LinkErrorContext, SessionErrorContext, ErrorContext

* Add test for AmqpResponseCode.

* Add test for ExceptionUtil.

* Update EventHubProducerOptions to clone Retry.

* Add implementation for ExponentialRetry.equals.

* Add test case for ExponentialRetry.clone.

* Fix compilation error for EventHubClient's clone() invocation.

* Add test for EventHubProducerOptions.

* Fix track 1 doc generation. (#4356)

* CheckStyle-Rule-Extension: 1, 2, 4 (#4250)

* Added three new CheckStyle rule extension:

(1) Rule 1: Service Client Instantiation
(2) Rule 2: No external dependencies exposed in public API
(4) Rule 4: Service Client Naming

a few fixes for KV checkstyles errors

*  Initial draft for storage-blob (#4348)

Simpified builder for storage/blob   #3871

* Tag scheduled builds

* Add Storage Module to POM (#4338)

* Add storage to pom as a module

* Bumping Azure Core to preview.3 as preview.2 already exists in Maven with different code

* Bulk of CheckStyle cleanup

* Last of CheckStyle cleanup

* Bulk of SpotBugs cleanup

* Cleaned up JavaDocs

* Updating AppConfiguration and KeyVault to use the correct Azure Core

* Revert version number

* Fixed error in configuration file

* Cleaning up SpotBug configurations

* Fixed client POM

* Fixed sample code

* Fixing unit tests and JavaDoc bug

* Linting cleanup for samples

* Fix last of SpotBug configuration issues

* Ado mgmt ci support (#4273)

* add support for ADO CI

* fix pipeline config file

* update file matching patern

* Add script to generate the mgmt pom file at runtime

* add step to generate the mgmt pom file

* fix yml

* fix file paths

* fix build options

* remove unwanted flag

* remove the am flag

* add debuging info to script

* add more debugging info and modify build cmd

* update build cmd

* add back options

* add debug flag to mvn cmd

* add new script to build each sdk individually

* add simpler script to do the build

* move script to under eng/pipelines

* fix script path

* add script working directory

* add more options to the shell script cmd

* fix path under which cmd executes

* move the mgmt yml to eng/pipelines

* move the mgmt yml directly under eng/pipelines

* add debug info

* Add more debug infoi

* Add java version args to script and suport java 7 and 8

* Fix script

* uncomment build cmd in script

* move default options to script

* add suport for custom maven goals

* fix arguments passed to mvn cmd

* fix arg checks in script

* Fix pipeline yml

* change variable type  from external to pipeline

* fix script

* fix script

* Setup eventhubs ci configs. (#4378)

* suppress ExternalDependencyExposedCheck for track 1 (#4377)

* suppression for track 1

* add no check on tests

* add suppression for implementation

* Move eventhubs (#4380)

* Base move.
* Tweak POM files.

* Update schema in swagger_to_sdk_config.json

* Update swagger_to_sdk_config.json

* Generated from dd0f6521a847b40b3308132f40fa3a41acd830ea

Update dns.json
navalev added a commit to navalev/azure-sdk-for-java that referenced this issue Dec 24, 2019
* use jsonwrapper from azure-core, remove .as() method from Document

* update module info for azure-search

* update azure-core module-info to expose json-wrapper for azure-search

* remove unused jsonwrapper files (moved to azure-core)
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants