Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQ] Storage RequestRetryPolicy timeout time unit should be configurable #17590

Closed
2 tasks done
fcofdez opened this issue Nov 16, 2020 · 1 comment · Fixed by #17628
Closed
2 tasks done

[FEATURE REQ] Storage RequestRetryPolicy timeout time unit should be configurable #17590

fcofdez opened this issue Nov 16, 2020 · 1 comment · Fixed by #17628
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved. Storage Storage Service (Queues, Blobs, Files)

Comments

@fcofdez
Copy link
Contributor

fcofdez commented Nov 16, 2020

Is your feature request related to a problem? Please describe.
Currently, the timeout configured on RequestRetryOptions is just an integer, and since the unit is not
specified in the parameter name, it can lead to confusion. It seems like the current time unit used to configure the
request timeout is seconds (

azure-sdk-for-java/sdk/storage/azure-storage-common/src/main/java/com/azure/storage/common/policy/RequestRetryPolicy.java

Line 114 in 3bce404

.timeout(Duration.ofSeconds(this.requestRetryOptions.getTryTimeout()))
)
But you should dig into the codebase a little in order to understand which time unit is used.

Describe the solution you'd like
I would like to configure the time unit used to configure the request timeout.

Describe alternatives you've considered

Additional context

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

  • Description Added
  • Expected solution specified
@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Nov 16, 2020
@rickle-msft
Copy link
Contributor

Thank you, @fcofdez, for this feature request. It seems reasonable to me. Let me confer with my team and follow up with you.

@rickle-msft rickle-msft added feature-request This issue requires a new behavior in the product in order be resolved. Storage Storage Service (Queues, Blobs, Files) and removed question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Nov 16, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 16, 2020
@gapra-msft gapra-msft mentioned this issue Nov 17, 2020
Merged
@fcofdez fcofdez mentioned this issue Nov 18, 2020
Merged
fixmebot bot referenced this issue in VectorXz/elasticsearch Apr 22, 2021
@VectorXz
Create TestFixMe.md
a9fae03
fixmebot bot referenced this issue in VectorXz/elasticsearch May 28, 2021
@VectorXz
Create Helloworld.md
1398a04
fixmebot bot referenced this issue in VectorXz/elasticsearch Aug 4, 2021
@VectorXz
Update Helloworld.md
f68abab
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-java that referenced this issue Mar 7, 2022
CodeGen from PR 17590 in Azure/azure-rest-api-specs
819d884 
Adding x-ms-ids for Application Insights (Azure#17590)

* Adding x-ms-ids for Application Insights

* Corrections from rebasing
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added ability to specify timeout unit in RequestRetryOptions gapra-msft/azure-sdk-for-java
2 participants
@fcofdez @rickle-msft