Moving Storage to an Independent Repository #556
Conversation
marstr
changed the title
| @@ -0,0 +1,3 @@ | |||
| [submodule "storage"] | |||
There was a problem hiding this comment.
Should we get rid of funcs related to storage in gen.go?
| @@ -2,7 +2,7 @@ sudo: false | |||
|
|
|||
There was a problem hiding this comment.
You will need to get rid of some lines here
Go 1.8 was released on Thursday, February 16th. Many of our partners have adopted and we need to ensure that we support the most recent version.
In order to allow for more independent growth of the storage package, we've given it its own repository. This change updates the main repository to use a submodule in order to prevent breaking changes for folks using storage today who do not want to migrate to the new repository.
There is an existing naming convention for Azure Storage repositories. the repo has been updated to match that convention, this updates the submodule to point to the new URL.
|
Hey @kpfaulkner, I wanted to give you a heads up about this PR and the new repository. If you have a little time, I'd love for you to do a once-over on Azure/azure-storage-go to ensure that there isn't something critical that we're missing. |
|
Hi
Will do! Glad to see a separate repo! :)
Ken
… On 25 Feb 2017, at 09:08, Martin Strobel ***@***.***> wrote:
Hey @kpfaulkner, I wanted to give you a heads up about this PR and the new repository. If you have a little time, I'd love for you to do a once-over on Azure/azure-storage-go to ensure that there isn't something critical that we're missing.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Definitely thumbs up from me. I like the idea of having all the storage functionality separate to the whole management side of things. |
|
Any idea when azure-storage-go would become the official storage repo and the storage dir in azure-sdk-for-go would be deprecated? Or it's still early stages? |
|
Hey Ken, we're targeting Version 9.0 in this repository (so end of the month.) I've been holding out on pulling in this request until closer to when we plan on releasing this change because there is a little chaffing with sub-modules when you switch between branches that have them and don't. However, it may be time to just pull the trigger. It should make clear to folks sending PRs and filing issues that this repo is moved. |
.gitmodules
Outdated
| @@ -1,3 +1,4 @@ | |||
| [submodule "storage"] | |||
| path = storage | |||
| url = https://github.com/Azure/azure-storage-go | |||
| branch = v0.1.0 | |||
There was a problem hiding this comment.
Is branch correct? Cannot glide take tags?
There was a problem hiding this comment.
Oh, lol, this is not glide. But still, the question is the same! Cannot it be tag instead of branch?
There was a problem hiding this comment.
The name branch is misleading here. See this thread:
http://stackoverflow.com/questions/19986075/git-submodule-to-track-remote-branch
Alternatively, try cloning my fork to ensure it works :D
There was a problem hiding this comment.
@mcardosos and I just tinkered with this offline and can confirm go get has the correct behavior.
* Updating CI to use Go 1.8. Go 1.8 was released on Thursday, February 16th. Many of our partners have adopted and we need to ensure that we support the most recent version. * Replacing storage folder with submodule. In order to allow for more independent growth of the storage package, we've given it its own repository. This change updates the main repository to use a submodule in order to prevent breaking changes for folks using storage today who do not want to migrate to the new repository. * Updating submodule target URL. There is an existing naming convention for Azure Storage repositories. the repo has been updated to match that convention, this updates the submodule to point to the new URL. * Responding to review feedback. * Updating submodule to ref v8.1.0 storage version.
* Running latest Go Generator on all released packages. * Gen.go update (#547) * Updated Gen.go to use new autorest builld system * Comments from review * It works as expected again * Moving Storage to an Independent Repository (#556) * Updating CI to use Go 1.8. Go 1.8 was released on Thursday, February 16th. Many of our partners have adopted and we need to ensure that we support the most recent version. * Replacing storage folder with submodule. In order to allow for more independent growth of the storage package, we've given it its own repository. This change updates the main repository to use a submodule in order to prevent breaking changes for folks using storage today who do not want to migrate to the new repository. * Updating submodule target URL. There is an existing naming convention for Azure Storage repositories. the repo has been updated to match that convention, this updates the submodule to point to the new URL. * Responding to review feedback. * Updating submodule to ref v8.1.0 storage version. * Fixing issues found while reviewing PR. * Regenerating using latest swaggers. Using Azure/azure-rest-api-specs commit: 7d9b6c0 * Regenerating with new API Version strategy & web composite. The new API Version strategy associated the API Version to send across the wire with each method instead of at the client level. Doing so allows us to support a broader range of composite swaggers (the immediate example is the web composite swagger.) It also means that making a call with an alternate API version is somewhat more difficult in this version. To do so, one would have to create their own Preparer for the request. In the future, we'll support multiple API Versions and allow for more stability by generating independent packages for each Operation Group in each API Version. We expect to have that done in the summer. * Regenerating against most recent swaggers. * Regenerating using latest preview version of compute.
Go 1.8 was released on Thursday, February 16th. Many of our partners
have adopted and we need to ensure that we support the most recent
version.