Client refactor

[anweiss]

Refactor client for consolidation and to support custom config options

[ahmetb]

Better commit message maybe?

[ahmetb]

since you switched PRs (something we shouldn't do 😄) you lost my comment here. this ManagementCert is not a client configuration. It's regarding how the client is fundamentally built.

Assume you're adding OAuth support and now are you gonna put a token string right next to this? That would be weird... When something like this happens it just means there's a design mistake, in this case you're putting unrelated things together. Config should be things that are shared regardless of how the client is built. Some examples: managementURL, useHTTPS, logger, timeout, retryPolicy etc...

So you should probably replace the NewClientFromConfig to take managementCert []byte parameter along with config.

[anweiss]

I agree. Good points. Will refactor this.

[anweiss]

@ahmetalpbalkan this is driving me insane. So I cloned the MSOpenTech repo in to my Go workspace and added my fork as a separate remote. What should my exact steps be to update my feature branch off my fork to ensure that when I make subsequent commits on this feature branch it doesn't include commits that are already part of the master branch? The steps that I'm using now are as follows:

1. Pull latest from origin/master
2. Checkout anweiss/master
3. Merge origin/master in to anweiss/master
4. Checkout anweiss/multi-env
5. Merge anweiss/master in to anweiss/multi-env
6. Add new commits to feature branch
7. Rebase feature branch to consolidate my commits
8. Force push anweiss/multi-env

[ahmetb]

1. remote all anweiss/ branches (or remove the dir and re-clone)
2. git remote add anweiss (or do not clone from msopentech, instead clone your remote)
3. git fetch anweiss
4. git checkout anweiss/multi-env
5. git checkout -b multi-env
6. git log (verify it's the commit you see here)
7. do changes
8. git push -f anweiss multi-env

[anweiss]

Thanks @ahmetalpbalkan so those steps I have down...but how do I update my multi-env branch with the latest revisions in origin/master?

[ahmetb]

you shouldn't be working on your master. all your changes must be on a branch named multi-env.

$ git checkout multi-env
$ git fetch msopentech
$ git rebase msopentech/master
## resolve merge conflicts, if any. run git status -s, see if "U" exists.
$ git add ??
$ git rebase --continue

[anweiss]

Thanks! Got it all fixed and now know the process for future PRs.

[ahmetb]

this should really call NewClientFromConfig with "default config" (in this case we just have the URL but in the future, default retry policy, etc).

[ahmetb]

LGTM, will merge.