Add check of availability of VM role size in location #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| func GetLocation(location string) (*Location, error) { | ||
| if len(location) == 0 { | ||
| return nil, fmt.Errorf(azure.ParamNotSpecifiedError, "location") |
There was a problem hiding this comment.
if we're always formatting this azure.ParamNotSpecifiedError string, it shouldn't probably be exposed. can you please change while you're at it, or maybe in a separate PR?
There was a problem hiding this comment.
👍 will do on a separate PR
There was a problem hiding this comment.
We have a few options on this - it's used throughout the codebase hence the original decision (I assume) to export it. We could either duplicate wherever necessary and make it internal or leave it as is. Any preference?
There was a problem hiding this comment.
See #28 for an implementation of this.
ruslangabitov
added a commit
that referenced
this pull request
Jan 30, 2015
Add check of availability of VM role size in location
This was referenced Jan 31, 2015
marstr
added a commit
to marstr/azure-sdk-for-go
that referenced
this pull request
Apr 27, 2017
* Adding a "Getting Started" section to the README. * Fixing formating issues. * Responding to review feedback.
marstr
added a commit
that referenced
this pull request
Apr 28, 2017
* Adding a "Getting Started" section to the README. * Fixing formating issues. * Responding to review feedback.
mcardosos
pushed a commit
that referenced
this pull request
May 4, 2017
* Adding a "Getting Started" section to the README. * Fixing formating issues. * Responding to review feedback.
AutorestCI
added a commit
that referenced
this pull request
May 23, 2019
Merge pull request #26 from leonardbf/NFSAAS-2436-R4-corrections NFSAAS-2436 corrections to R4 standard
AutorestCI
added a commit
that referenced
this pull request
Jun 4, 2019
… swagger for GA (#4861) * Generated from 3c2d64eec013f8a6a4666a83a2e3daf9fd44b821 Merge pull request #25 from leonardbf/NFSAAS-2436-R4-corrections NFSAAS-2436 corrections to R4 standard * Generated from f897f2476e09958144c8dd8f3db8699ee6636763 Merge pull request #26 from leonardbf/NFSAAS-2436-R4-corrections NFSAAS-2436 corrections to R4 standard * Generated from 81ff9dd1f123face9e3dae304a8971234c6a5542 Merge pull request #28 from leonardbf/NFSAAS-2436-R4-corrections NFSAAS-2436 corrections to R4 standard
jhendrixMSFT
pushed a commit
that referenced
this pull request
Jun 4, 2019
… swagger for GA (#4861) * Generated from 3c2d64eec013f8a6a4666a83a2e3daf9fd44b821 Merge pull request #25 from leonardbf/NFSAAS-2436-R4-corrections NFSAAS-2436 corrections to R4 standard * Generated from f897f2476e09958144c8dd8f3db8699ee6636763 Merge pull request #26 from leonardbf/NFSAAS-2436-R4-corrections NFSAAS-2436 corrections to R4 standard * Generated from 81ff9dd1f123face9e3dae304a8971234c6a5542 Merge pull request #28 from leonardbf/NFSAAS-2436-R4-corrections NFSAAS-2436 corrections to R4 standard
richardpark-msft
pushed a commit
to richardpark-msft/azure-sdk-for-go
that referenced
this pull request
Aug 5, 2021
Upgrading version of Azure-SDK-for-Go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was previously nothing to prevent creation of a virtual machine of an instance size which was unavailable in a given location - instead the operation completed and getting the status returned a
ResourceNotFounderror. This pull request makes the following changes:GetLocationfunction to thelocationClientin order to get access to the structure without iterating through the list returned fromGetLocationListin multiple spots.verifyInstanceSizeAvailableInLocationto thevmClientand call this in place of verification against the global list.