-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #20718 #20759
Fix #20718 #20759
Conversation
Thank you for your contribution @jlaundry! We will review the pull request and get back to you soon. |
/azp run go - azblob |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
Hey @siminsavani-msft @tasherif-msft - is there anything left to do before this can be merged? |
/azp run go - azblob |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run go - azblob |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run go - azqueue |
Azure Pipelines successfully started running 1 pipeline(s). |
…default domain (copied from Azure/azure-sdk-for-go#20759)
… with non-default domain (copied from Azure/azure-sdk-for-go#20759)
As per #20718, this fixes support for Blob and Queue's NewClientFromConnectionString where the connection string uses both a SAS token and (Blob|Queue)Endpoint parameters.
I've also created
azqueue/internal/shared/shared_test.go
, using the azblob equivalent as a baseline