Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use case-insensitive comparison for success case #17773

Merged
merged 2 commits into from
Apr 29, 2022
Merged

Use case-insensitive comparison for success case #17773

merged 2 commits into from
Apr 29, 2022

Conversation

jhendrixMSFT
Copy link
Member

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to CHANGELOG.md are included.
  • MIT license headers are included in each file.

richardpark-msft
richardpark-msft approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@richardpark-msft richardpark-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best EqualFold() call I've seen this year.

@jhendrixMSFT jhendrixMSFT merged commit a516802 into Azure:main Apr 29, 2022
@jhendrixMSFT jhendrixMSFT deleted the azcore_case_insensitive branch April 29, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardpark-msft richardpark-msft richardpark-msft approved these changes

@RickWinter RickWinter Awaiting requested review from RickWinter RickWinter is a code owner

@chlowell chlowell Awaiting requested review from chlowell chlowell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhendrixMSFT @richardpark-msft