Move LRO failure detection to the implementing poller #17758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the Poller.Poll() method was determining when an LRO failed. While this works for well-known states, it's not extensible. Instead, the underlying polling implementation should be responsible for determining if it's reached a terminal state (failure or otherwise).
jhendrixMSFT
requested review from
RickWinter,
chlowell and
richardpark-msft
as code owners
|
This is in preparation for #17743 |
chlowell
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the Poller.Poll() method was determining when an LRO failed.
While this works for well-known states, it's not extensible. Instead,
the underlying polling implementation should be responsible for
determining if it's reached a terminal state (failure or otherwise).