fix seed num judge error (#18972)

Azure · Aug 30, 2022 · bd89adb · bd89adb
1 parent 4480e9f
commit bd89adb
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 11 deletions.
diff --git a/sdk/resourcemanager/internal/CHANGELOG.md b/sdk/resourcemanager/internal/CHANGELOG.md
@@ -1,14 +1,9 @@
 # Release History
 
-## 1.1.1 (Unreleased)
-
-### Features Added
-
-### Breaking Changes
+## 1.1.1 (2022-08-30)
 
 ### Bugs Fixed
-
-### Other Changes
+* Fix seed not stable with `GenerateAlphaNumericID` when playback
 
 ## 1.1.0 (2022-08-24)
 

diff --git a/sdk/resourcemanager/internal/testutil/recording.go b/sdk/resourcemanager/internal/testutil/recording.go
@@ -123,7 +123,7 @@ func GenerateAlphaNumericID(t *testing.T, prefix string, length int) string {
 			variables := recording.GetVariables(t)
 			if seed, ok := variables[recordingRandomSeedVariableName]; ok {
 				seedNum, err := strconv.ParseInt(seed.(string), 10, 64)
-				if err != nil {
+				if err == nil {
 					recordingRandomSeed = seedNum
 				}
 			}

diff --git a/sdk/resourcemanager/internal/testutil/recording_test.go b/sdk/resourcemanager/internal/testutil/recording_test.go
@@ -38,8 +38,7 @@ func TestStartStopRecording(t *testing.T) {
 
 func TestGenerateAlphaNumericID(t *testing.T) {
 	stop := StartRecording(t, pathToPackage)
-	first := GenerateAlphaNumericID(t, "test", 6)
-	second := GenerateAlphaNumericID(t, "test", 6)
-	require.Equal(t, first, second)
+	rnd := GenerateAlphaNumericID(t, "test", 6)
+	require.Equal(t, rnd, "testsUJVGl")
 	defer stop()
 }