Enable master link replacement feature for cpp #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sima-zhu
requested review from
danieljurek,
joshfree,
RickWinter and
a team
as code owners
joshfree
reviewed
Sep 10, 2020
| ## 1.0.0-beta.1 (Unreleased) | ||
| ## 1.0.0-beta.2 (2020-09-09) | ||
|
|
||
| * Enable master replacement link feature for cpp. |
There was a problem hiding this comment.
Could this line say something about "Engineering System" so external customers know its not an SDK feature
joshfree
approved these changes
Sep 10, 2020
sima-zhu
force-pushed
the
enable_master_replace
branch
from
5ebc484 to
06ef52a
Compare
|
/check-enforcer override |
|
/check-enforcer reset |
weshaggard
approved these changes
Sep 15, 2020
ahsonkhan
reviewed
Sep 15, 2020
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
ghost
pushed a commit
to Azure/azure-sdk-tools
that referenced
this pull request
Oct 19, 2020
This is the final step of link verification epic. Enable the link guidance check for all Ci pipelines. The PR is pending for all lang PRs: java: Azure/azure-sdk-for-java#15285 net: Azure/azure-sdk-for-net#15223 python: Azure/azure-sdk-for-python#13846 js: Azure/azure-sdk-for-js#11317 ios: Azure/azure-sdk-for-ios#433 android: Azure/azure-sdk-for-android#348 go: Azure/azure-sdk-for-go#12541 cpp: Azure/azure-sdk-for-cpp#632 c: Azure/azure-sdk-for-c#1296
benbp
pushed a commit
to Azure/azure-sdk-tools
that referenced
this pull request
Dec 1, 2020
This is the final step of link verification epic. Enable the link guidance check for all Ci pipelines. The PR is pending for all lang PRs: java: Azure/azure-sdk-for-java#15285 net: Azure/azure-sdk-for-net#15223 python: Azure/azure-sdk-for-python#13846 js: Azure/azure-sdk-for-js#11317 ios: Azure/azure-sdk-for-ios#433 android: Azure/azure-sdk-for-android#348 go: Azure/azure-sdk-for-go#12541 cpp: Azure/azure-sdk-for-cpp#632 c: Azure/azure-sdk-for-c#1296
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up step of master link replacement work.
Tested in template:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=532011&view=logs&j=f729e1db-2340-5697-6505-4f6bf41660db&t=926666bf-069f-5669-9149-9ad56a04b65b
Retrieved release tag successfully:
Github IO: https://azuresdkdocs.blob.core.windows.net/$web/cpp/azure-template/1.0.0-beta.3/index.html