add support for null file url value #2334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danewalton
requested review from
CIPop,
ericwolz,
ewertons,
JoseSanchez7,
jspaith,
preethi826 and
vaavva
as code owners
vaavva
approved these changes
Sep 12, 2022
danewalton
force-pushed
the
dane/nullcheck
branch
from
87c3028
to
b3b3d80
Compare
danewalton
requested review from
danieljurek,
weshaggard,
benbp,
ahsonkhan,
antkmsft,
RickWinter,
vhvb1989 and
gearama
as code owners
|
This repository is protected by Check Enforcer. The check-enforcer check-run will not pass until there is at least one more check-run successfully passing. Check Enforcer supports the following comment commands:
|
danewalton
force-pushed
the
dane/nullcheck
branch
from
b3b3d80
to
c617aa0
Compare
|
/azp run c - client - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
danewalton
force-pushed
the
dane/nullcheck
branch
from
c617aa0
to
b869535
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file url values could be
nullif they were deleted in the desired properties section by the service (via a PATCH update). This handles those scenarios, and we will skip over those values.