Fix missing type in netapp, update on PR 8170 - ANF-4290ClarifyMsftChangeToANFSwagger #8783

audunn · 2020-03-20T12:18:52Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

azure-pipelines · 2020-03-20T12:19:11Z

Azure Pipelines successfully started running 1 pipeline(s).

azuresdkci · 2020-03-20T12:38:32Z

Can one of the admins verify this patch?

audunn · 2020-03-20T12:53:20Z

This adds on previous update from #8170 that added "type": "array" to correct an issue with MountTargets, since the MountTargets property is in fact a list of mountTargets not mountTargetList it is probably more accurate to do it like this

    "mountTargets": {
          "title": "mountTargets",
          "type": "array",
          "description": "List of mount targets",
          "items": {
            "$ref": "#/definitions/mountTarget"
          }

This is triggering BreakingChange validation, even if I revert to the solution from the prev PR and just apply that to API version 2019-11-01 (left out) it still fails breakingChange. Not sure what is causing that

Also applies this change to 2019-11-01 since that was omitted from the previous PR.

related issue #8604

azure-pipelines · 2020-03-20T13:18:33Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-20T13:27:43Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-03-20T13:41:31Z

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 184eab9 with merge commit 13173f1. SDK Automation 13.0.17.20200320.2
⚠️netapp/mgmt/2019-05-01 [Logs]
```
No file is changed.
```
⚠️netapp/mgmt/2019-06-01 [Logs]
```
No file is changed.
```
⚠️netapp/mgmt/2019-07-01 [Logs]
```
No file is changed.
```
⚠️netapp/mgmt/2019-08-01 [Logs]
```
No file is changed.
```
⚠️netapp/mgmt/2019-10-01 [Logs]
```
No file is changed.
```
️✔️netapp/mgmt/2019-11-01 [Logs] [Release SDK Changes]
- netapp.mgmt.2019-11-01.zip
⚠️preview/netapp/mgmt/2017-08-15 [Logs]
```
No file is changed.
```

openapi-sdkautomation · 2020-03-20T13:41:40Z

azure-cli-extensions - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-03-20T13:41:42Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 184eab9 with merge commit 13173f1. SDK Automation 13.0.17.20200320.2

️✔️@azure/arm-netapp [Logs] [Release SDK Changes]

azure-arm-netapp-7.0.0.tgz

[npmPack] npm WARN lifecycle @azure/arm-netapp@7.0.0~prepack: cannot run in wd @azure/arm-netapp@7.0.0 npm install && npm run build (wd=/z/work/azure-sdk-for-js/sdk/netapp/arm-netapp)

openapi-sdkautomation · 2020-03-20T13:41:55Z

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 184eab9 with merge commit 13173f1. SDK Automation 13.0.17.20200320.2
️✔️sdk/netapp/mgmt-v2017_08_15 [Logs] [Release SDK Changes]
️✔️sdk/netapp/mgmt-v2019_05_01 [Logs] [Release SDK Changes]
️✔️sdk/netapp/mgmt-v2019_06_01 [Logs] [Release SDK Changes]
️✔️sdk/netapp/mgmt-v2019_07_01 [Logs] [Release SDK Changes]
️✔️sdk/netapp/mgmt-v2019_08_01 [Logs] [Release SDK Changes]
️✔️sdk/netapp/mgmt-v2019_10_01 [Logs] [Release SDK Changes]
️✔️sdk/netapp/mgmt-v2019_11_01 [Logs] [Release SDK Changes]

openapi-sdkautomation · 2020-03-20T13:42:05Z

azure-sdk-for-net - Release

❌ failed [Logs] [Expand Details]

❌ Generate from 184eab9 with merge commit 13173f1. SDK Automation 13.0.17.20200320.2

❌Microsoft.Azure.Management.NetApp [Logs] [Release SDK Changes]

Failed to create the package Microsoft.Azure.Management.NetApp.
Error: dotnet msbuild build.proj /t:CreateNugetPackage /p:Scope=netapp /v:n /p:SkipTests=true , {}

openapi-sdkautomation · 2020-03-20T13:42:25Z

azure-sdk-for-python - Release

- Breaking Change detected in SDK

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 184eab9 with merge commit 13173f1. SDK Automation 13.0.17.20200320.2

⚠️azure-mgmt-netapp [Logs] [Release SDK Changes] Breaking Change Detected

[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
[breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
[ChangeLog] Size of delta 7.391% size of original (original: 26870 chars, delta: 1986 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog] - Model ActiveDirectory has a new parameter site
[ChangeLog] - Added operation VolumesOperations.revert
[ChangeLog] 
[ChangeLog] **Breaking changes**
[ChangeLog] 
[ChangeLog] - Operation SnapshotsOperations.update has a new signature
[ChangeLog] - Operation SnapshotsOperations.update has a new signature
[ChangeLog] - Operation SnapshotsOperations.create has a new signature
[ChangeLog] - Model MountTarget no longer has parameter netmask
[ChangeLog] - Model MountTarget no longer has parameter end_ip
[ChangeLog] - Model MountTarget no longer has parameter subnet
[ChangeLog] - Model MountTarget no longer has parameter provisioning_state
[ChangeLog] - Model MountTarget no longer has parameter gateway
[ChangeLog] - Model MountTarget no longer has parameter start_ip
[ChangeLog] - Model Snapshot no longer has parameter tags
[ChangeLog] - Removed operation group MountTargetsOperations

azure-pipelines · 2020-03-20T14:50:36Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-20T14:57:10Z

Azure Pipelines successfully started running 1 pipeline(s).

weidongxu-microsoft · 2020-03-21T01:47:09Z

@akning-ms
Could you help merge it? I cannot due to BreakingChange.

This is a similar fix as #8170
"type" is missing in previous spec (which is wrong). Hence the breaking change.

…angeToANFSwagger (Azure#8783) * Fix missing type in netapp, ANF-4290ClarifyMsftChangeToANFSwagger * check breaking change validation issue * Change to list of MountTargets * Remove change to list of MountTargets, check breaking change * Fix change to list of MountTargets Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com>

Fix missing type in netapp, ANF-4290ClarifyMsftChangeToANFSwagger

785503d

openapi-assignment-bot bot assigned weidongxu-microsoft Mar 20, 2020

check breaking change validation issue

61c578e

Change to list of MountTargets

eee64b9

Remove change to list of MountTargets, check breaking change

7bb89f4

Fix change to list of MountTargets

184eab9

anthony-c-martin added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Mar 20, 2020

weidongxu-microsoft approved these changes Mar 21, 2020

View reviewed changes

akning-ms merged commit 13173f1 into Azure:master Mar 21, 2020

akning-ms added the LintRuleCandidate Lint Rule Candidate label Mar 21, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix missing type in netapp, update on PR 8170 - ANF-4290ClarifyMsftChangeToANFSwagger #8783

Fix missing type in netapp, update on PR 8170 - ANF-4290ClarifyMsftChangeToANFSwagger #8783

audunn commented Mar 20, 2020 •

edited

Loading

azure-pipelines bot commented Mar 20, 2020

azuresdkci commented Mar 20, 2020

audunn commented Mar 20, 2020 •

edited

Loading

azure-pipelines bot commented Mar 20, 2020

azure-pipelines bot commented Mar 20, 2020

openapi-sdkautomation bot commented Mar 20, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 20, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 20, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 20, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 20, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 20, 2020 •

edited

Loading

azure-pipelines bot commented Mar 20, 2020

azure-pipelines bot commented Mar 20, 2020

weidongxu-microsoft commented Mar 21, 2020 •

edited

Loading

Fix missing type in netapp, update on PR 8170 - ANF-4290ClarifyMsftChangeToANFSwagger #8783

Fix missing type in netapp, update on PR 8170 - ANF-4290ClarifyMsftChangeToANFSwagger #8783

Conversation

audunn commented Mar 20, 2020 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

azure-pipelines bot commented Mar 20, 2020

azuresdkci commented Mar 20, 2020

audunn commented Mar 20, 2020 • edited Loading

azure-pipelines bot commented Mar 20, 2020

azure-pipelines bot commented Mar 20, 2020

openapi-sdkautomation bot commented Mar 20, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Mar 20, 2020 • edited Loading

azure-cli-extensions - Release

openapi-sdkautomation bot commented Mar 20, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Mar 20, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Mar 20, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Mar 20, 2020 • edited Loading

azure-sdk-for-python - Release

- Breaking Change detected in SDK

azure-pipelines bot commented Mar 20, 2020

azure-pipelines bot commented Mar 20, 2020

weidongxu-microsoft commented Mar 21, 2020 • edited Loading

audunn commented Mar 20, 2020 •

edited

Loading

audunn commented Mar 20, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 20, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 20, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 20, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 20, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 20, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 20, 2020 •

edited

Loading

weidongxu-microsoft commented Mar 21, 2020 •

edited

Loading