Added swagger for private link resource API #8655

deymadhumanti · 2020-03-10T09:15:01Z

…ults

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

…ults

azuresdkci · 2020-03-10T09:15:59Z

Can one of the admins verify this patch?

azure-pipelines · 2020-03-12T07:31:44Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-03-12T07:33:04Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 165b7fc with merge commit aa5da1f. SDK Automation 13.0.17.20200326.3

️✔️@azure/arm-recoveryservices [Logs] [Release SDK Changes]

azure-arm-recoveryservices-3.0.0.tgz

[npmPack] npm WARN lifecycle @azure/arm-recoveryservices@3.0.0~prepack: cannot run in wd @azure/arm-recoveryservices@3.0.0 npm install && npm run build (wd=/z/work/azure-sdk-for-js/sdk/recoveryservices/arm-recoveryservices)

openapi-sdkautomation · 2020-03-12T07:33:06Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 165b7fc with merge commit aa5da1f. SDK Automation 13.0.17.20200326.3
️✔️Microsoft.Azure.Management.RecoveryServices [Logs] [Release SDK Changes]
- Microsoft.Azure.Management.RecoveryServices.4.2.1-preview.nupkg
- Microsoft.Azure.Management.RecoveryServices.4.2.1-preview.snupkg

openapi-sdkautomation · 2020-03-12T07:33:06Z

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 165b7fc with merge commit aa5da1f. SDK Automation 13.0.17.20200326.3

⚠️sdk/recoveryservices/mgmt-v2016_06_01 [Logs] [Release SDK Changes]

[mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/recoveryservices/mgmt-v2016_06_01/src/main/java/com/microsoft/azure/management/recoveryservices/v2016_06_01/implementation/RegisteredIdentitiesImpl.java:[15,1] com.microsoft.azure.management.recoveryservices.v2016_06_01.implementation.RegisteredIdentitiesImpl is not abstract and does not override abstract method deleteAsync(java.lang.String,java.lang.String,java.lang.String) in com.microsoft.azure.management.recoveryservices.v2016_06_01.RegisteredIdentities
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-recoveryservices: Compilation failure
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/recoveryservices/mgmt-v2016_06_01/src/main/java/com/microsoft/azure/management/recoveryservices/v2016_06_01/implementation/RegisteredIdentitiesImpl.java:[15,1] com.microsoft.azure.management.recoveryservices.v2016_06_01.implementation.RegisteredIdentitiesImpl is not abstract and does not override abstract method deleteAsync(java.lang.String,java.lang.String,java.lang.String) in com.microsoft.azure.management.recoveryservices.v2016_06_01.RegisteredIdentities
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

openapi-sdkautomation · 2020-03-12T07:33:07Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 165b7fc with merge commit aa5da1f. SDK Automation 13.0.17.20200326.3
️✔️recoveryservices/mgmt/2016-06-01 [Logs] [Release SDK Changes]
- recoveryservices.mgmt.2016-06-01.zip

openapi-sdkautomation · 2020-03-12T07:33:09Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 165b7fc with merge commit aa5da1f. SDK Automation 13.0.17.20200326.3

️✔️azure-mgmt-recoveryservices [Logs] [Release SDK Changes]

[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
[breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
[ChangeLog] Size of delta 18.598% size of original (original: 26481 chars, delta: 4925 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog]   - Model VaultProperties has a new parameter private_endpoint_connections
[ChangeLog]   - Model VaultProperties has a new parameter private_endpoint_state_for_backup
[ChangeLog]   - Model VaultProperties has a new parameter private_endpoint_state_for_site_recovery
[ChangeLog]   - Model Vault has a new parameter identity
[ChangeLog]   - Added operation group PrivateLinkResourcesOperations

...n/recoveryservices/resource-manager/Microsoft.RecoveryServices/stable/2016-06-01/vaults.json

Asmaskar rrp swagger

azure-pipelines · 2020-03-17T13:24:00Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-03-17T14:03:29Z

azure-cli-extensions - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

...n/recoveryservices/resource-manager/Microsoft.RecoveryServices/stable/2016-06-01/vaults.json

PeRrpSwagger

azure-pipelines · 2020-03-18T09:17:49Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-18T10:26:55Z

Azure Pipelines successfully started running 1 pipeline(s).

...n/recoveryservices/resource-manager/Microsoft.RecoveryServices/stable/2016-06-01/vaults.json

azure-pipelines · 2020-03-30T08:47:06Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-30T13:23:53Z

Azure Pipelines successfully started running 1 pipeline(s).

pilor

ArcturusZhang · 2020-03-31T00:32:08Z

Hi @deymadhumanti please resolve the CI failures (Spell check and prettier). And as for the breaking changes check, could you provide a justification of this? Or it is only a false alarm?

Hi @ChenTanyi would you please take a look at the Java generation failure?

ChenTanyi · 2020-03-31T02:10:39Z

The generation error is due to privateLinkResources, the java will make auto collections for every resource with conflict with https://github.com/Azure/azure-rest-api-specs/pull/8655/files#diff-02ce4ce9148599d2d4ec2600b9c4626cR1165. @weidongxu-microsoft Is it possible for us to generate without collections if there is already a collections.

weidongxu-microsoft · 2020-03-31T02:23:31Z

@ChenTanyi No idea, you know as much as I know about v2 generator.

My suggestion is to try another name for "PrivateLinkResources" definition, like "PrivateLinkResourceListResult". E.g. https://github.com/Azure/azure-rest-api-specs/blob/master/specification/cosmos-db/resource-manager/Microsoft.DocumentDB/preview/2019-08-01-preview/privateLinkResources.json#L117

ChenTanyi · 2020-03-31T02:29:23Z

@ChenTanyi No idea, you know as much as I know about v2 generator.

My suggestion is to try another name for "PrivateLinkResources" definition, like "PrivateLinkResourceListResult". E.g. https://github.com/Azure/azure-rest-api-specs/blob/master/specification/cosmos-db/resource-manager/Microsoft.DocumentDB/preview/2019-08-01-preview/privateLinkResources.json#L117

@deymadhumanti Could you change for this name, if you want to update Java sdk. Thanks!

deymadhumanti · 2020-03-31T05:36:54Z

@ChenTanyi No idea, you know as much as I know about v2 generator.
My suggestion is to try another name for "PrivateLinkResources" definition, like "PrivateLinkResourceListResult". E.g. https://github.com/Azure/azure-rest-api-specs/blob/master/specification/cosmos-db/resource-manager/Microsoft.DocumentDB/preview/2019-08-01-preview/privateLinkResources.json#L117

@deymadhumanti Could you change for this name, if you want to update Java sdk. Thanks!

Hi @ChenTanyi , Can we use "PrivateLinkResourceList" for PrivateLinkResources. Please confirm. I will make the json change accordingly,

ChenTanyi · 2020-03-31T05:42:59Z

@deymadhumanti Yes, it could be PrivateLinkResourceList.

It could be anything you like which could be separated from other resources and their plurality.
For example, the java sdk will automatically collect all privateLinkResource into privateLinkResources. And so as others.

deymadhumanti · 2020-03-31T05:45:31Z

Hi @deymadhumanti please resolve the CI failures (Spell check and prettier). And as for the breaking changes check, could you provide a justification of this? Or it is only a false alarm?

Hi @ChenTanyi would you please take a look at the Java generation failure?

Hi @ArcturusZhang , Prettier Check is successful here. I am looking at SpellCheck failure and update it .

deymadhumanti · 2020-03-31T06:13:12Z

Hi @deymadhumanti please resolve the CI failures (Spell check and prettier). And as for the breaking changes check, could you provide a justification of this? Or it is only a false alarm?

Hi @ChenTanyi would you please take a look at the Java generation failure?

Hi @ArcturusZhang , Regarding breaking change failure:

The earlier schema for CheckNameAvailability response was erronous. It was added as part of Added Swagger details for CheckNameAvailability API #5496 and OAV example validation wasn’t performed as a part of validation for the same. SDK has not been generated for the same since the swagger changes were made.

With the current PR we are fixing the response to CheckNameAvailability API and we have also validated the same using OAV spec and example validation tool. It is in accordance with format mentioned at - https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/proxy-api-reference.md#check-name-availability-requests

… failures

azure-pipelines · 2020-03-31T07:35:41Z

Azure Pipelines successfully started running 1 pipeline(s).

deymadhumanti · 2020-03-31T08:02:51Z

Hi @deymadhumanti please resolve the CI failures (Spell check and prettier). And as for the breaking changes check, could you provide a justification of this? Or it is only a false alarm?
Hi @ChenTanyi would you please take a look at the Java generation failure?

Hi @ArcturusZhang , Prettier Check and Spell Check are successful now. For Breaking changes, I have already explained. Can you please check this

deymadhumanti · 2020-03-31T08:04:15Z

@deymadhumanti Yes, it could be PrivateLinkResourceList.

It could be anything you like which could be separated from other resources and their plurality.
For example, the java sdk will automatically collect all privateLinkResource into privateLinkResources. And so as others.

Hi @ChenTanyi , I have changed PrivateLinkResources to PrivateLinkResourceList. But still Java SDK generation is failing with same error. Can you please take a look

ArcturusZhang · 2020-03-31T08:13:06Z

Hi @deymadhumanti please resolve the CI failures (Spell check and prettier). And as for the breaking changes check, could you provide a justification of this? Or it is only a false alarm?
Hi @ChenTanyi would you please take a look at the Java generation failure?

Hi @ArcturusZhang , Prettier Check and Spell Check are successful now. For Breaking changes, I have already explained. Can you please check this

I think the breaking changes are reasonable based on what you said. But since the breaking changes CI is a required check, this PR must wait for @akning-ms 's approval and eventually merge.
Hi @akning-ms could you please have a look at this?

ChenTanyi · 2020-03-31T12:02:51Z

@deymadhumanti After my test, it is not the error caused by items, the privateLinkResourceList can be changed back if you like.

The problem is in operations, java always use operations in plural format.
PrivateLinkResources_List and PrivateLinkResource_Get in operationId are conflict. You can change it into same prefix, or use directive in readme like https://github.com/azure/azure-rest-api-specs/blob/89c0f6e94d390cd4c3bfe992bac632db6058e9fd/specification/adhybridhealthservice/resource-manager/readme.java.md#L14

azure-pipelines · 2020-03-31T13:55:11Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-31T16:31:35Z

Azure Pipelines successfully started running 1 pipeline(s).

deymadhumanti · 2020-03-31T16:53:44Z

Hi @deymadhumanti please resolve the CI failures (Spell check and prettier). And as for the breaking changes check, could you provide a justification of this? Or it is only a false alarm?
Hi @ChenTanyi would you please take a look at the Java generation failure?

Hi @ArcturusZhang , Prettier Check and Spell Check are successful now. For Breaking changes, I have already explained. Can you please check this

I think the breaking changes are reasonable based on what you said. But since the breaking changes CI is a required check, this PR must wait for @akning-ms 's approval and eventually merge.
Hi @akning-ms could you please have a look at this?

Hi @akning-ms, Can you please take a look at this PR.

* Added GEt-privateLinkResources API and managedIdentity changes for Vaults * Fixed PrettierCheck failure * Update vaults.json * Update vaults.json * Resolved PR commens related to PrivateLinkResources * Resolved PR comments * resolved PR comments * Using x-ms-client-flatten for PrivateLinkResourceProperties * Fixing examples for PrivateLinkResources * Revert "Fixing examples for PrivateLinkResources" This reverts commit b0d62a2. * Revert "Using x-ms-client-flatten for PrivateLinkResourceProperties" This reverts commit 31ba2d0. * Using x-ms-client-flatten for PrivateLinkResourceProperties * Fixing examples for PrivateLinkResources * Adding description for privateLinkResourceProperties * Resolved PR comments. Fixed SpellCheck and PrettierCheck and Java SDK failures * Changing operationId for PrivateLinkResource to PrivateLinkResources * Renaming PrivateLinkResourceList to PrivateLinkResources Co-authored-by: deymadhumanti <deymadhumanti@users.noreply.github.com> Co-authored-by: asmaskar <asmaskar@microsoft.com> Co-authored-by: asmaskar <58723769+asmaskar@users.noreply.github.com> Co-authored-by: Aman Chandna <amchandn@microsoft.com>

Added GEt-privateLinkResources API and managedIdentity changes for Va…

878c763

…ults

openapi-assignment-bot bot assigned ArcturusZhang Mar 10, 2020

sumitmal2711 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 10, 2020

Fixed PrettierCheck failure

febcec4

anthony-c-martin requested changes Mar 17, 2020

View reviewed changes

anthony-c-martin added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 17, 2020

asmaskar and others added 4 commits March 17, 2020 15:02

Update vaults.json

1398ace

Update vaults.json

ac995f7

Merge pull request #1 from asmaskar/asmaskarRrpSwagger

fb18e65

Asmaskar rrp swagger

Resolved PR commens related to PrivateLinkResources

8620701

amchandn reviewed Mar 17, 2020

View reviewed changes

...n/recoveryservices/resource-manager/Microsoft.RecoveryServices/stable/2016-06-01/vaults.json Show resolved Hide resolved

amchandn reviewed Mar 17, 2020

View reviewed changes

...n/recoveryservices/resource-manager/Microsoft.RecoveryServices/stable/2016-06-01/vaults.json Show resolved Hide resolved

Merge pull request #1 from asmaskar/peRRPswagger

d3f3915

PeRrpSwagger

Resolved PR comments

197c62c

pilor reviewed Mar 23, 2020

View reviewed changes

...n/recoveryservices/resource-manager/Microsoft.RecoveryServices/stable/2016-06-01/vaults.json Show resolved Hide resolved

amchandn added 2 commits March 30, 2020 11:56

Using x-ms-client-flatten for PrivateLinkResourceProperties

9c65805

Fixing examples for PrivateLinkResources

9a1d84c

Adding description for privateLinkResourceProperties

ec6def8

pilor approved these changes Mar 30, 2020

View reviewed changes

pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Mar 30, 2020

Resolved PR comments. Fixed SpellCheck and PrettierCheck and Java SDK…

89c0f6e

… failures

Changing operationId for PrivateLinkResource to PrivateLinkResources

ea2451f

openapi-sdkautomation bot mentioned this pull request Mar 31, 2020

[AutoPR sdk/recoveryservices/mgmt-v2016_06_01] Added swagger for private link resource API AzureSDKAutomation/azure-sdk-for-java#2513

Closed

Renaming PrivateLinkResourceList to PrivateLinkResources

165b7fc

akning-ms merged commit aa5da1f into Azure:master Apr 6, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added swagger for private link resource API #8655

Added swagger for private link resource API #8655

deymadhumanti commented Mar 10, 2020 •

edited by sumitmal2711

Loading

azuresdkci commented Mar 10, 2020

azure-pipelines bot commented Mar 12, 2020

openapi-sdkautomation bot commented Mar 12, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 12, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 12, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 12, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 12, 2020 •

edited

Loading

azure-pipelines bot commented Mar 17, 2020

openapi-sdkautomation bot commented Mar 17, 2020 •

edited

Loading

azure-pipelines bot commented Mar 18, 2020

azure-pipelines bot commented Mar 18, 2020

azure-pipelines bot commented Mar 30, 2020

azure-pipelines bot commented Mar 30, 2020

pilor left a comment

ArcturusZhang commented Mar 31, 2020

ChenTanyi commented Mar 31, 2020

weidongxu-microsoft commented Mar 31, 2020

ChenTanyi commented Mar 31, 2020

deymadhumanti commented Mar 31, 2020

ChenTanyi commented Mar 31, 2020

deymadhumanti commented Mar 31, 2020

deymadhumanti commented Mar 31, 2020

azure-pipelines bot commented Mar 31, 2020

deymadhumanti commented Mar 31, 2020

deymadhumanti commented Mar 31, 2020

ArcturusZhang commented Mar 31, 2020

ChenTanyi commented Mar 31, 2020

azure-pipelines bot commented Mar 31, 2020

azure-pipelines bot commented Mar 31, 2020

deymadhumanti commented Mar 31, 2020

Added swagger for private link resource API #8655

Added swagger for private link resource API #8655

Conversation

deymadhumanti commented Mar 10, 2020 • edited by sumitmal2711 Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

azuresdkci commented Mar 10, 2020

azure-pipelines bot commented Mar 12, 2020

openapi-sdkautomation bot commented Mar 12, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Mar 12, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Mar 12, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Mar 12, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Mar 12, 2020 • edited Loading

azure-sdk-for-python - Release

azure-pipelines bot commented Mar 17, 2020

openapi-sdkautomation bot commented Mar 17, 2020 • edited Loading

azure-cli-extensions - Release

azure-pipelines bot commented Mar 18, 2020

azure-pipelines bot commented Mar 18, 2020

azure-pipelines bot commented Mar 30, 2020

azure-pipelines bot commented Mar 30, 2020

pilor left a comment

Choose a reason for hiding this comment

ArcturusZhang commented Mar 31, 2020

ChenTanyi commented Mar 31, 2020

weidongxu-microsoft commented Mar 31, 2020

ChenTanyi commented Mar 31, 2020

deymadhumanti commented Mar 31, 2020

ChenTanyi commented Mar 31, 2020

deymadhumanti commented Mar 31, 2020

deymadhumanti commented Mar 31, 2020

azure-pipelines bot commented Mar 31, 2020

deymadhumanti commented Mar 31, 2020

deymadhumanti commented Mar 31, 2020

ArcturusZhang commented Mar 31, 2020

ChenTanyi commented Mar 31, 2020

azure-pipelines bot commented Mar 31, 2020

azure-pipelines bot commented Mar 31, 2020

deymadhumanti commented Mar 31, 2020

deymadhumanti commented Mar 10, 2020 •

edited by sumitmal2711

Loading

openapi-sdkautomation bot commented Mar 12, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 12, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 12, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 12, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 12, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 17, 2020 •

edited

Loading