-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NetApp API version 2019-10-01 #7908
Conversation
Initial commit including just a copy of the old API.
ANF-440 update to API version 2019-10-01
Azure Pipelines successfully started running 1 pipeline(s). |
Automation for azure-sdk-for-pythonA PR has been created for you: |
azure-sdk-for-python - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-go - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-net - Release
|
ANF-440 correct 2019-10-01 API
Azure Pipelines successfully started running 1 pipeline(s). |
ANF-440 API 2019-10-01 corrections
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see comments on methods.
specification/netapp/resource-manager/Microsoft.NetApp/stable/2019-10-01/netapp.json
Show resolved
Hide resolved
specification/netapp/resource-manager/Microsoft.NetApp/stable/2019-10-01/netapp.json
Show resolved
Hide resolved
specification/netapp/resource-manager/Microsoft.NetApp/stable/2019-10-01/netapp.json
Show resolved
Hide resolved
specification/netapp/resource-manager/Microsoft.NetApp/stable/2019-10-01/netapp.json
Show resolved
Hide resolved
@maphad It looks like from the on call list that you are currently the primary contact. This swagger is becoming urgent as it is required for our ANF RP which has been rolled out. Is there any chance someone could complete the review? There are some validation issues that need assistance and a few replies to comments which are unresolved also. Many thanks. |
specification/netapp/resource-manager/Microsoft.NetApp/stable/2019-10-01/netapp.json
Show resolved
Hide resolved
specification/netapp/resource-manager/Microsoft.NetApp/stable/2019-10-01/netapp.json
Show resolved
Hide resolved
specification/netapp/resource-manager/Microsoft.NetApp/stable/2019-10-01/netapp.json
Show resolved
Hide resolved
specification/netapp/resource-manager/Microsoft.NetApp/stable/2019-10-01/netapp.json
Show resolved
Hide resolved
specification/netapp/resource-manager/Microsoft.NetApp/stable/2019-10-01/netapp.json
Show resolved
Hide resolved
specification/netapp/resource-manager/Microsoft.NetApp/stable/2019-10-01/netapp.json
Show resolved
Hide resolved
specification/netapp/resource-manager/Microsoft.NetApp/stable/2019-10-01/netapp.json
Outdated
Show resolved
Hide resolved
specification/netapp/resource-manager/Microsoft.NetApp/stable/2019-10-01/netapp.json
Show resolved
Hide resolved
specification/netapp/resource-manager/Microsoft.NetApp/stable/2019-10-01/netapp.json
Show resolved
Hide resolved
specification/netapp/resource-manager/Microsoft.NetApp/stable/2019-10-01/netapp.json
Outdated
Show resolved
Hide resolved
ANF-440 update to API version 2019-10-01
Azure Pipelines successfully started running 1 pipeline(s). |
ANF-440 update to API version 2019-10-01
Azure Pipelines successfully started running 1 pipeline(s). |
All review comments responded to. No guidance received as to why the Java SDK step is failing. Please advise on that. |
Java SDK pipeline shows the following error indicating one of your GET paths is marked as x-ms-long-running-operation which is not supported. |
Azure Pipelines successfully started running 1 pipeline(s). |
hello, @leonardbf it seems there is still a change request, which blocks me to merge this PR |
@njuCZ I've been through all the review comments. I see one that is not marked as resolved but the reviewer @pilor has approved. I also see the 'change requested' from @KrisBash but all of the review comments have been answered and marked resolved. I'm not sure what further change is required. |
New API version for NetApp files
Internal ticket ANF-440
Note on review comment backlog.
These are visible in JIRA ANF-611.
5)There's a lot of redundancy in these definitions - (https://github.com/Azure/azure-rest-api-specs-pr/pull/873#discussion_r321568972) - ETA xx/xx/xx
Item 4 is longer applicable because mount target has been removed. Item 6 has been fixed. The others will be targetted for the upcoming 2019-11-01 API which is due at the end of December.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.