Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NetApp API version 2019-10-01 #7908

Merged
merged 22 commits into from
Dec 23, 2019
Merged

Add NetApp API version 2019-10-01 #7908

merged 22 commits into from
Dec 23, 2019

Conversation

leonardbf
Copy link
Contributor

@leonardbf leonardbf commented Dec 5, 2019

New API version for NetApp files
Internal ticket ANF-440

Note on review comment backlog.
These are visible in JIRA ANF-611.

  1. A subscription level list api is required - (https://github.com/Azure/azure-rest-api-specs-pr/pull/873#discussion_r321566916) - ETA xx/xx/xx
  2. Do you support both 201 and 202? - (https://github.com/Azure/azure-rest-api-specs-pr/pull/873#discussion_r321566983) - ETA xx/xx/xx
  3. It's best to use shared definitions for the top-level properties - (https://github.com/Azure/azure-rest-api-specs-pr/pull/873#discussion_r321567787) - ETA xx/xx/xx
  4. mountTargets shouldn't have tags - (https://github.com/Azure/azure-rest-api-specs-pr/pull/873#discussion_r321568157)
    5)There's a lot of redundancy in these definitions - (https://github.com/Azure/azure-rest-api-specs-pr/pull/873#discussion_r321568972) - ETA xx/xx/xx
  5. Needs to follow the Noun_Verb format else you get language-specific class names and loose consistency - (New API version 2019-07-01 for ANF #7020 (comment)) - ETA xx/xx/xx

Item 4 is longer applicable because mount target has been removed. Item 6 has been fixed. The others will be targetted for the upcoming 2019-11-01 API which is due at the end of December.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

leonardbf and others added 3 commits December 5, 2019 15:12
Initial commit including just a copy of the old API.
ANF-440 update to API version 2019-10-01
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@AutorestCI
Copy link

AutorestCI commented Dec 5, 2019

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#9012

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 5, 2019

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 2b995ff with merge commit ae38884. SDK Automation 13.0.17.20191213.4
    Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-python/pull/64: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Mon, 23 Dec 2019 05:37:14 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"07C4:1DDA:1F0FA7:4C3827:5E00528A","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4955","x-ratelimit-reset":"1577083024","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-python/git/refs/heads/sdkAutomation/azure-mgmt-netapp@7908","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/12.13.1 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://developer.github.com/v3/git/refs/#delete-a-reference"}
  • ️✔️azure-mgmt-netapp [Logs]  [Release SDK Changes]
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 5, 2019

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 2b995ff with merge commit ae38884. SDK Automation 13.0.17.20191213.4
    Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-js/pull/61: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Mon, 23 Dec 2019 05:37:09 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"07C0:7537:89A55A:161F95E:5E005285","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4979","x-ratelimit-reset":"1577083024","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-js/git/refs/heads/sdkAutomation/@azure_arm-netapp@7908","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/12.13.1 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://developer.github.com/v3/git/refs/#delete-a-reference"}
  • ️✔️@azure/arm-netapp [Logs]  [Release SDK Changes]
    [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/azureNetAppFilesManagementClient.js → ./dist/arm-netapp.js...
    [npmPack] created ./dist/arm-netapp.js in 436ms

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 5, 2019

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 2b995ff with merge commit ae38884. SDK Automation 13.0.17.20191213.4
  • ⚠️netapp/mgmt/2019-05-01 [Logs
      No file is changed.
    • ⚠️netapp/mgmt/2019-06-01 [Logs
        No file is changed.
      • ⚠️netapp/mgmt/2019-07-01 [Logs
          No file is changed.
        • ⚠️netapp/mgmt/2019-08-01 [Logs
            No file is changed.
          • ️✔️netapp/mgmt/2019-10-01 [Logs]  [Release SDK Changes]
          • ⚠️preview/netapp/mgmt/2017-08-15 [Logs
              No file is changed.

            @openapi-sdkautomation
            Copy link

            openapi-sdkautomation bot commented Dec 5, 2019

            azure-sdk-for-java - Release

            ️✔️ succeeded [Logs] [Expand Details]
            • ️✔️ Generate from 2b995ff with merge commit ae38884. SDK Automation 13.0.17.20191213.4
              Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-java/pull/440: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Mon, 23 Dec 2019 05:37:21 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"07DC:1DDA:1F0FC2:4C387B:5E00528E","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4935","x-ratelimit-reset":"1577083024","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-java/git/refs/heads/sdkAutomation/sdk_netapp_mgmt-v2019_08_01@7908","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/12.13.1 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://developer.github.com/v3/git/refs/#delete-a-reference"}
              Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-java/pull/438: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Mon, 23 Dec 2019 05:37:22 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"07DB:1DAA:66C000:EF0CD2:5E00528E","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4931","x-ratelimit-reset":"1577083024","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-java/git/refs/heads/sdkAutomation/sdk_netapp_mgmt-v2019_06_01@7908","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/12.13.1 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://developer.github.com/v3/git/refs/#delete-a-reference"}
              Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-java/pull/436: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Mon, 23 Dec 2019 05:37:22 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"07E2:449A:A14888:167A9A6:5E00528E","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4930","x-ratelimit-reset":"1577083024","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-java/git/refs/heads/sdkAutomation/sdk_netapp_mgmt-v2017_08_15@7908","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/12.13.1 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://developer.github.com/v3/git/refs/#delete-a-reference"}
              Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-java/pull/129: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Mon, 23 Dec 2019 05:37:22 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"07E4:1E5B:3A16FD:986110:5E00528E","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4929","x-ratelimit-reset":"1577083024","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-java/git/refs/heads/sdkAutomation/sdk_netapp_mgmt-v2019_05_01@7908","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/12.13.1 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://developer.github.com/v3/git/refs/#delete-a-reference"}
              Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-java/pull/441: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Mon, 23 Dec 2019 05:37:22 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"07E5:1E54:51F063:D895BC:5E00528E","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4928","x-ratelimit-reset":"1577083024","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-java/git/refs/heads/sdkAutomation/sdk_netapp_mgmt-v2019_10_01@7908","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/12.13.1 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://developer.github.com/v3/git/refs/#delete-a-reference"}
              Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-java/pull/439: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Mon, 23 Dec 2019 05:37:23 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"07DE:1E79:63BD81:ED79C3:5E00528E","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4927","x-ratelimit-reset":"1577083024","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-java/git/refs/heads/sdkAutomation/sdk_netapp_mgmt-v2019_07_01@7908","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/12.13.1 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://developer.github.com/v3/git/refs/#delete-a-reference"}
            • ️✔️sdk/netapp/mgmt-v2017_08_15 [Logs]  [Release SDK Changes]
            • ️✔️sdk/netapp/mgmt-v2019_05_01 [Logs]  [Release SDK Changes]
            • ️✔️sdk/netapp/mgmt-v2019_06_01 [Logs]  [Release SDK Changes]
            • ️✔️sdk/netapp/mgmt-v2019_07_01 [Logs]  [Release SDK Changes]
            • ️✔️sdk/netapp/mgmt-v2019_08_01 [Logs]  [Release SDK Changes]
            • ️✔️sdk/netapp/mgmt-v2019_10_01 [Logs]  [Release SDK Changes]

            @openapi-sdkautomation
            Copy link

            openapi-sdkautomation bot commented Dec 5, 2019

            azure-sdk-for-net - Release

            ️✔️ succeeded [Logs] [Expand Details]

            @azure-pipelines
            Copy link

            Azure Pipelines successfully started running 1 pipeline(s).

            @azure-pipelines
            Copy link

            Azure Pipelines successfully started running 1 pipeline(s).

            @njuCZ njuCZ added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 6, 2019
            Copy link
            Contributor

            @KrisBash KrisBash left a comment

            Choose a reason for hiding this comment

            The reason will be displayed to describe this comment to others. Learn more.

            Please see comments on methods.

            @leonardbf
            Copy link
            Contributor Author

            @maphad It looks like from the on call list that you are currently the primary contact. This swagger is becoming urgent as it is required for our ANF RP which has been rolled out. Is there any chance someone could complete the review? There are some validation issues that need assistance and a few replies to comments which are unresolved also. Many thanks.

            @azure-pipelines
            Copy link

            Azure Pipelines successfully started running 1 pipeline(s).

            @azure-pipelines
            Copy link

            Azure Pipelines successfully started running 1 pipeline(s).

            @leonardbf
            Copy link
            Contributor Author

            All review comments responded to. No guidance received as to why the Java SDK step is failing. Please advise on that.

            @pilor
            Copy link
            Contributor

            pilor commented Dec 19, 2019

            All review comments responded to. No guidance received as to why the Java SDK step is failing. Please advise on that.

            Java SDK pipeline shows the following error indicating one of your GET paths is marked as x-ms-long-running-operation which is not supported.

            https://dev.azure.com/azure-sdk/internal/_build/results?buildId=216031&view=logs&j=ffad7180-476d-5b8a-bb7f-738e424e0370&t=8758729c-a441-534c-c83f-5e2ccb415436&l=263

            @pilor pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 19, 2019
            @azure-pipelines
            Copy link

            Azure Pipelines successfully started running 1 pipeline(s).

            @njuCZ
            Copy link
            Contributor

            njuCZ commented Dec 20, 2019

            hello, @leonardbf it seems there is still a change request, which blocks me to merge this PR

            @leonardbf
            Copy link
            Contributor Author

            hello, @leonardbf it seems there is still a change request, which blocks me to merge this PR

            @njuCZ I've been through all the review comments. I see one that is not marked as resolved but the reviewer @pilor has approved. I also see the 'change requested' from @KrisBash but all of the review comments have been answered and marked resolved. I'm not sure what further change is required.

            Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
            Labels
            ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
            Projects
            None yet
            Development

            Successfully merging this pull request may close these issues.

            6 participants