Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure Search] Remove the "track2" version of 2019-05-06-Preview swaggers #7734

Merged
merged 2 commits into from
Nov 12, 2019

Conversation

arv100kri
Copy link
Member

@arv100kri arv100kri commented Nov 7, 2019

This PR #7615 introduced (as a work in progress) swagger for the REST API version 2019-05-06-Preview

It was introduced in the carved out "track1" directory as well as the non-carved out "track2" (base) directory - we expected work on both to happen in parallel.

However, the Azure search is now ready to add features (and finish the progress) for "track1" 2019-05-06-Preview; and we don't have plans on "track2" until next year - meaning, if we keep both copies around, we'll be required to duplicate changes unnecessarily.

This PR eliminates the "track2" copy in the hopes that in the future when are ready to work on it, a different PR will introduce it.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented Nov 7, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci azuresdkci requested a review from sarangan12 November 7, 2019 22:12
@AutorestCI
Copy link

AutorestCI commented Nov 7, 2019

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@sarangan12 sarangan12 merged commit 70428fe into Azure:master Nov 12, 2019
solhaile pushed a commit to solhaile/azure-rest-api-specs that referenced this pull request Nov 13, 2019
…gers (Azure#7734)

* Remove from 'track2' copy the swagger for 2019-05-06-Preview

* Remove from 'track2' copy the swagger for 2019-05-06-Preview for the service swagger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants