Add new Automation API version #7603
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure-sdk-for-net
|
|
Can one of the admins verify this patch? |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
xseeseesee
added
the
WaitForARMFeedback
anthony-c-martin
approved these changes
Oct 24, 2019
anthony-c-martin
added
ARMSignedOff
|
@vrdmr please review this PR as the code owner |
vrdmr
approved these changes
Oct 25, 2019
There was a problem hiding this comment.
Minor comment. Everything else LGTM.
Just to make sure that https://github.com/Azure/azure-resource-manager-schemas gets updated. (It's been couple of years I've worked on this now and don't know the current proces)
| ], | ||
| "description": "Return list of software update configuration runs.", | ||
| "externalDocs": { | ||
| "url": "http://aka.ms/azureautomationsdk/softwareupdateconfigurationoperations" |
There was a problem hiding this comment.
You might want to verify these URLs. This one does not work.
|
@katherinebecker can you verify this url as per minor comment? |
|
get confirmed from @katherinebecker , hold this PR until it's fixed. |
|
@katherinebecker any progress? |
|
@xccc-msft, I've fixed the URLs. We still need to wait on merging this PR because the new API version is not available yet. We are waiting on a deployment. |
Automation for azure-sdk-for-pythonA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
|
@katherinebecker can we merge this first and open new PR when your new API version available? |
|
@xccc-msft, my understanding was that our documentation would be updated automatically after merging. Since we don't want the documentation showing an API version that isn't available yet, we'd need to wait before merging the PR. Is this correct? |
xseeseesee
added
the
DoNotMerge
|
@katherinebecker I'm not expert on this. Let's hold this PR until your side is ready. For now, I just add label of 'DoNotMerge' for the onhold status. |
|
Hi @katherinebecker， Is your service ready? as this PR is existing for a long time, can you close it? |
Copy the swagger specs for software update configurations, software update configuration runs, and software update configuration machines runs from the 2017-05-15-preview API version to a folder for the new 2019-06-01 API version. This will make it easier to review the changes for the new API version.
Update the API version to 2019-06-01. Add a link to the next page of results in the response for getting the list of software update configurations. Tag the list responses as pageable for software update configurations, software update configuration runs, and software update configuration machine runs.
Fix descriptions to use consistent capitalization and punctuation. Fix grammar errors.
The schema used for the response for listing software update configurations did not match up with the examples or the actual response from the API. This updates the schema to match the examples and the API.
Fix spelling mistake. Fix mistake in the example for creating a software update configuration so that it now matches the schema and actual API.
Update external docs links to point to the current documentation
katherinebecker
force-pushed
the
katwill/automationApiVersionUpdate
branch
from
00d15a1
to
a388aba
Compare
[Staging] Swagger Validation Report
️✔️ |
|
No commit pushedDate could be found for PR 7603 in repo Azure/azure-rest-api-specs |
assing
approved these changes
Jul 31, 2020
|
@akning-ms, this PR can be merged now |
assing
reviewed
Aug 13, 2020
| } | ||
| ], | ||
| "nextLink": "https://management.azure.com:443/subscriptions/51766542-3ed7-4a72-a187-0c8ab644ddab/resourceGroups/mygroup/providers/Microsoft.Automation/automationAccounts/myaccount/softwareUpdateConfigurationRuns?api-version=2019-06-01&_=1508725900015&$skip=100" | ||
| } |
There was a problem hiding this comment.
Resource name should be softwareUpdateConfigurationMachineRuns
assing
reviewed
Aug 13, 2020
| } | ||
| } | ||
| ], | ||
| "nextLink": "https://management.azure.com:443/subscriptions/51766542-3ed7-4a72-a187-0c8ab644ddab/resourceGroups/mygroup/providers/Microsoft.Automation/automationAccounts/myaccount/softwareUpdateConfigurationRuns?api-version=2019-06-01&_=1508725900015&$skip=100" |
There was a problem hiding this comment.
Resource name should be softwareUpdateConfigurationMachineRuns
|
Azure Pipelines successfully started running 1 pipeline(s). |
Trenton Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python
|
azure-sdk-for-go
|
azure-sdk-for-js
|
azure-sdk-for-java
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
This was referenced Oct 19, 2020
|
Close this now as no update action taken recently. Please feel free to reopen if you still need to work on this PR. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new GA Automation API version for Update Management resources. The new API version adds a paged response when listing software update configurations. It also includes fixes to the description text and the response schema for listing software update configurations.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.