[Re-open of #6422] Introducing subAssessments type (Microsoft.Security provider) #7101

himarkov · 2019-09-02T15:02:14Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-sdkautomation · 2019-09-02T15:02:17Z

In Testing, Please Ignore

[Logs] (Generated from edb4eee, Iteration 19)

.NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]

Microsoft.Azure.Management.SecurityCenter [Logs] [Instructions]
- Microsoft.Azure.Management.SecurityCenter.1.0.0.nupkg
- Microsoft.Azure.Management.SecurityCenter.1.0.0.snupkg

Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]

preview/security/mgmt/v1.0 [Logs]
preview/security/mgmt/v2.0 [Logs]
preview/security/mgmt/v3.0 [Logs]

Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]

azure-mgmt-security [Logs] [Instructions] [Generation PR]
- azure-mgmt-security-0.3.0.zip
- azure_mgmt_security-0.3.0-py2.py3-none-any.whl

JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]

@azure/arm-security [Logs] [Instructions]
- azure-arm-security-1.2.0.tgz

AutorestCI · 2019-09-02T15:03:45Z

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#7377

AutorestCI · 2019-09-02T15:05:40Z

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#5863

azuresdkci · 2019-09-02T15:07:34Z

Can one of the admins verify this patch?

himarkov · 2019-09-02T15:08:31Z

Reopen of signed off PR (with paths change)
#6422

ArcturusZhang

When will this pr be ready?

.../security/resource-manager/Microsoft.Security/preview/2019-01-01-preview/subAssessments.json

himarkov · 2019-09-11T15:11:09Z

Hi, this pr is ready on our end

himarkov · 2019-09-11T17:56:01Z

Hi, ARG has specifically asked this, as otherwise, upon sync, they will be needed to query per each subscription + assessment id combo, which makes the query scale pretty huge for both our side and their. Regarding the type, it remains Microsoft.security/assessments/subassessments for both APIs. This has been tried. Regarding the manifest pr – if im not wrong, it doesn’t has the type represented in it, but only the name and route. Have I missed something? Thanks, Hila From: Chris Eggert <notifications@github.com> Sent: Wednesday, September 11, 2019 7:52 PM To: Azure/azure-rest-api-specs <azure-rest-api-specs@noreply.github.com> Cc: Hila Markovitch <Hila.Markovitch@microsoft.com>; Author <author@noreply.github.com> Subject: Re: [Azure/azure-rest-api-specs] [Re-open of #6422] Introducing subAssessments type (Microsoft.Security provider) (#7101) @pilor commented on this pull request.

________________________________ In specification/security/resource-manager/Microsoft.Security/preview/2019-01-01-preview/subAssessments.json<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F7101%23discussion_r323349961&data=02%7C01%7CHila.Markovitch%40microsoft.com%7C3520a14fcbba401d35f208d736d85aec%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637038175222880986&sdata=I3E2eqrTAtfBZtz5J4kH6ZWh0vNSWbtaiHEr0VVIqlw%3D&reserved=0>:

+ "security": [{

+ "azure_auth": ["user_impersonation"] + }], + "securityDefinitions": { + "azure_auth": { + "type": "oauth2", + "authorizationUrl": "https://login.microsoftonline.com/common/oauth2/authorize", + "flow": "implicit", + "description": "Azure Active Directory OAuth2 Flow", + "scopes": { + "user_impersonation": "impersonate your user account" + } + } + }, + "paths": { + "/{scope}/providers/Microsoft.Security/subAssessments": { Have you tried this in dogfood? How will you represent this type in your manifest? as assessments/subAssessments and just "subAssessments"? Currently your manifest PR has it just listed as a "subAssessments" resourceType which seems a bit misleading. RBAC also becomes an issue when its reprsented as two different actions. Did ARG specifically ask for this? Subscription level GETs are typically only used for top-level resources. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F7101%3Femail_source%3Dnotifications%26email_token%3DALJQAEC42XC6GOH523DLKWLQJEO2XA5CNFSM4IS6KP6KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCENDUBY%23discussion_r323349961&data=02%7C01%7CHila.Markovitch%40microsoft.com%7C3520a14fcbba401d35f208d736d85aec%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637038175222885975&sdata=sjEKv2SFiiQJsTcToxSD06O9m%2BIs8wNUVhnuh0tpGnY%3D&reserved=0>, or mute the thread<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALJQAEEMOUX2GDYDLIJWDXLQJEO2XANCNFSM4IS6KP6A&data=02%7C01%7CHila.Markovitch%40microsoft.com%7C3520a14fcbba401d35f208d736d85aec%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637038175222890965&sdata=vFN9jTeeghpYF8dtwienU3%2B87zY7ULDO5r4i76IkV04%3D&reserved=0>.

ArcturusZhang · 2019-09-20T02:01:38Z

Hi @himarkov I approved these changes for now. When this is ready to merge, please let me know. If this is not going to get ready for short, I suggest to close this pr, and open a new one when this is ready to merge

himarkov · 2019-09-24T20:32:27Z

Hi, this is ready to be merged.
Thanks.

ArcturusZhang · 2019-09-26T07:49:47Z

Hi, this is ready to be merged.
Thanks.

Merged

Sorted and removed duplicates as well

sub assessment subscription level API

cb6aba5

azuresdkci assigned ArcturusZhang Sep 2, 2019

azuresdkci requested a review from ArcturusZhang September 2, 2019 15:03

AutorestCI mentioned this pull request Sep 2, 2019

[AutoPR security/resource-manager] [DoNotMerge] Introducing subAssessments type (Microsoft.Security provider) Azure/azure-sdk-for-python#7037

Closed

sub assessment subscription level API new line

48e185a

openapi-sdkautomation bot mentioned this pull request Sep 2, 2019

[AutoPR Microsoft.Azure.Management.SecurityCenter] [DoNotMerge] Introducing subAssessments type (Microsoft.Security provider) test-repo-billy/azure-sdk-for-net#171

Closed

himarkov added 2 commits September 2, 2019 18:11

sub assessment subscription level API new line 2 more files

afcf5f1

sub assessment subscription level API removed redondent param

a6994fc

himarkov changed the title ~~[DoNotMerge] Introducing subAssessments type (Microsoft.Security provider)~~ [DoNotMerge] [Re-open of #6422] Introducing subAssessments type (Microsoft.Security provider) Sep 2, 2019

himarkov added 2 commits September 2, 2019 18:45

sub assessment subscription level API read me

6630392

sub assessment subscription level API read me

a754ab9

AutorestCI mentioned this pull request Sep 3, 2019

[AutoPR security/resource-manager] [DoNotMerge] [Re-open of #6422] Introducing subAssessments type (Microsoft.Security provider) Azure/azure-sdk-for-go#5685

Closed

sub assessment subscription level API single fix

ad09bd1

ArcturusZhang requested changes Sep 5, 2019

View reviewed changes

himarkov changed the title ~~[DoNotMerge] [Re-open of #6422] Introducing subAssessments type (Microsoft.Security provider)~~ [Re-open of #6422] Introducing subAssessments type (Microsoft.Security provider) Sep 10, 2019

Added assessment scope API

4c16fa2

himarkov force-pushed the master branch from 98bdd0b to 4c16fa2 Compare September 10, 2019 13:21

Merge branch 'master' into master

e984f54

chlahav added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required DoNotMerge <valid label in PR review process> use to hold merge after approval labels Sep 10, 2019

update operation id on list all

edb4eee

pilor reviewed Sep 10, 2019

View reviewed changes

.../security/resource-manager/Microsoft.Security/preview/2019-01-01-preview/subAssessments.json Show resolved Hide resolved

pilor added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Sep 10, 2019

pilor removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Sep 11, 2019

pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 11, 2019

pilor approved these changes Sep 11, 2019

View reviewed changes

ArcturusZhang approved these changes Sep 20, 2019

View reviewed changes

ArcturusZhang removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Sep 26, 2019

ArcturusZhang merged commit 87bf8b3 into Azure:master Sep 26, 2019

nschonni added a commit to nschonni/azure-rest-api-specs that referenced this pull request Oct 11, 2019

fix: Spelling failures from Azure#7101

ad5e3ae

Sorted and removed duplicates as well

nschonni mentioned this pull request Oct 11, 2019

[DoNotMerge] Introducing subAssessments type (Microsoft.Security provider) #6422

Closed

5 tasks

yungezz pushed a commit that referenced this pull request Oct 11, 2019

fix: Spelling failures from #7101 (#7465)

a0f6ad3

Sorted and removed duplicates as well

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Re-open of #6422] Introducing subAssessments type (Microsoft.Security provider) #7101

[Re-open of #6422] Introducing subAssessments type (Microsoft.Security provider) #7101

himarkov commented Sep 2, 2019 •

edited

Loading

openapi-sdkautomation bot commented Sep 2, 2019 •

edited

Loading

AutorestCI commented Sep 2, 2019 •

edited

Loading

AutorestCI commented Sep 2, 2019 •

edited

Loading

azuresdkci commented Sep 2, 2019

himarkov commented Sep 2, 2019

ArcturusZhang left a comment

himarkov commented Sep 11, 2019

himarkov commented Sep 11, 2019 via email

ArcturusZhang commented Sep 20, 2019

himarkov commented Sep 24, 2019

ArcturusZhang commented Sep 26, 2019

[Re-open of #6422] Introducing subAssessments type (Microsoft.Security provider) #7101

[Re-open of #6422] Introducing subAssessments type (Microsoft.Security provider) #7101

Conversation

himarkov commented Sep 2, 2019 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

openapi-sdkautomation bot commented Sep 2, 2019 • edited Loading

In Testing, Please Ignore

[Logs] (Generated from edb4eee, Iteration 19)

AutorestCI commented Sep 2, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Sep 2, 2019 • edited Loading

Automation for azure-sdk-for-go

azuresdkci commented Sep 2, 2019

himarkov commented Sep 2, 2019

ArcturusZhang left a comment

Choose a reason for hiding this comment

himarkov commented Sep 11, 2019

himarkov commented Sep 11, 2019 via email

ArcturusZhang commented Sep 20, 2019

himarkov commented Sep 24, 2019

ArcturusZhang commented Sep 26, 2019

himarkov commented Sep 2, 2019 •

edited

Loading

openapi-sdkautomation bot commented Sep 2, 2019 •

edited

Loading

AutorestCI commented Sep 2, 2019 •

edited

Loading

AutorestCI commented Sep 2, 2019 •

edited

Loading