Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed next link in automation #6807

Merged
merged 1 commit into from
Jul 31, 2019
Merged

fixed next link in automation #6807

merged 1 commit into from
Jul 31, 2019

Conversation

zikalino
Copy link

This PR is fixing a problem with nextLink.

According to the guidelines below, nextLink should never be empty string.
I am fixing examples in specs first and in the same time this should be escalated with service teams.
If the service returns empty string I will escalate this accordingly.

Please note that not following this guideline may result in unpredictable behaviour of client implementations.

https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/resource-api-reference.md#get-resource

If a resource provider does not support paging, it should return the same body (JSON object with "value" property) but omit nextLink entirely (or set to null, not empty string) for future compatibility.

@AutorestCI
Copy link

AutorestCI commented Jul 31, 2019

Automation for azure-sdk-for-python

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Jul 31, 2019

Automation for azure-sdk-for-go

Unable to detect any generation context from this PR.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 31, 2019

SDK Automation [Logs] (Generated from 6cd94de, Iteration 1)

In-Progress Python: Azure/azure-sdk-for-python [Logs]
  • Package generation in progress.
In-Progress Go: test-repo-billy/azure-sdk-for-go [Logs]
  • Package generation in progress.
In-Progress JavaScript: Azure/azure-sdk-for-js [Logs]
  • Package generation in progress.
In-Progress Ruby: Azure/azure-sdk-for-ruby [Logs]
  • Package generation in progress.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@jhendrixMSFT jhendrixMSFT merged commit 1650794 into master Jul 31, 2019
@JackTn JackTn deleted the next-link-automation branch August 9, 2021 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants