Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.Capacity to add version preview/2019-04-01 #6731

Merged
merged 2 commits into from
Aug 1, 2019
Merged

[Hub Generated] Review request for Microsoft.Capacity to add version preview/2019-04-01 #6731

merged 2 commits into from
Aug 1, 2019

Conversation

gautam714
Copy link
Contributor

@gautam714 gautam714 commented Jul 26, 2019 •
edited
Loading

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 26, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from e886daf, Iteration 7)

Succeeded Python: Azure/azure-sdk-for-python [Logs] [Diff]
Warning Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Failed JavaScript: Azure/azure-sdk-for-js [Logs] [Diff]

@AutorestCI AutorestCI mentioned this pull request Jul 26, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jul 26, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#6303

@azuresdkci azuresdkci requested a review from Juliehzl July 26, 2019 00:08
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Jul 26, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jul 26, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5401

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Jul 26, 2019
Merged
@nschonni
Copy link
Contributor

Model validation issues fixed in #6732. If you pull those fixes in here, let me know an I'll close that one

@gautam714
Copy link
Contributor Author

Model validation issues fixed in #6732. If you pull those fixes in here, let me know an I'll close that one

I have pulled the fix. All validations are passing now. Could you please approve and merge?

@nschonni nschonni mentioned this pull request Jul 26, 2019
Closed
@nschonni
Copy link
Contributor

Sorry, i'm not an MS employee. I think there are instructions on the PR template for escalating internally

@daviwil
Copy link
Contributor

daviwil commented Jul 26, 2019

@OpenAPIBot sdkautomation rebuild

@Juliehzl Juliehzl added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 27, 2019
@Juliehzl
Copy link
Contributor

@NullMDR Can you have a look at SDK problem?

@PhoenixHe-NV
Copy link
Contributor

@Juliehzl This should be a bug in sdk automation. I'll check it later.

@PhoenixHe-NV
Copy link
Contributor

@OpenAPIBot sdkautomation rebuild

@gautam714
Copy link
Contributor Author

Can somebody please take a look from ARM side? @Juliehzl : please assign someone.

majastrz
majastrz reviewed Jul 31, 2019
View reviewed changes
...cation/reservations/resource-manager/Microsoft.Capacity/preview/2019-04-01/reservations.json
@@ -1012,6 +1012,9 @@
},
"renewProperties": {
"$ref": "#/definitions/RenewPropertiesResponse"
},
"term": {
"$ref": "#/definitions/ReservationTerm"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ReservationTerm [](start = 33, length = 15)

You are adding a new property non-readonly property to a stable API version. This is considered a breaking change. You should introduce this change in a new API version.

@majastrz majastrz added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jul 31, 2019
majastrz
majastrz requested changes Jul 31, 2019
View reviewed changes
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are adding a new property non-readonly property to a stable API version. This is considered a breaking change. You should introduce this change in a new API version.

@majastrz
Copy link
Member

You are adding a new property non-readonly property to a stable API version. This is considered a breaking change. You should introduce this change in a new API version.

When I was tracing usages through in the Swagger I mistook response for the body of a PUT, which led to me to conclude that it wasn’t read-only. This was also confirmed by the RP owners.

@majastrz majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 31, 2019
majastrz
majastrz approved these changes Jul 31, 2019
View reviewed changes
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed off from ARM side.

@Juliehzl Juliehzl merged commit c9812a1 into Azure:master Aug 1, 2019
@gautam714 gautam714 mentioned this pull request Aug 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Juliehzl Juliehzl Juliehzl approved these changes

@majastrz majastrz majastrz approved these changes

Assignees

@Juliehzl Juliehzl

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@gautam714 @AutorestCI @azuresdkci @nschonni @daviwil @Juliehzl @PhoenixHe-NV @majastrz