Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SRP] Add new API ListBlobServices #6657

Merged
merged 12 commits into from
Jul 29, 2019
Merged

Conversation

zfchen95
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 17, 2019

SDK Automation [Logs] (Generated from 2e78b5c, Iteration 8)

Failed Python: Azure/azure-sdk-for-python [Logs]
  • No packages generated.
Failed Java: Azure/azure-sdk-for-java [Logs]
  • No packages generated.
Failed Go: test-repo-billy/azure-sdk-for-go [Logs]
  • No packages generated.
Failed JavaScript: Azure/azure-sdk-for-js [Logs]
  • No packages generated.
Succeeded Ruby: Azure/azure-sdk-for-ruby [Logs] [Diff]

@AutorestCI
Copy link

AutorestCI commented Jul 17, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5377

@AutorestCI
Copy link

AutorestCI commented Jul 17, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#6382

@AutorestCI
Copy link

AutorestCI commented Jul 17, 2019

Automation for azure-sdk-for-java

Encountered a Subprocess error: (azure-sdk-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmp8ek98edm/rest/specification/storage/resource-manager/readme.md', '--azure-libraries-for-java-folder=/tmp/tmp8ek98edm/sdk', '--java', '--multiapi', '--use=@microsoft.azure/autorest.java@2.1.85', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4383/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4383)
   Including configuration file 'file:///tmp/tmp8ek98edm/rest/specification/storage/resource-manager/readme.java.md'
   Loading AutoRest extension '@microsoft.azure/autorest.java' (2.1.85->2.1.85)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2019-04"} .
   Including configuration file 'file:///tmp/tmp8ek98edm/rest/specification/storage/resource-manager/readme.java.md'
ERROR: Schema violation: Data does not match any schemas from 'oneOf'
    - file:///tmp/tmp8ek98edm/rest/specification/storage/resource-manager/Microsoft.Storage/stable/2019-04-01/blob.json:26:10 ($.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Storage/storageAccounts/{accountName}/blobServices"].get["x-ms-examples"].ListBlobServices)
FATAL: swagger-document/individual/schema-validator - FAILED
FATAL: Error: [OperationAbortedException] Error occurred. Exiting.
Process() cancelled due to exception : [OperationAbortedException] Error occurred. Exiting.
Failure during batch task - {"tag":"package-2019-04"} -- false.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@zfchen95
Copy link
Contributor Author

@yungezz Sorry I have to close the previous one because I added too many commits after the git pull rebase. I saw some of the tests are failed for this PR. But I couldn't find out the issue from the error log. Was it because I added a new API that breaks the existing sdk? Any other issue you would notice?

@zfchen95
Copy link
Contributor Author

The PR was signed off by ARM team in the private repo https://github.com/Azure/azure-rest-api-specs-pr/pull/777

"tags": [
"BlobService"
],
"operationId": "BlobServices_List",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add "x-ms-pageable": { "nextLinkName": null } extension to the list operation. It is also done for many other operations like StorageAccounts_List

@amarzavery
Copy link
Contributor

Please fix the CI failures for model validation and lint diff

@amarzavery amarzavery merged commit c2ff015 into Azure:master Jul 29, 2019
leni-msft pushed a commit to leni-msft/azure-rest-api-specs that referenced this pull request May 13, 2022
* Db2 Provider Properties

* aletered example

* minor

* adressed comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants