Michal dev security microsoft.security 2017 08 01 preview #6563

MichalHel · 2019-07-07T12:45:15Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

…on RP

…ew' of https://github.com/MichalHel/azure-rest-api-specs into michal-dev-security-Microsoft.Security-2017-08-01-preview

…olution Manager RP

…n" to "name" in the IOT Solution Manager RP

openapi-sdkautomation · 2019-07-07T12:45:17Z

SDK Automation [Logs] (Generated from 0e0525c, Iteration 15)

Go: Azure/azure-sdk-for-go [Logs] [Diff]

preview/security/mgmt/v1.0 [Logs]
preview/security/mgmt/v2.0 [Logs]
preview/security/mgmt/v3.0 [Logs] [Instructions]
- preview.security.mgmt.v3.0.zip

Python: Azure/azure-sdk-for-python [Logs] [Diff]

azure-mgmt-security [Logs] [Instructions]
- azure-mgmt-security-0.2.0.zip
- azure_mgmt_security-0.2.0-py2.py3-none-any.whl

JavaScript: Azure/azure-sdk-for-js [Logs] [Diff]

@azure/arm-security [Logs] [Instructions]
- azure-arm-security-1.2.0.tgz

AutorestCI · 2019-07-07T12:46:14Z

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#5709

AutorestCI · 2019-07-07T12:46:22Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5352

AutorestCI · 2019-07-07T12:46:52Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

azuresdkci · 2019-07-07T14:00:17Z

Can one of the admins verify this patch?

nschonni · 2019-07-07T15:21:16Z

...view/2017-08-01-preview/examples/IoTSecuritySolutions/CreateIoTSecuritySolution_example.json

+          "recommendationsConfiguration": [
+            {
+              "recommendationType": "IoT_ACRAuthentication",
+              "name": "Service Prinicpal Not Used with ACR",


Suggested change

"name": "Service Prinicpal Not Used with ACR",

"name": "Service Principal Not Used with ACR",

nschonni · 2019-07-07T15:22:09Z

...ity/resource-manager/Microsoft.Security/preview/2017-08-01-preview/iotSecuritySolutions.json

-                "value": "EnableDiagnosticsLog",
-                "description": "Enable logs and retain them for up to a year. Retaining logs enables you to recreate activity trails for investigation purposes when a security incident occurs or your network is compromised."
+                "value": "IoT_VulnerableTLSCipherSuite",
+                "description": "Unsecure TLS configurations detected. Immediate upgrade recommended."


Suggested change

"description": "Unsecure TLS configurations detected. Immediate upgrade recommended."

"description": "Insecure TLS configurations detected. Immediate upgrade recommended."

nschonni

Prinicpal -> Principal

...preview/2017-08-01-preview/examples/IoTSecuritySolutions/GetIoTSecuritySolution_example.json

nschonni · 2019-07-08T06:55:25Z

...-preview/examples/IoTSecuritySolutions/GetIoTSecuritySolutionsListByIotHubAndRg_example.json

-                  "description": "Open Ports on device",
-                  "status": "TurnedOff"
+                  "recommendationType": "IoT_ACRAuthentication",
+                  "name": "Service Prinicpal Not Used with ACR",


Suggested change

"name": "Service Prinicpal Not Used with ACR",

"name": "Service Principal Not Used with ACR",

...08-01-preview/examples/IoTSecuritySolutions/GetIoTSecuritySolutionsListByIotHub_example.json

nschonni · 2019-07-08T06:55:54Z

...017-08-01-preview/examples/IoTSecuritySolutions/GetIoTSecuritySolutionsListByRg_example.json

-                  "description": "Open Ports on device",
-                  "status": "TurnedOff"
+                  "recommendationType": "IoT_ACRAuthentication",
+                  "name": "Service Prinicpal Not Used with ACR",


Suggested change

"name": "Service Prinicpal Not Used with ACR",

"name": "Service Principal Not Used with ACR",

nschonni · 2019-07-08T06:56:05Z

...ew/2017-08-01-preview/examples/IoTSecuritySolutions/GetIoTSecuritySolutionsList_example.json

+              "recommendationsConfiguration": [
+                {
+                  "recommendationType": "IoT_ACRAuthentication",
+                  "name": "Service Prinicpal Not Used with ACR",


Suggested change

"name": "Service Prinicpal Not Used with ACR",

"name": "Service Principal Not Used with ACR",

nschonni · 2019-07-08T06:56:25Z

...ew/2017-08-01-preview/examples/IoTSecuritySolutions/GetIoTSecuritySolutionsList_example.json

-                  "description": "Open Ports on device",
-                  "status": "TurnedOff"
+                  "recommendationType": "IoT_ACRAuthentication",
+                  "name": "Service Prinicpal Not Used with ACR",


Suggested change

"name": "Service Prinicpal Not Used with ACR",

"name": "Service Principal Not Used with ACR",

nschonni · 2019-07-08T06:56:46Z

...view/2017-08-01-preview/examples/IoTSecuritySolutions/UpdateIoTSecuritySolution_example.json

-              "recommendationType": "OpenPortsOnDevice",
-              "status": "TurnedOff"
+              "recommendationType": "IoT_ACRAuthentication",
+              "name": "Service Prinicpal Not Used with ACR",


Suggested change

"name": "Service Prinicpal Not Used with ACR",

"name": "Service Principal Not Used with ACR",

...ity/resource-manager/Microsoft.Security/preview/2017-08-01-preview/iotSecuritySolutions.json

...view/2017-08-01-preview/examples/IoTSecuritySolutions/CreateIoTSecuritySolution_example.json

…view/2017-08-01-preview/iotSecuritySolutions.json Co-Authored-By: Nick Schonning <nschonni@gmail.com>

…view/2017-08-01-preview/examples/IoTSecuritySolutions/CreateIoTSecuritySolution_example.json Co-Authored-By: Nick Schonning <nschonni@gmail.com>

…ew' of https://github.com/MichalHel/azure-rest-api-specs into michal-dev-security-Microsoft.Security-2017-08-01-preview

…n json

MichalHel · 2019-07-11T09:45:45Z

Can someone please approve this PR

…7-08-01-preview

MichalHel · 2019-07-24T11:40:55Z

Can someone please inform me why the PR is not approved yet??

anthony-c-martin · 2019-07-25T22:57:18Z

...ity/resource-manager/Microsoft.Security/preview/2017-08-01-preview/iotSecuritySolutions.json

-            "DenyDefaultIpPolicy",
-            "TooLargeIPRange",
-            "EnableDiagnosticsLog"
+            "IoT_ACRAuthentication",


What's the motivation behind prefixing with "IoT_"?

...ity/resource-manager/Microsoft.Security/preview/2017-08-01-preview/iotSecuritySolutions.json

anthony-c-martin · 2019-07-25T23:00:01Z

...ity/resource-manager/Microsoft.Security/preview/2017-08-01-preview/iotSecuritySolutions.json

+            "IoT_EdgeLoggingOptions",
+            "IoT_InconsistentModuleSettings",
+            "IoT_InstallAgent",
+            "IoT_IPFilter_DenyAll",


I'm not completely sure that "_" is a permissible value in each of the languages the swagger is used to generate. Might be easier to go with "IPFilterDenyAll" and "IPFilterPermissiveRule"

This was reviewed with our PMs & technical writers.
This field contains the type of the recommendation which is a code that the customer can use in order to view specific recommendation. there is also fields with the description that explains the customer what each recommendation means.
it should be the same value as we generates internally in our system and changing it is a lot of work.
All swagger tests were passed.

Makes sense. So I take it you've never published an SDK with these old values? @nschonni is reviewing from the SDK side, so if he's good with it then it's fine by me.

@antmarti-microsoft sorry, I'm actually not an MS employee 😉

Ah sorry, my bad! In that case @shahabhijeet it looks like you've been assigned to this PR - please could you take a look?

hagba · 2019-07-26T16:46:25Z

When can it be merged? I want to create a PR to publish it as stable ASAP. EDIT: removing internal emails

anthony-c-martin

We've had confirmation that SDKs haven't been published yet, so the breaking enum changes should be fine. Signing off for ARM.

...ity/resource-manager/Microsoft.Security/preview/2017-08-01-preview/iotSecuritySolutions.json

MichalHel and others added 8 commits June 17, 2019 08:48

changed enum name ruleType to RecommendationType in IoTSecuritySoluti…

8f04d58

…on RP

changed examples of IOT security solution RP

92b9586

nullable userDefinedResources query/subs

249a0fb

fixing the Security Solution RP

0ea94e2

Merge branch 'michal-dev-security-Microsoft.Security-2017-08-01-previ…

b4c9282

…ew' of https://github.com/MichalHel/azure-rest-api-specs into michal-dev-security-Microsoft.Security-2017-08-01-preview

Changed the enums of the Recommendations type and status of the IOT S…

f7ae816

…olution Manager RP

changed property of the recommendation configuration form "descriptio…

3ed7591

…n" to "name" in the IOT Solution Manager RP

Fixed examples of IOT Security Manager RP

ade263a

MichalHel added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jul 7, 2019

azuresdkci assigned shahabhijeet Jul 7, 2019

azuresdkci requested a review from shahabhijeet July 7, 2019 12:46

Fixed error in schema related to IoT security Solution RP

1071b32

fixed enums in IoT Security solution RP

3a1d3ee

This was referenced Jul 7, 2019

[AutoPR security/resource-manager] Michal dev security microsoft.security 2017 08 01 preview Azure/azure-sdk-for-python#6250

Closed

[AutoPR security/resource-manager] Michal dev security microsoft.security 2017 08 01 preview Azure/azure-sdk-for-go#5204

Closed

nschonni reviewed Jul 7, 2019

View reviewed changes

fixed spelling mistakes in IoT solution Manager RP files

19a8d93

nschonni reviewed Jul 8, 2019

View reviewed changes

MichalHel and others added 6 commits July 8, 2019 10:01

Update specification/security/resource-manager/Microsoft.Security/pre…

4809c78

…view/2017-08-01-preview/iotSecuritySolutions.json Co-Authored-By: Nick Schonning <nschonni@gmail.com>

Update specification/security/resource-manager/Microsoft.Security/pre…

d66d78b

…view/2017-08-01-preview/examples/IoTSecuritySolutions/CreateIoTSecuritySolution_example.json Co-Authored-By: Nick Schonning <nschonni@gmail.com>

Fixed spelling mistakes in IoT solution manager RP

5d2345b

Merge branch 'michal-dev-security-Microsoft.Security-2017-08-01-previ…

6e9b53b

…ew' of https://github.com/MichalHel/azure-rest-api-specs into michal-dev-security-Microsoft.Security-2017-08-01-preview

Fixed spelling mistakes in IoT solution Manager RP

6b6ce4f

removed unprintable characters and tabs from the IoT Security Solutio…

4b6c2b7

…n json

KrisBash added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 16, 2019

MichalHel removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jul 17, 2019

Merge branch 'master' into michal-dev-security-Microsoft.Security-201…

635daec

…7-08-01-preview

AutorestCI mentioned this pull request Jul 17, 2019

[AutoPR security/resource-manager] Michal dev security microsoft.security 2017 08 01 preview Azure/azure-sdk-for-go#5271

Closed

Merge branch 'master' into michal-dev-security-Microsoft.Security-201…

0e0525c

…7-08-01-preview

AutorestCI mentioned this pull request Jul 18, 2019

[AutoPR security/resource-manager] Michal dev security microsoft.security 2017 08 01 preview Azure/azure-sdk-for-go#5293

Merged

MichalHel requested a review from ravbhatnagar July 24, 2019 11:42

anthony-c-martin requested changes Jul 25, 2019

View reviewed changes

anthony-c-martin added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 25, 2019

anthony-c-martin approved these changes Jul 26, 2019

View reviewed changes

shahabhijeet requested changes Jul 26, 2019

View reviewed changes

...ity/resource-manager/Microsoft.Security/preview/2017-08-01-preview/iotSecuritySolutions.json Show resolved Hide resolved

shahabhijeet approved these changes Jul 26, 2019

View reviewed changes

shahabhijeet merged commit bb46e5b into Azure:master Jul 26, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Michal dev security microsoft.security 2017 08 01 preview #6563

Michal dev security microsoft.security 2017 08 01 preview #6563

MichalHel commented Jul 7, 2019 •

edited by hagba

Loading

openapi-sdkautomation bot commented Jul 7, 2019 •

edited

Loading

AutorestCI commented Jul 7, 2019 •

edited

Loading

AutorestCI commented Jul 7, 2019 •

edited

Loading

AutorestCI commented Jul 7, 2019 •

edited

Loading

azuresdkci commented Jul 7, 2019

nschonni Jul 7, 2019

nschonni Jul 7, 2019

nschonni left a comment

nschonni Jul 8, 2019

nschonni Jul 8, 2019

nschonni Jul 8, 2019

nschonni Jul 8, 2019

nschonni Jul 8, 2019

MichalHel commented Jul 11, 2019

MichalHel commented Jul 24, 2019

anthony-c-martin Jul 25, 2019

anthony-c-martin Jul 25, 2019

hagba Jul 26, 2019

anthony-c-martin Jul 26, 2019

nschonni Jul 26, 2019

anthony-c-martin Jul 26, 2019

hagba commented Jul 26, 2019 via email •

edited by anthony-c-martin

Loading

anthony-c-martin left a comment

	"name": "Service Prinicpal Not Used with ACR",
	"name": "Service Principal Not Used with ACR",

	"description": "Unsecure TLS configurations detected. Immediate upgrade recommended."
	"description": "Insecure TLS configurations detected. Immediate upgrade recommended."

Michal dev security microsoft.security 2017 08 01 preview #6563

Michal dev security microsoft.security 2017 08 01 preview #6563

Conversation

MichalHel commented Jul 7, 2019 • edited by hagba Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

openapi-sdkautomation bot commented Jul 7, 2019 • edited Loading

SDK Automation [Logs] (Generated from 0e0525c, Iteration 15)

AutorestCI commented Jul 7, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Jul 7, 2019 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Jul 7, 2019 • edited Loading

Automation for azure-sdk-for-java

azuresdkci commented Jul 7, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nschonni left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MichalHel commented Jul 11, 2019

MichalHel commented Jul 24, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hagba commented Jul 26, 2019 via email • edited by anthony-c-martin Loading

anthony-c-martin left a comment

Choose a reason for hiding this comment

MichalHel commented Jul 7, 2019 •

edited by hagba

Loading

openapi-sdkautomation bot commented Jul 7, 2019 •

edited

Loading

AutorestCI commented Jul 7, 2019 •

edited

Loading

AutorestCI commented Jul 7, 2019 •

edited

Loading

AutorestCI commented Jul 7, 2019 •

edited

Loading

hagba commented Jul 26, 2019 via email •

edited by anthony-c-martin

Loading