Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Microsoft.Security applicationWhitelistings API #6553

Merged
merged 20 commits into from
Jul 16, 2019
Merged

Add Microsoft.Security applicationWhitelistings API #6553

merged 20 commits into from
Jul 16, 2019

Conversation

erelh
Copy link
Contributor

@erelh erelh commented Jul 4, 2019 •
edited
Loading

initial commit

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 4, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from 6307743, Iteration 23)

Succeeded Go: Azure/azure-sdk-for-go [Logs] [Diff]
Succeeded Python: Azure/azure-sdk-for-python [Logs] [Diff]
Succeeded JavaScript: Azure/azure-sdk-for-js [Logs] [Diff]

@msftclas
Copy link

msftclas commented Jul 4, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

@azuresdkci azuresdkci requested a review from raych1 July 4, 2019 13:30
@AutorestCI
Copy link

AutorestCI commented Jul 4, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5709

@AutorestCI
Copy link

AutorestCI commented Jul 4, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Jul 4, 2019 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#5176

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@erelh
Copy link
Contributor Author

erelh commented Jul 4, 2019

API already exists in ARM , but is not documented

@raych1
Copy link
Contributor

raych1 commented Jul 5, 2019

It needs to update readme to add this newly added spec.

raych1
raych1 requested changes Jul 5, 2019
View reviewed changes
Copy link
Contributor

@raych1 raych1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve my comments and the CI failures.

@erelh
Copy link
Contributor Author

erelh commented Jul 7, 2019

hi
i fixed some errors, but i dont understand the current error messages in the semantic validation, can someone please review and assist what is invalid ?
thanks!

@raych1 raych1 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 8, 2019
This was referenced Jul 9, 2019
Merged
Closed
@raych1
Copy link
Contributor

raych1 commented Jul 9, 2019

@amarzavery , can you help explain the semantics errors?

@erelh
Copy link
Contributor Author

erelh commented Jul 9, 2019 •
edited
Loading

@raych1

@amarzavery , can you help explain the semantics errors?

Hi,

The CI is only failing on SpellCheck because the API is "applicationWhitelistings" and "whitelistings" is not a word

The API is already in Production and is GA so can you please give us a hallpass on this validation, and ARM Feedback is therefore not needed

Thanks

@nschonni
Copy link
Contributor

nschonni commented Jul 9, 2019 •
edited
Loading

You can add the word to https://github.com/Azure/azure-rest-api-specs/blob/master/custom-words.txt
Although I think it should probably be "Whitelisting" without the "s" or "Whitelists"

@erelh
Copy link
Contributor Author

erelh commented Jul 10, 2019

@sergey-shandar can you please re-review ?
thanks

@sergey-shandar
Copy link
Contributor

We still need ARM approval

@erelh
Copy link
Contributor Author

erelh commented Jul 11, 2019

@ryansbenson @antmarti-microsoft @ravbhatnagar @KrisBash @majastrz @sanjaiganesh

Hi, this PR is documenting and existing API that is already Production GA.
Can you please review and approve ?

Thanks

@erelh
Copy link
Contributor Author

erelh commented Jul 12, 2019

friendly ping

@KrisBash
Copy link
Contributor

@erelh - If this is truly retrofitting API spec to a production API, there's not much we can do in review. I will sign off. Please note that APIs are expected to undergo review before shipping, and ideally before implementation.

KrisBash
KrisBash approved these changes Jul 16, 2019
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API is already in production...

@KrisBash KrisBash removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 16, 2019
@raych1 raych1 merged commit b7dc74e into Azure:master Jul 16, 2019
@erelh
Copy link
Contributor Author

erelh commented Jul 17, 2019

@raych1 how much time does it take for the changes to be reflected ?
in https://docs.microsoft.com/en-gb/rest/api/securitycenter/

@raych1
Copy link
Contributor

raych1 commented Jul 17, 2019

@erelh , normally the content would be refreshed in 12 hours.

@erelh
Copy link
Contributor Author

erelh commented Jul 17, 2019

@raych1 24 hours have passed, does this mean something went wrong ?

celikcigdem pushed a commit to celikcigdem/azure-rest-api-specs that referenced this pull request Jul 17, 2019
@erelh @celikcigdem
Add Microsoft.Security applicationWhitelistings API (Azure#6553)
bb6411e 
* initial commit

* Create applicationWhitelistings.json

initial commit

* Update readme.md

* converting from YAML to JSON, changing refs to common types

* add examples

* fix json

* add more rule types

* fix semantic issues

* fix ascLocation and try fix schema issues

* fix arrays definition + json parsing missing comma

* change descriptions, uppcase parameters, fix userName casing

* restructure

* redefine AppWhitelistingGroup object

* add "x-ms-parameter-location": "method" and return Azure Resource object in PUT reponse

* update PUT example after changing API

* add operation ID's

* remove location from example, add Executable to fileType

* remove location fomr GET GROUP Example

* add Whitelistings to custom-words
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nschonni nschonni nschonni left review comments

@sergey-shandar sergey-shandar sergey-shandar approved these changes

@KrisBash KrisBash KrisBash approved these changes

@raych1 raych1 raych1 approved these changes

Assignees

@raych1 raych1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@erelh @msftclas @AutorestCI @azuresdkci @raych1 @nschonni @sergey-shandar @KrisBash