Adding optional billing profile to VMSS Create and Update APIs for Api Version 2019-03-01 #6492

rakeshakkera · 2019-06-27T23:59:46Z

…ersion 2019-03-01

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

…ersion 2019-03-01

openapi-sdkautomation · 2019-06-27T23:59:48Z

SDK Automation [Logs] (Generated from 4d339d3)

Python: Azure/azure-sdk-for-python [Logs]

No packages generated.

Java: Azure/azure-sdk-for-java [Logs] [Diff]

compute/resource-manager/v2017_03_30 [Logs]
compute/resource-manager/v2017_09_01 [Logs] [Instructions]
compute/resource-manager/v2017_12_01 [Logs]
compute/resource-manager/v2018_04_01 [Logs] [Instructions]

JavaScript: Azure/azure-sdk-for-js [Logs]

No packages generated.

Go: Azure/azure-sdk-for-go [Logs]

No packages generated.

Ruby: Azure/azure-sdk-for-ruby [Logs] [Diff]

azure_sdk [Logs] [Instructions]
- azure_sdk-0.27.0.gem
data/compute [Logs]

msftclas · 2019-06-27T23:59:59Z

All CLA requirements met.

azuresdkci · 2019-06-28T00:00:32Z

Can one of the admins verify this patch?

AutorestCI · 2019-06-28T00:00:41Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 9a687ce41ca13d266dbe3b4047cc374575c4ae00
  stderr: 'fatal: reference is not a tree: 9a687ce41ca13d266dbe3b4047cc374575c4ae00'

AutorestCI · 2019-06-28T00:02:03Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2019-06-28T00:02:46Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 9a687ce41ca13d266dbe3b4047cc374575c4ae00
  stderr: 'fatal: reference is not a tree: 9a687ce41ca13d266dbe3b4047cc374575c4ae00'

AutorestCI · 2019-06-28T00:21:50Z

Automation for azure-sdk-for-java

Encountered an unknown error: (azure-sdk-for-java)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 9a687ce41ca13d266dbe3b4047cc374575c4ae00
  stderr: 'fatal: reference is not a tree: 9a687ce41ca13d266dbe3b4047cc374575c4ae00'

hyonholee · 2019-06-28T00:57:13Z

specification/compute/resource-manager/Microsoft.Compute/stable/2019-03-01/compute.json

@@ -6208,6 +6208,14 @@
      },
      "description": "Specifies the boot diagnostic settings state. <br><br>Minimum api-version: 2015-06-15."
    },
+    "BillingProfile": {
+      "maxPrice": {


move this property to inside of "properties":

Thank you for pointing out. This was causing the error initially. Made the change.

zikalino · 2019-07-03T01:12:20Z

specification/compute/resource-manager/Microsoft.Compute/stable/2019-03-01/compute.json

+        },
+        "billingProfile": {
+          "$ref": "#/definitions/BillingProfile",
+          "description": "Specifies the billing related details of a low priority VMSS. <br><br>Minimum api-version: 2019-03-01."


I wonder if we need description here. It seems exactly the same as in referred type definition.

zikalino

looks good!

zikalino · 2019-07-03T01:15:41Z

@hyonholee is it ok to merge?

Adding optional billing profile to VMSS Set and Update APIs for Api V…

055b2ad

…ersion 2019-03-01

rakeshakkera requested review from huangpf and hyonholee as code owners June 27, 2019 23:59

azuresdkci assigned zikalino Jun 28, 2019

azuresdkci requested a review from zikalino June 28, 2019 00:01

rakeshakkera changed the title ~~Adding optional billing profile to VMSS Set and Update APIs for Api Version 2019-03-01~~ Adding optional billing profile to VMSS Create and Update APIs for Api Version 2019-03-01 Jun 28, 2019

hyonholee reviewed Jun 28, 2019

View reviewed changes

Added propeties block for Billing profile and put max price in it

4d339d3

hyonholee added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 1, 2019

zikalino reviewed Jul 3, 2019

View reviewed changes

zikalino approved these changes Jul 3, 2019

View reviewed changes

rakeshakkera closed this Jul 9, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding optional billing profile to VMSS Create and Update APIs for Api Version 2019-03-01 #6492

Adding optional billing profile to VMSS Create and Update APIs for Api Version 2019-03-01 #6492

rakeshakkera commented Jun 27, 2019

openapi-sdkautomation bot commented Jun 27, 2019 •

edited

Loading

msftclas commented Jun 27, 2019 •

edited

Loading

azuresdkci commented Jun 28, 2019

AutorestCI commented Jun 28, 2019 •

edited

Loading

AutorestCI commented Jun 28, 2019 •

edited

Loading

AutorestCI commented Jun 28, 2019 •

edited

Loading

AutorestCI commented Jun 28, 2019 •

edited

Loading

hyonholee Jun 28, 2019

rakeshakkera Jun 28, 2019

zikalino Jul 3, 2019

zikalino left a comment

zikalino commented Jul 3, 2019

Adding optional billing profile to VMSS Create and Update APIs for Api Version 2019-03-01 #6492

Adding optional billing profile to VMSS Create and Update APIs for Api Version 2019-03-01 #6492

Conversation

rakeshakkera commented Jun 27, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

openapi-sdkautomation bot commented Jun 27, 2019 • edited Loading

SDK Automation [Logs] (Generated from 4d339d3)

msftclas commented Jun 27, 2019 • edited Loading

azuresdkci commented Jun 28, 2019

AutorestCI commented Jun 28, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Jun 28, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Jun 28, 2019 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Jun 28, 2019 • edited Loading

Automation for azure-sdk-for-java

hyonholee Jun 28, 2019

Choose a reason for hiding this comment

rakeshakkera Jun 28, 2019

Choose a reason for hiding this comment

zikalino Jul 3, 2019

Choose a reason for hiding this comment

zikalino left a comment

Choose a reason for hiding this comment

zikalino commented Jul 3, 2019

openapi-sdkautomation bot commented Jun 27, 2019 •

edited

Loading

msftclas commented Jun 27, 2019 •

edited

Loading

AutorestCI commented Jun 28, 2019 •

edited

Loading

AutorestCI commented Jun 28, 2019 •

edited

Loading

AutorestCI commented Jun 28, 2019 •

edited

Loading

AutorestCI commented Jun 28, 2019 •

edited

Loading