BUG fix: Fixing type of MetricValue.Count to be double instead of the incorrect int64 it had before #6485

gucalder · 2019-06-27T18:58:46Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

…evel argument Azure#2565

… API (Azure#2655)

… Adding documentation to reduce number of warnings in validation.

…breaking change

…s objects

…t int64 it had before

openapi-sdkautomation · 2019-06-27T18:58:52Z

SDK Automation [Logs] (Generated from 5251be8)

Python: Azure/azure-sdk-for-python

Package generation pending.

Java: Azure/azure-sdk-for-java

Package generation pending.

Go: Azure/azure-sdk-for-go

Package generation pending.

JavaScript: Azure/azure-sdk-for-js

Package generation pending.

Ruby: Azure/azure-sdk-for-ruby

Package generation pending.

AutorestCI · 2019-06-27T19:00:17Z

Automation for azure-sdk-for-ruby

A PR has been created for you:
Azure/azure-sdk-for-ruby#2695

AutorestCI · 2019-06-27T19:00:22Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#6107

AutorestCI · 2019-06-27T19:01:33Z

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2993

AutorestCI · 2019-06-27T19:02:43Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5206

azuresdkci · 2019-06-27T19:20:58Z

Can one of the admins verify this patch?

gucalder · 2019-06-28T18:16:24Z

Addresses issue #5130

gucalder · 2019-06-28T18:18:30Z

Issue #2371 has been addressed before. It is no longer a valid issue, since the Metrics_list argument is already declared as an integer.

gucalder · 2019-06-28T18:23:49Z

Issue #2513 has already been addressed too: the names of top and orderby no longer reference the $ sign they used to reference.

gucalder · 2019-06-28T18:29:37Z

Issue #2575 has been addressed too: the name of the query parameter "metric" changed to "metricnames" as required.

nschonni · 2019-06-28T19:25:56Z

specification/monitor/resource-manager/Microsoft.Insights/stable/2018-01-01/metrics_API.json

-          "type": "integer",
-          "format": "int64",
+          "type": "number",
+          "format": "double",


It seems like "count" should be a whole number. Can you get a count of 1.5?

Yeap, we discuss whether to change it in the backend (and leave this spec as it was) or change it in the spec. The reason for it to be a double (NOTE: we do not generate the metric, we just pass it on) is uncertain, but it might have something to do with the fact that this could actually be the average of several counts.

We thought that it after that, we decided to change the spec to reflect the current response of the backend to minimize customer impact.

OK, you might consider changing the name in the future then, since a count shouldn't be able to be a double AFAIK

… and it requires at least a start time.

gucalder · 2019-06-28T20:07:07Z

The latest change is a bug in the spec (#2467.) The $filter is actually not optional in the ActivityLogs API and it requires at least the start date/time. So I removed two examples that were missing the $filter.

# Conflicts: # specification/monitor/resource-manager/Microsoft.Insights/stable/2015-04-01/activityLogs_API.json # specification/monitor/resource-manager/Microsoft.Insights/stable/2015-04-01/examples/GetActivityLogsNoParams.json # specification/monitor/resource-manager/Microsoft.Insights/stable/2015-04-01/examples/GetActivityLogsSelected.json Signed-off-by: Guillermo Calderón_Meza <gucalder@microsoft.com>

gucalder · 2019-07-03T19:50:29Z

Can I, please, have this PR merged?

… incorrect int64 it had before (Azure#6485) * [Monitor] Make all attributes of EventData class readonly (Azure#2254) * [Monitor] Fixing issue with metricnamespace specification as client level argument Azure#2565 * [Monitor] Fixing incorrect specification of top parameter for Metrics API (Azure#2655) * Add two missing "by subscription" operations. * Remove "examples" nodes as requested since they are not used anymore. Adding documentation to reduce number of warnings in validation. * Add the serviceBusRuleId back into the DiagnosticSetting resource spec. * Fix some issues with the examples * [Monitor] Fix issue Azure#3585: revert previous commit since it is a breaking change * Add unit "BitsPerSecond" to the metrics specs. * Fixing workspace Id documentation * Add the Log Analytics destination type flag to the Diagnostic Settings objects * Fix a typo in a description * Fixing type of MetricValue.Count to be double instead of the incorrect int64 it had before * Fixing issue Azure#2467 In List Activity Logs $filter is not optional and it requires at least a start time.

gucalder added 29 commits February 7, 2018 10:35

[Monitor] Make all attributes of EventData class readonly (Azure#2254)

00a5689

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

b0ca590

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

8c3746f

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

799c13f

[Monitor] Fixing issue with metricnamespace specification as client l…

067e5a9

…evel argument Azure#2565

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

5c64ca3

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

a227d3f

[Monitor] Fixing incorrect specification of top parameter for Metrics…

189d112

… API (Azure#2655)

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

e0ff7d6

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

5adef1e

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

4c653be

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

3b52ba4

Add two missing "by subscription" operations.

4afd2b6

Remove "examples" nodes as requested since they are not used anymore.…

840fcf1

… Adding documentation to reduce number of warnings in validation.

Add the serviceBusRuleId back into the DiagnosticSetting resource spec.

8e22a06

Fix some issues with the examples

cc4855d

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

3c3f34d

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

03bdcd7

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

9068f5e

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

10e9834

[Monitor] Fix issue Azure#3585: revert previous commit since it is a …

1ca7f22

…breaking change

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

0ab44af

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

67216df

Add unit "BitsPerSecond" to the metrics specs.

e55d50c

Fixing workspace Id documentation

e14f5f8

Add the Log Analytics destination type flag to the Diagnostic Setting…

d177b96

…s objects

Fix a typo in a description

6a8e159

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

4668346

Fixing type of MetricValue.Count to be double instead of the incorrec…

0602217

…t int64 it had before

azuresdkci assigned shahabhijeet Jun 27, 2019

azuresdkci requested a review from shahabhijeet June 27, 2019 18:59

AutorestCI mentioned this pull request Jun 27, 2019

[AutoPR monitor/resource-manager] BUG fix: Fixing type of MetricValue.Count to be double instead of the incorrect int64 it had before Azure/azure-sdk-for-python#6142

Merged

AutorestCI mentioned this pull request Jun 27, 2019

[AutoPR monitor/resource-manager] BUG fix: Fixing type of MetricValue.Count to be double instead of the incorrect int64 it had before Azure/azure-sdk-for-java#4164

Merged

AutorestCI mentioned this pull request Jun 27, 2019

[AutoPR monitor/resource-manager] BUG fix: Fixing type of MetricValue.Count to be double instead of the incorrect int64 it had before Azure/azure-sdk-for-go#5152

Merged

This was referenced Jun 28, 2019

Metric API Metrics_List top parameter is modeled as number #2371

Closed

[Monitor] Fix syntax on Metrics Swagger Spec #2513

Closed

[Monitor] The queryparameter 'metric' is renamed to 'metricnames' in new metrics API #2575

Closed

nschonni reviewed Jun 28, 2019

View reviewed changes

Fixing issue Azure#2467 In List Activity Logs $filter is not optional…

2af54a5

… and it requires at least a start time.

AutorestCI mentioned this pull request Jul 1, 2019

[AutoPR monitor/resource-manager] BUG fix: Fixing type of MetricValue.Count to be double instead of the incorrect int64 it had before Azure/azure-sdk-for-ruby#2695

Closed

lmazuel merged commit ca0869b into Azure:master Jul 8, 2019

lmazuel mentioned this pull request Jul 8, 2019

MetricValue.count incorrectly marked as int64, service returns a float #5130

Closed

gucalder mentioned this pull request Aug 2, 2019

Adding units to the Metrics API, adding one attribute to the DiagnosticSettings API, updating documentation Azure/azure-sdk-for-net#7074

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BUG fix: Fixing type of MetricValue.Count to be double instead of the incorrect int64 it had before #6485

BUG fix: Fixing type of MetricValue.Count to be double instead of the incorrect int64 it had before #6485

gucalder commented Jun 27, 2019

openapi-sdkautomation bot commented Jun 27, 2019 •

edited

Loading

AutorestCI commented Jun 27, 2019 •

edited

Loading

AutorestCI commented Jun 27, 2019 •

edited

Loading

AutorestCI commented Jun 27, 2019 •

edited

Loading

AutorestCI commented Jun 27, 2019 •

edited

Loading

azuresdkci commented Jun 27, 2019

gucalder commented Jun 28, 2019

gucalder commented Jun 28, 2019

gucalder commented Jun 28, 2019

gucalder commented Jun 28, 2019

nschonni Jun 28, 2019 •

edited

Loading

gucalder Jun 28, 2019

nschonni Jun 28, 2019

gucalder commented Jun 28, 2019 •

edited

Loading

gucalder commented Jul 3, 2019

BUG fix: Fixing type of MetricValue.Count to be double instead of the incorrect int64 it had before #6485

BUG fix: Fixing type of MetricValue.Count to be double instead of the incorrect int64 it had before #6485

Conversation

gucalder commented Jun 27, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

openapi-sdkautomation bot commented Jun 27, 2019 • edited Loading

SDK Automation [Logs] (Generated from 5251be8)

AutorestCI commented Jun 27, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Jun 27, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Jun 27, 2019 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Jun 27, 2019 • edited Loading

Automation for azure-sdk-for-go

azuresdkci commented Jun 27, 2019

gucalder commented Jun 28, 2019

gucalder commented Jun 28, 2019

gucalder commented Jun 28, 2019

gucalder commented Jun 28, 2019

nschonni Jun 28, 2019 • edited Loading

Choose a reason for hiding this comment

gucalder Jun 28, 2019

Choose a reason for hiding this comment

nschonni Jun 28, 2019

Choose a reason for hiding this comment

gucalder commented Jun 28, 2019 • edited Loading

gucalder commented Jul 3, 2019

openapi-sdkautomation bot commented Jun 27, 2019 •

edited

Loading

AutorestCI commented Jun 27, 2019 •

edited

Loading

AutorestCI commented Jun 27, 2019 •

edited

Loading

AutorestCI commented Jun 27, 2019 •

edited

Loading

AutorestCI commented Jun 27, 2019 •

edited

Loading

nschonni Jun 28, 2019 •

edited

Loading

gucalder commented Jun 28, 2019 •

edited

Loading